From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28427C3DA7A for ; Fri, 6 Jan 2023 14:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232153AbjAFOmJ (ORCPT ); Fri, 6 Jan 2023 09:42:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229701AbjAFOmI (ORCPT ); Fri, 6 Jan 2023 09:42:08 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B8736D50D for ; Fri, 6 Jan 2023 06:42:07 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDnv2-0008Cb-UT; Fri, 06 Jan 2023 15:42:04 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pDnv1-0005va-I6; Fri, 06 Jan 2023 15:42:03 +0100 Date: Fri, 6 Jan 2023 15:42:03 +0100 From: Michael Tretter To: Laurent Pinchart Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/8] media: imx-pxp: add support for i.MX7D Message-ID: <20230106144203.GG24101@pengutronix.de> Mail-Followup-To: Michael Tretter , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org References: <20230105134729.59542-1-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 06 Jan 2023 14:41:32 +0200, Laurent Pinchart wrote: > Hi Michael, > > On Thu, Jan 05, 2023 at 02:47:21PM +0100, Michael Tretter wrote: > > This series adds support for the PXP found on the i.MX7D to the imx-pxp > > driver. > > > > The PXP on the i.MX7D has a few differences compared to the one on the > > i.MX6ULL. Especially, it has more processing blocks and slightly different > > multiplexers to route the data between the blocks. Therefore, the driver must > > configure a different data path depending on the platform. > > > > While the PXP has a version register, the reported version is the same on the > > i.MX6ULL and the i.MX7D. Therefore, we cannot use the version register to > > change the driver behavior, but have to use the device tree compatible. The > > driver still prints the found version to the log to help bringing up the PXP > > on further platforms. > > > > The patches are inspired by some earlier patches [0] by Laurent to add PXP > > support to the i.MX7d. Compared to the earlier patches, these patches add > > different behavior depending on the platform. Furthermore, the patches disable > > only the LUT block, but keep the rotator block enabled, as it may now be > > configured via the V4L2 rotate control. > > Sounds good to me. > > > Patch 1 converts the dt-binding to yaml. > > > > Patches 2 to 5 cleanup and refactor the driver in preparation of handling > > different PXP versions. > > > > Patches 6 and 7 add the handling of different platforms and the i.MX7d > > specific configuration. > > > > Patch 8 adds the device tree node for the PXP to the i.MX7d device tree. > > I've reviewed the whole series and comments are mostly minor. As you're > reminding me of the PXP, I'll take this as an opportunity to post > patches that I've had in my tree for way too long :-) There will be > minor conflicts with yours, so I'll first rebase them on this series, > assuming that v2 will be similar in places where conflicts occur. Thanks for the review! I will send a v2 to address your comments. Thanks for your other patches as well. I will take a look and probably just include them in my v2. Michael > > > Michael > > > > [0] https://lore.kernel.org/linux-media/20200510223100.11641-1-laurent.pinchart@ideasonboard.com/ > > > > Michael Tretter (8): > > media: dt-bindings: media: fsl-pxp: convert to yaml > > media: imx-pxp: detect PXP version > > media: imx-pxp: extract helper function to setup data path > > media: imx-pxp: explicitly disable unused blocks > > media: imx-pxp: disable LUT block > > media: imx-pxp: make data_path_ctrl0 platform dependent > > media: imx-pxp: add support for i.MX7D > > ARM: dts: imx7d: add node for PXP > > > > .../bindings/media/fsl,imx6ull-pxp.yaml | 62 ++++++++ > > .../devicetree/bindings/media/fsl-pxp.txt | 26 --- > > arch/arm/boot/dts/imx7d.dtsi | 9 ++ > > drivers/media/platform/nxp/imx-pxp.c | 148 +++++++++++++++--- > > 4 files changed, 197 insertions(+), 48 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml > > delete mode 100644 Documentation/devicetree/bindings/media/fsl-pxp.txt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5955DC54EBE for ; Fri, 6 Jan 2023 14:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eiztanvPskGiPhvczmMoAfYNo93DhJoVMyBM4qiypCw=; b=cLnYdJKKYTmEhX tTQx2AlKWI+5ExIHsiMlSjB4prB1AgbuRRnToSiSM7If5NJVIIHrqcC+rS+FHZWH6qlA5vP5UKOHD l1PMTMiTvANPDNqImK6zIGUzoiHAmADnItmE8Cpo6E2dkdiWcU5bkOHEz+hnKHxQBCm59a5ywG9Nj yArDndIwve6rXjcqQVMfVGDXI7L3ZL51thr5hS1A4+WQX+5WVvUG+nP74jxLQPUl2yiuyfSw85xtK m1UvxCC9SnHpEh1gjB4DF2cDWpYBbMkNtvrLcqx1OUwzD25TdiaA/QZaEy2EA80FLI9B3jpjeWkF7 7PAD/QHlQoUegHfuLuqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDnvF-008sAw-Vs; Fri, 06 Jan 2023 14:42:18 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDnvC-008s9N-Dw for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 14:42:16 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDnv2-0008Cb-UT; Fri, 06 Jan 2023 15:42:04 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pDnv1-0005va-I6; Fri, 06 Jan 2023 15:42:03 +0100 Date: Fri, 6 Jan 2023 15:42:03 +0100 From: Michael Tretter To: Laurent Pinchart Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/8] media: imx-pxp: add support for i.MX7D Message-ID: <20230106144203.GG24101@pengutronix.de> Mail-Followup-To: Michael Tretter , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org References: <20230105134729.59542-1-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230106_064214_485395_80E7A1E7 X-CRM114-Status: GOOD ( 37.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 06 Jan 2023 14:41:32 +0200, Laurent Pinchart wrote: > Hi Michael, > > On Thu, Jan 05, 2023 at 02:47:21PM +0100, Michael Tretter wrote: > > This series adds support for the PXP found on the i.MX7D to the imx-pxp > > driver. > > > > The PXP on the i.MX7D has a few differences compared to the one on the > > i.MX6ULL. Especially, it has more processing blocks and slightly different > > multiplexers to route the data between the blocks. Therefore, the driver must > > configure a different data path depending on the platform. > > > > While the PXP has a version register, the reported version is the same on the > > i.MX6ULL and the i.MX7D. Therefore, we cannot use the version register to > > change the driver behavior, but have to use the device tree compatible. The > > driver still prints the found version to the log to help bringing up the PXP > > on further platforms. > > > > The patches are inspired by some earlier patches [0] by Laurent to add PXP > > support to the i.MX7d. Compared to the earlier patches, these patches add > > different behavior depending on the platform. Furthermore, the patches disable > > only the LUT block, but keep the rotator block enabled, as it may now be > > configured via the V4L2 rotate control. > > Sounds good to me. > > > Patch 1 converts the dt-binding to yaml. > > > > Patches 2 to 5 cleanup and refactor the driver in preparation of handling > > different PXP versions. > > > > Patches 6 and 7 add the handling of different platforms and the i.MX7d > > specific configuration. > > > > Patch 8 adds the device tree node for the PXP to the i.MX7d device tree. > > I've reviewed the whole series and comments are mostly minor. As you're > reminding me of the PXP, I'll take this as an opportunity to post > patches that I've had in my tree for way too long :-) There will be > minor conflicts with yours, so I'll first rebase them on this series, > assuming that v2 will be similar in places where conflicts occur. Thanks for the review! I will send a v2 to address your comments. Thanks for your other patches as well. I will take a look and probably just include them in my v2. Michael > > > Michael > > > > [0] https://lore.kernel.org/linux-media/20200510223100.11641-1-laurent.pinchart@ideasonboard.com/ > > > > Michael Tretter (8): > > media: dt-bindings: media: fsl-pxp: convert to yaml > > media: imx-pxp: detect PXP version > > media: imx-pxp: extract helper function to setup data path > > media: imx-pxp: explicitly disable unused blocks > > media: imx-pxp: disable LUT block > > media: imx-pxp: make data_path_ctrl0 platform dependent > > media: imx-pxp: add support for i.MX7D > > ARM: dts: imx7d: add node for PXP > > > > .../bindings/media/fsl,imx6ull-pxp.yaml | 62 ++++++++ > > .../devicetree/bindings/media/fsl-pxp.txt | 26 --- > > arch/arm/boot/dts/imx7d.dtsi | 9 ++ > > drivers/media/platform/nxp/imx-pxp.c | 148 +++++++++++++++--- > > 4 files changed, 197 insertions(+), 48 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml > > delete mode 100644 Documentation/devicetree/bindings/media/fsl-pxp.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel