From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 018CEC3DA7A for ; Fri, 6 Jan 2023 17:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234839AbjAFRBA (ORCPT ); Fri, 6 Jan 2023 12:01:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231527AbjAFRAx (ORCPT ); Fri, 6 Jan 2023 12:00:53 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F8A741648 for ; Fri, 6 Jan 2023 09:00:51 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id z16so1839418wrw.1 for ; Fri, 06 Jan 2023 09:00:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NPGjO3GLxwuKoc7lZtIvtYmPySePxCmc9A8414gqSgU=; b=euSC14S8bRke4P9nxYzrLsV7/Rs+V6Xwl16eqrk35fgRXHrcJW5M+EQ3TnnmVVz0OG imulyWr/yTkRznDSLBl6k+WUX9Hs08bCyaj/QtWTBFWr7PY4Bs/uZgGVLA+u+G0kjK1Q qXyAQWkNWXr2Jtmwao2CR7rfbv8Gr9gBMeR00JF4LoZPF4CGI8jAAZLlvp+/VbpPfmIo 4eeQb6ZkqPijQpvRdJPZbbz8MfSqPjoTyC40kWVWydVWtcd5HC6/wjxYGrCZJJ8aS6w/ OHJDK985nTHcaHYGlN3Uos/RdUc/afXFpdOH7junzOIQUY5F7bbBQggu0lFe/Q4h5PNO TfVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NPGjO3GLxwuKoc7lZtIvtYmPySePxCmc9A8414gqSgU=; b=Bhtn5pCRkl+mfrXUaR6tZXeZhu5GXE/LqX0i4lxB/140x5k4OL+bAUDqFqaBxlt1FT CWSdtQBwjpNIJlA9nN/SSPLcZgNcYICNAbGqykw8DsQtBH/+RDfnw/BmupEsjyElrih0 iXvnqkSZiJU9TChxA3mXhwrgKwQJwoFxCbX42U5YTsVXVAt8dLGwsPHcVgQmdUrlDHTN 5ol4woWG2bYjglI9AG5Fdyni596/ppO/WXR/TLowUdPCpKUjWap/KTXwOL7k8H4gl9W5 cUp+vSULDz8PcKfcEr1WEO8eKeUn3SBp6k2/brlXfvKzSJg/F8uhy4GZHP75Wv79WiiS Anqg== X-Gm-Message-State: AFqh2kqRZhaV5OXv7LKmVlFkejwe1k4QXnemTHmhmBx538mwU2K79D2q xHK6eCIB6bE291jAZTPpggA4eQ== X-Google-Smtp-Source: AMrXdXuFqZYcBKNOWyaXZXz+967P6PyjNmHIk3ic4subWD87vHVwOE8AwQVtHuWeEOjpKP7UFEo2PQ== X-Received: by 2002:adf:da51:0:b0:2b6:daf8:52ad with SMTP id r17-20020adfda51000000b002b6daf852admr3402719wrl.52.1673024449899; Fri, 06 Jan 2023 09:00:49 -0800 (PST) Received: from blmsp ([2001:4091:a245:805c:8713:84e4:2a9e:cbe8]) by smtp.gmail.com with ESMTPSA id f8-20020a0560001b0800b002423edd7e50sm1633417wrz.32.2023.01.06.09.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 09:00:49 -0800 (PST) Date: Fri, 6 Jan 2023 18:00:48 +0100 From: Markus Schneider-Pargmann To: Chen-Yu Tsai Cc: AngeloGioacchino Del Regno , mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johnson.wang@mediatek.com, miles.chen@mediatek.com, fparent@baylibre.com, chun-jie.chen@mediatek.com, sam.shih@mediatek.com, y.oudjana@protonmail.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, ryder.lee@kernel.org, daniel@makrotopia.org, jose.exposito89@gmail.com, yangyingliang@huawei.com, pablo.sun@mediatek.com, weiyi.lu@mediatek.com, ikjn@chromium.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v2 04/23] clk: mediatek: cpumux: Propagate struct device where possible Message-ID: <20230106170048.p4d3rq6kehmf3adp@blmsp> References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221223094259.87373-5-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Angelo, On Mon, Dec 26, 2022 at 03:07:10PM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno > wrote: > > > > Take a pointer to a struct device in mtk_clk_register_cpumuxes() and > > propagate the same to mtk_clk_register_cpumux() => clk_hw_register(). > > Even though runtime pm is unlikely to be used with CPU muxes, this > > helps with code consistency and possibly opens to commonization of > > some mtk_clk_register_(x) functions. > > > > Signed-off-by: AngeloGioacchino Del Regno > > Reviewed-by: Chen-Yu Tsai > > As with the gates patch, could we make the |struct device *| parameter the > first one? Also for this case I think we could even drop the > |struct device_node *| parameter. Reviewed-by: Markus Schneider-Pargmann clk_hw_register and others are using the device pointer as first parameter as well. So I think it makes sense to do it the same way as ChenYu suggested. Best, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF7FEC54E76 for ; Fri, 6 Jan 2023 17:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h1h3m8DCi63G8DWHLeK299Jeb5fbp68EjAtVRqkD6UU=; b=VSAj65qq5kI64m pTWZR+czjtYZu45z5u/5+E1jT/nJEWKgAL8641oVTEUNbsMFcSJz6RyODUEj0QqYtoe5HJymBYaVs yxbWHQDlU4rXsf9ZGpsXEy6iMV79YeAl1rYMTX760SemGTMiCCb+DRVdT1TvPjKkR+P3efJA1lW+t qBiw3UP8SVTzuYGZyQM/aSkhQX3OGfAFgkfHh2GLQlyZgBXu+PoCFzDr0EMexy4KVrf6RLrm8uAHy JfZg1KqSZCSmhm4WICdded79MRCCW6N4sgzC9skImian5Uu1kmSQIQbXYmT9rRPkga5p50N9v3W9e ei66uG+Oo9q2/ZAsbuIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDqGG-00BBGm-Bj; Fri, 06 Jan 2023 17:12:09 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDq5P-00AroD-6Y for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 17:00:57 +0000 Received: by mail-wr1-x429.google.com with SMTP id z16so1839417wrw.1 for ; Fri, 06 Jan 2023 09:00:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NPGjO3GLxwuKoc7lZtIvtYmPySePxCmc9A8414gqSgU=; b=euSC14S8bRke4P9nxYzrLsV7/Rs+V6Xwl16eqrk35fgRXHrcJW5M+EQ3TnnmVVz0OG imulyWr/yTkRznDSLBl6k+WUX9Hs08bCyaj/QtWTBFWr7PY4Bs/uZgGVLA+u+G0kjK1Q qXyAQWkNWXr2Jtmwao2CR7rfbv8Gr9gBMeR00JF4LoZPF4CGI8jAAZLlvp+/VbpPfmIo 4eeQb6ZkqPijQpvRdJPZbbz8MfSqPjoTyC40kWVWydVWtcd5HC6/wjxYGrCZJJ8aS6w/ OHJDK985nTHcaHYGlN3Uos/RdUc/afXFpdOH7junzOIQUY5F7bbBQggu0lFe/Q4h5PNO TfVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NPGjO3GLxwuKoc7lZtIvtYmPySePxCmc9A8414gqSgU=; b=kdMnlU6jNBu1nClj+4huPZpXoBn4mnqabJx0FF0Er75CxWi2GW6f64OG9sPsJTfg4+ cMkE+2K2GSihWfcKpbDgG+/BXhizCe5/eVSP0btck0/pYnh3Za+7Axrgg9toX9WgYdGF /hL/FSkUGwGJADq/Z6zSYpkShzvFKkjy57X1099xJ3noRdx1UzY5XG5kZ2spoog4GmKz TyuYPj+XXVZTjfFT0qK1GHZXp1XdxX2+zj5iO0+v4Jent4QbY7FpNwVCKuesRsPAh7u7 eHOYbqQWhQRRIob2ZccDACX9VswMRMkXEglNbsD+OmFAqE+Jq/7YQpu4DKOlq/H3D9qB bh9Q== X-Gm-Message-State: AFqh2kp/5voFfT1y4BGQ+CJdXVWjDo012tP4kTmZuJcOJKMi2l+afjlj sUyUJxuOkblgNa89J/9xFebz4Q== X-Google-Smtp-Source: AMrXdXuFqZYcBKNOWyaXZXz+967P6PyjNmHIk3ic4subWD87vHVwOE8AwQVtHuWeEOjpKP7UFEo2PQ== X-Received: by 2002:adf:da51:0:b0:2b6:daf8:52ad with SMTP id r17-20020adfda51000000b002b6daf852admr3402719wrl.52.1673024449899; Fri, 06 Jan 2023 09:00:49 -0800 (PST) Received: from blmsp ([2001:4091:a245:805c:8713:84e4:2a9e:cbe8]) by smtp.gmail.com with ESMTPSA id f8-20020a0560001b0800b002423edd7e50sm1633417wrz.32.2023.01.06.09.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 09:00:49 -0800 (PST) Date: Fri, 6 Jan 2023 18:00:48 +0100 From: Markus Schneider-Pargmann To: Chen-Yu Tsai Cc: AngeloGioacchino Del Regno , mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johnson.wang@mediatek.com, miles.chen@mediatek.com, fparent@baylibre.com, chun-jie.chen@mediatek.com, sam.shih@mediatek.com, y.oudjana@protonmail.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, ryder.lee@kernel.org, daniel@makrotopia.org, jose.exposito89@gmail.com, yangyingliang@huawei.com, pablo.sun@mediatek.com, weiyi.lu@mediatek.com, ikjn@chromium.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v2 04/23] clk: mediatek: cpumux: Propagate struct device where possible Message-ID: <20230106170048.p4d3rq6kehmf3adp@blmsp> References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221223094259.87373-5-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230106_090055_259940_047E84C0 X-CRM114-Status: GOOD ( 17.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Angelo, On Mon, Dec 26, 2022 at 03:07:10PM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno > wrote: > > > > Take a pointer to a struct device in mtk_clk_register_cpumuxes() and > > propagate the same to mtk_clk_register_cpumux() => clk_hw_register(). > > Even though runtime pm is unlikely to be used with CPU muxes, this > > helps with code consistency and possibly opens to commonization of > > some mtk_clk_register_(x) functions. > > > > Signed-off-by: AngeloGioacchino Del Regno > > Reviewed-by: Chen-Yu Tsai > > As with the gates patch, could we make the |struct device *| parameter the > first one? Also for this case I think we could even drop the > |struct device_node *| parameter. Reviewed-by: Markus Schneider-Pargmann clk_hw_register and others are using the device pointer as first parameter as well. So I think it makes sense to do it the same way as ChenYu suggested. Best, Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel