From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81F86C3DA7A for ; Fri, 6 Jan 2023 17:25:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8A86285203; Fri, 6 Jan 2023 18:25:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="raj8YeVs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 46C5885203; Fri, 6 Jan 2023 18:25:32 +0100 (CET) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 19D3F84E00 for ; Fri, 6 Jan 2023 18:25:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id v14so2620968qtq.3 for ; Fri, 06 Jan 2023 09:25:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hV5g11wq98YkGPVETImjOYXcLeUQeoEQVHU41towk7c=; b=raj8YeVsbQcAy3XQbb3i4dD72RpRkekybzZS7poXb5xVMzNS+2OXqrhDdbUC2krTEF 8vnZZloWjDjD2w+7GfdhsbLkNv/T7vteyGrrRmc1Ucw34td1935KYs9Ssdf+28dKnDlT HcrrSb2BF5RouCqI5hhJnG/9rVBiCgy7MQdPM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hV5g11wq98YkGPVETImjOYXcLeUQeoEQVHU41towk7c=; b=5Pb63wVYKtWiu/xYMGxv5NP/pt+KoIlAQbrMqCXBtBgpbpRPzEAbLxmh746mqm+BTJ VhnhnY7YnmNkEKIyNLN8v/4aiEFRwamAmZgfygi7dnj6Y4lMY209oEzaVnhaxubwQoZh Pnv+EP0g0MkIkrUYD3IIRxg5makSxTXs9PhGA1TEQfvS+LLsfWxKvntd5k7KIf+KXeJy XdV9f2/9S1RAnlGxBHY14xB+iQH3bwqNcNBFff5xt8Fx0DlZ80vHWh0RfTEyDWWC2dIX gzEwagINbTEPevGnbyyOtE9TClRNDhUBjEG8vxQXQej/k3SsLqCheTotDYC0dt9v7iNg kZpw== X-Gm-Message-State: AFqh2kqH24WrEiKRrkmVnRWd2Pq5Oh2ndKrMZPus6Q0N+NoTbOS1IHRB ru/8xarLPU6SPNyZdyyp37101g== X-Google-Smtp-Source: AMrXdXtle5kotLU7Zo6Hxv92H89jTrAjiRHyVoW+wnFPjRGLl6gcxcgEhjmKyBcgC43k3dQajoN2MA== X-Received: by 2002:ac8:4654:0:b0:3a8:1059:9800 with SMTP id f20-20020ac84654000000b003a810599800mr65489083qto.37.1673025926912; Fri, 06 Jan 2023 09:25:26 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-9162-adb5-1773-34c0.res6.spectrum.com. [2603:6081:7b00:6400:9162:adb5:1773:34c0]) by smtp.gmail.com with ESMTPSA id q8-20020ac87348000000b003a8163c1c96sm759460qtp.14.2023.01.06.09.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 09:25:26 -0800 (PST) Date: Fri, 6 Jan 2023 12:25:24 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: u-boot@lists.denx.de, Marek Vasut , Patrick Delaunay Subject: Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow" Message-ID: <20230106172524.GE3787616@bill-the-cat> References: <20230106155143.4025812-1-trini@konsulko.com> <20230106164543.3gtq73flpoocg7mc@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lnXFIHmoxvYfy8ks" Content-Disposition: inline In-Reply-To: <20230106164543.3gtq73flpoocg7mc@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --lnXFIHmoxvYfy8ks Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 06, 2023 at 05:45:43PM +0100, Pali Roh=E1r wrote: > On Friday 06 January 2023 10:51:43 Tom Rini wrote: > > This reverts commit 777aaaa706bcfe08c284aed06886db7d482af3f8. > >=20 > > The changes to this generic function, which is intended to help with > > 32bit platforms with large amounts of memory has unintended side effects > > (which in turn lead to boot failures) on other platforms which were > > previously functional. >=20 > As mentioned previously, unfortunately this revert breaks 32-bit u-boot > on 36-bit mpc85xx boards with 32-bit e500v2 cores and 4GB DDR module. >=20 > Which platforms currently have broken u-boot without this revert? The > only one which was reported is stm32mp but for it there different > workaround patch waiting in the queue. Are you able to test on one of these PowerPC platforms currently? As the stm32 problem shows, not everything is getting tested frequently enough, so how many other cases are lurking out there. And, I think overall issue is that the overflow check-and-change you introduce here should just be in the CONFIG_MAX_MEM_MAPPED=3D=3Dtrue case. As that's the case you're dealing with, yes? --=20 Tom --lnXFIHmoxvYfy8ks Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO4WYEACgkQFHw5/5Y0 tywrQwv+Kh8ohtAMcrJ4jNeRJN14nk3doOSXqKHsHhLVomlgFW+6IZXcAw496wkW RAlvqyFRRqKG1JDvDnpvPfHRklWOQCKSV4YFd7ytkbQylvS+R99V5MQMYdiGY4NN DqyVfe3jIl3ZRfrZC1Yq1yMvUsym5hvYmL1TlF4uFdk2e0HO06CHOVutGTGufX8K GPSAjEpfcWdySLEbiAgHa9w5lVqThWlaYD2aixFz2t9AYRGrbD2mdIjHXlKaD9zq LOnRnZmzFeq4a/KBAsJieQzK2AZI70akXV0zII7kQTifN+9vuq+8v7QaMFdwPIPF kz0OwU7IpDRiESrY9a67Ph8gylvTR9yjWue3TE1Ua8S9YpBOpROnCopD6ezrfnJp q4Q9GtaYoykn0BNsPH4zeYvvXuCd65FzstYdpDoX39GN1T54n1/fuSwALI4eqfKz qylrePEU/HsK3MOpQk34/x8VD3cFzcZh4IB7iGCq4ytthULbDSCps4n1zZ/wXo6i cCB63DGl =Pqmx -----END PGP SIGNATURE----- --lnXFIHmoxvYfy8ks--