From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF2D2C54EBC for ; Sat, 7 Jan 2023 17:32:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 44EB985506; Sat, 7 Jan 2023 18:32:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="TjzrjFCC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 846A485506; Sat, 7 Jan 2023 18:32:21 +0100 (CET) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 359AB854F1 for ; Sat, 7 Jan 2023 18:32:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id p17so3250867qvn.1 for ; Sat, 07 Jan 2023 09:32:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vy7zndBpOUOuZkue8d2Gm+qfVfAWAg4zB/AstCEKXzM=; b=TjzrjFCC3dYWufqWec4WmvSoRmJRt3hBk8DvidvRZhELGJFSivOY3JgQgcSsN/ZXMc H6VrV8OW2382MmG+GN7OlLKfJh6nO2+RwS+/hnIHU6clDPxIcFqEQlgzkjzEM/WHaSQD GUAqTFefHekAZ4destxqqq6Nqg26r+ZjlqLGo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vy7zndBpOUOuZkue8d2Gm+qfVfAWAg4zB/AstCEKXzM=; b=RPDvN0Avy7M7cDQ8eJS54K6ZpvQA20DkmdTG6CWsf8ZyFZIkxCWXijXqzBsoWvlbmr EA1HeqOFdadrz0TilcfcDEG355RnYRXHki6uNREoXxY15te4XDX9kIkLp1XAU2QAkZ9k HSzJ0sXg2qq2G8QW7BfwHfqWGCrnM1uzGbrwvVaOjH0IGZetYnQLOd2ktampVmuz/Aua 1m7PmzYrrH/zKyNGEgoy0lEOzDhvEiZex6fP49CJ5gF34POl4BEFmMVrDnGoG8Y0tCWn SMv8hj6rM2DgkIWwd/sy6MUUqybALhJyHzVQ5YOHzfNmDChccCENtPYxO3SixNZgt0kM 1Sog== X-Gm-Message-State: AFqh2kr1XenN5tDJ4YsadTYz4bOAx7dMKcItThfyLqYP8WndSUnm+xxH +IyYiRupzL8piLDQhFvV4jvv4UWOCw/vYc6LAY4= X-Google-Smtp-Source: AMrXdXtgcIzFAUn9oNqtWGzITlpoRKunqekgri3NrrvGR1jyKGyFiPMfoFGSM+Fclz4Gs1nn293Sag== X-Received: by 2002:a05:6214:3685:b0:532:1cfb:8094 with SMTP id nl5-20020a056214368500b005321cfb8094mr7608096qvb.17.1673112734921; Sat, 07 Jan 2023 09:32:14 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-64a1-0c30-ebd7-ca7b.res6.spectrum.com. [2603:6081:7b00:6400:64a1:c30:ebd7:ca7b]) by smtp.gmail.com with ESMTPSA id q6-20020a05620a0d8600b006fa43e139b5sm2440412qkl.59.2023.01.07.09.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Jan 2023 09:32:14 -0800 (PST) Date: Sat, 7 Jan 2023 12:32:12 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: u-boot@lists.denx.de, Marek Vasut , Patrick Delaunay Subject: Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow" Message-ID: <20230107173212.GN3787616@bill-the-cat> References: <20230106155143.4025812-1-trini@konsulko.com> <20230106164543.3gtq73flpoocg7mc@pali> <20230106172524.GE3787616@bill-the-cat> <20230106202256.bvjwcfsjbhzsfgrh@pali> <20230106211408.GH3787616@bill-the-cat> <20230106214541.GI3787616@bill-the-cat> <20230106220930.pmdjzmdwyx53ouwv@pali> <20230106225156.GJ3787616@bill-the-cat> <20230107162645.2ygz5rk2tlzmiogw@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ucYVwDvWe6ywop2g" Content-Disposition: inline In-Reply-To: <20230107162645.2ygz5rk2tlzmiogw@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --ucYVwDvWe6ywop2g Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 07, 2023 at 05:26:45PM +0100, Pali Roh=E1r wrote: > On Friday 06 January 2023 17:51:56 Tom Rini wrote: > > On Fri, Jan 06, 2023 at 11:09:30PM +0100, Pali Roh=E1r wrote: > > > On Friday 06 January 2023 16:45:41 Tom Rini wrote: > > > > On Fri, Jan 06, 2023 at 04:14:08PM -0500, Tom Rini wrote: > > > > > On Fri, Jan 06, 2023 at 09:22:56PM +0100, Pali Roh=E1r wrote: > > > > > > On Friday 06 January 2023 12:25:24 Tom Rini wrote: > > > > > > > On Fri, Jan 06, 2023 at 05:45:43PM +0100, Pali Roh=E1r wrote: > > > > > > > > On Friday 06 January 2023 10:51:43 Tom Rini wrote: > > > > > > > > > This reverts commit 777aaaa706bcfe08c284aed06886db7d482af= 3f8. > > > > > > > > >=20 > > > > > > > > > The changes to this generic function, which is intended t= o help with > > > > > > > > > 32bit platforms with large amounts of memory has unintend= ed side effects > > > > > > > > > (which in turn lead to boot failures) on other platforms = which were > > > > > > > > > previously functional. > > > > > > > >=20 > > > > > > > > As mentioned previously, unfortunately this revert breaks 3= 2-bit u-boot > > > > > > > > on 36-bit mpc85xx boards with 32-bit e500v2 cores and 4GB D= DR module. > > > > > > > >=20 > > > > > > > > Which platforms currently have broken u-boot without this r= evert? The > > > > > > > > only one which was reported is stm32mp but for it there dif= ferent > > > > > > > > workaround patch waiting in the queue. > > > > > > >=20 > > > > > > > Are you able to test on one of these PowerPC platforms curren= tly? As > > > > > > > the stm32 problem shows, not everything is getting tested fre= quently > > > > > > > enough, so how many other cases are lurking out there. And, = I think > > > > > > > overall issue is that the overflow check-and-change you intro= duce here > > > > > > > should just be in the CONFIG_MAX_MEM_MAPPED=3D=3Dtrue case. = As that's the > > > > > > > case you're dealing with, yes? > > > > > >=20 > > > > > > I was planning to do big retest again after all powerpc patches= are > > > > > > reviewed and merged... > > > > >=20 > > > > > Yes, but can you test one of them now, to see if my idea works? > > >=20 > > > Ok, I will try to look at during the weekend. > >=20 > > OK, good, thanks. > >=20 > > > > > > Anyway, if the issue here is with ram_size and its reduction wa= s needed > > > > > > for mpc85xx (at the time of introduction of that patch), what a= bout > > > > > > putting mpc85xx ifdef around ram_size reduction? For arm boards= it would > > > > > > have same behavior as revert of that commit and for mpc85xx it = would be > > > > > > no change. > > >=20 > > > This is what I mean: > > >=20 > > > #ifdef CONFIG_MPC85xx > > > if (gd->ram_base + ram_size < gd->ram_base) > > > ram_size =3D ...; > > > #endif > > >=20 > > > > > > I agree that this code needs to be revisited, together with ram= _top > > > > > > issue and also code which fills DDR banks. Because really mappe= d memory > > > > > > for u-boot and real size of DDR are two different things here. > > > > >=20 > > > > > The issue here is that we see two now (given Fabio's reminder abo= ut > > > > > another thread I had forgotten) of unintended consequences, on 32= bit > > > > > platforms trying to normally have 2GB of memory, which does not r= equire > > > > > special treatment. > > >=20 > > > Running git grep get_effective_memsize and git grep 'gd->ram_top' sho= ws > > > the root of this issue: Different platforms, boards and common code u= se > > > these things differently. This needs to be "fixed" =3D unified in who= le > > > codebase. We need a function which returns mappable memory for u-boot > > > (intptr_t type is enough) and another function (or structure or > > > whatever) which says total size of RAM as u64 type (to ensure that it > > > would work also for 4GB SODIMM modules on pure 32-bit platforms). And > > > then each place in u-boot code has to be modified to use the correct > > > function. > > >=20 > > > Second issue is then gd->ram_top. Either say 4GB for 32-bit ram_top t= ype > > > is not supported or say that zero value is special and represents 4GB. > > > And also every place in u-boot code needs to be adjusted by this > > > decision / code. > > >=20 > > > Fixing both issues make easily break lot of boards (if done improperl= y) > > > as it touches whole u-boot code base. So not easy task. > > >=20 > > > > What I'm leaning towards right now even, is that since it's hard to= test > > > > the non-36bit platforms that do set CONFIG_MAX_MEM_MAPPED, to see if > > > > their behavior also changed here, the 36bit platforms should just be > > > > overriding get_effective_memsize. > > >=20 > > > There are (at least) 3 situation: > > > 1) if RAM is mapped to the end of physical address space (possibly ju= st > > > small e.g. 1GB) > > > 2) if platform is >32-bit but running in 32-bit mode (so physical > > > address is u64 because we do not have e.g. int36_t; but void* is > > > 32-bit) > > > 3) if RAM is exactly 4GB and u-boot is 32-bit > > >=20 > > > And every one has different edge cases and cause different problems. > > > Now, as I pointed above that every platform / board is using > > > get_effective_memsize() differently, plus we have CONFIG_MAX_MEM_MAPP= ED > > > option, it means that number of test matrix is really huge. > > >=20 > > > It looks like that ARM issues are caused by the fact that RAM is mapp= ed > > > to the end of the physical address space (so it does not matter how b= ig > > > or small it is). And powerpc issue is 4GB of RAM together with running > > > in 32-bit mode. > > >=20 > > > Anyway, has U-Boot support for 32-bit x86 CPUs with PAE support? If y= es, > > > then I bet that there can be other edge cases when e.g. 8GB of DDR is > > > connected. > >=20 > > Yes, it's very much a mess, so for this release I'd like to return to > > either: > > - Status quo of v2022.10 (revert this patch) > > - Change only CONFIG_MAX_MEM_MAPPED being set behavior (should keep > > PowerPC 36bit working, may have unexpected impact on other platforms, > > still, but very few at least). >=20 > Yea, it is a mess. I'm looking at the CONFIG_MAX_MEM_MAPPED again and it > is for different situation. CONFIG_MAX_MEM_MAPPED says maximal mapped > memory. For mpc85xx it is by default set to 2GB for a very long time. > And if base physical address od the RAM is at 2GB or higher then it also > hits this 4GB limit. So CONFIG_MAX_MEM_MAPPED does not help there... Right, it's a mess. So, to try and end up with the least number of broken platforms for the coming release, would you rather a full revert, or just moving your changes under CONFIG_MAX_MEM_MAPPED being set, which I believe you're saying is the case for 36bit PowerPC ? --=20 Tom --ucYVwDvWe6ywop2g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO5rJwACgkQFHw5/5Y0 tyy87gv/bYoVFg8+TnJp+k9TiV5SwbaSCwsjmJPiDCpCYdz2IVNApQ+PhJaJ81dP i9Yr6VDoDwnFZEGnFcshysSAp5bWIVruQTDfneQWe+qZsTQ6J3D4lT+tWWHwey0v 3cgc0Y5AyUYg/PXmUvcI/wVj/1Xdgn5AqgAtDcxnKlza7d0EQBYcElWni1CFvSkk 1ZXG1LR0bl9Nkb/x0JsFvHSZ4vAadb2ser1rNJ39w9oaNu8CBG0tSxeAG14Az5JW 6OFjU38wPd1aiMcT9sik+kh+XPDk5VAeiBgFIvRgnD8APY0ZuO3GTmLAmPh7f/Ju bGY9mFHh7MtkAaszr47Zdz2mL+lXH3+22n/KgZFA5HCTbC8Br5jna82e1NKnf1dK bx71w6ORtJ6voUs2ORKOPylZ7UiX91aQ3CblJ2sHqvyPvULeF81Rb3uF22ZdztsJ WaKD+FwDE45P21SdZYA5J1+SehkeoBg3SIuK3xW0sFo3j15ykbZHNFClC9HA9Gry bw86bqN1 =m+3V -----END PGP SIGNATURE----- --ucYVwDvWe6ywop2g--