From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 961F9C54EBD for ; Sun, 8 Jan 2023 19:30:19 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NqnGd5XF5z3cL8 for ; Mon, 9 Jan 2023 06:30:17 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sk2.org (client-ip=178.33.251.80; helo=2.mo576.mail-out.ovh.net; envelope-from=steve@sk2.org; receiver=) Received: from 2.mo576.mail-out.ovh.net (2.mo576.mail-out.ovh.net [178.33.251.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NqnFy4yQKz3c2d for ; Mon, 9 Jan 2023 06:29:41 +1100 (AEDT) Received: from director10.ghost.mail-out.ovh.net (unknown [10.108.20.179]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id 088DA243B4 for ; Sun, 8 Jan 2023 19:29:37 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-5zc6k (unknown [10.111.208.1]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 256A21FF13; Sun, 8 Jan 2023 19:29:33 +0000 (UTC) Received: from sk2.org ([37.59.142.102]) by ghost-submission-6684bf9d7b-5zc6k with ESMTPSA id NzpKBp0Zu2OoSAEAosFdow (envelope-from ); Sun, 08 Jan 2023 19:29:33 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-102R00419398439-321a-44a9-9cd6-de394649d1c8, 5128B599F7D401446F64D4771BE19AB2B9CD7A8B) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 Date: Sun, 8 Jan 2023 20:29:31 +0100 From: Stephen Kitt To: Sam Ravnborg via B4 Submission Endpoint Subject: Re: [PATCH 10/15] staging: fbtft: core: Introduce backlight_is_blank() Message-ID: <20230108202931.42c9ee66@heffalump.sk2.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-10-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-10-1bd9bafb351f@ravnborg.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/BJ.jj8xoOBPKImJW1n2hw0J"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Ovh-Tracer-Id: 1846757322849420934 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkeeggdduvdekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfofggtgesghdtreerredtvdenucfhrhhomhepufhtvghphhgvnhcumfhithhtuceoshhtvghvvgesshhkvddrohhrgheqnecuggftrfgrthhtvghrnhepfeffgefhgfeuueeffeejieefieefgfefffethfdtudegvdejueelhffhfeegjeeinecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutddvnecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugihpphgtqdguvghvsehlihhsthhsrdhoiihlrggsshdrohhrghdpoffvtefjohhsthepmhhoheejiedpmhhouggvpehsmhhtphhouhht X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-staging@lists.linux.dev, Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Mackerras , sam@ravnborg.org, Peter Suti , Daniel Thompson , Andy Shevchenko , Helge Deller , Lee Jones , Javier Martinez Canillas , Miguel Ojeda , Antonino Daplas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Robin van der Gracht , Nicolas Ferre , Thomas Zimmermann , Jingoo Han , linuxppc-dev@lists.ozlabs.org, Claudiu Beznea Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --Sig_/BJ.jj8xoOBPKImJW1n2hw0J Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 07 Jan 2023 19:26:24 +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg >=20 > Avoiding direct access to backlight_properties.props. >=20 > Access to the deprecated props.fb_blank replaced by backlight_is_blank(). > Access to props.power is dropped - it was only used for debug. >=20 > Signed-off-by: Sam Ravnborg > Cc: Thomas Zimmermann > Cc: Andy Shevchenko > Cc: Javier Martinez Canillas > Cc: Greg Kroah-Hartman > Cc: Sam Ravnborg > Cc: Stephen Kitt > Cc: Peter Suti > Cc: linux-fbdev@vger.kernel.org > --- > drivers/staging/fbtft/fbtft-core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/staging/fbtft/fbtft-core.c > b/drivers/staging/fbtft/fbtft-core.c index afaba94d1d1c..1746327e1939 100= 644 > --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c > @@ -132,15 +132,15 @@ static int fbtft_backlight_update_status(struct > backlight_device *bd) { > struct fbtft_par *par =3D bl_get_data(bd); > bool polarity =3D par->polarity; > + bool blank =3D backlight_is_blank(bd); > =20 > - fbtft_par_dbg(DEBUG_BACKLIGHT, par, > - "%s: polarity=3D%d, power=3D%d, fb_blank=3D%d\n", > - __func__, polarity, bd->props.power, > bd->props.fb_blank); > + fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s: polarity=3D%d, blank=3D%d\n", > + __func__, polarity, blank); > =20 > - if (!backlight_is_blank(bd)) > - gpiod_set_value(par->gpio.led[0], polarity); > - else > + if (blank) > gpiod_set_value(par->gpio.led[0], !polarity); > + else > + gpiod_set_value(par->gpio.led[0], polarity); > =20 > return 0; > } >=20 > --=20 > 2.34.1 Reviewed-by: Stephen Kitt --Sig_/BJ.jj8xoOBPKImJW1n2hw0J Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmO7GZsACgkQgNMC9Yht g5wubw/+OjnQ4CEmY5Wjdqc5kVNQk3JFua1QNs/C0p6yt+0Z+jZGg/gsNAzlKXCI Gm1o0/JkT8sJ3Th8mMKikKDs8y8SiHfHkm7gR0HRcUwdML8RHDCDr4d0yBS/xLtP 7fwQNf604rHXvP2Tlt/hZvM6r6gfGve+t9pFqwhToCARgZgEY08UEf4rfPTkBYBz vRcvriKaj9O59OBgG7QjSxKWNPyhYumnL1GRJZzbrOgu5zAk8zJUCxAy/LD3fMy6 x+rePxWXUOQQtVlW4T/jMBADrnHgwoluBNA12CnsXBm14ZXrennS6bm0f3xjaHka KkreOCwMglpI1/UaLTwqlRUQALocxWsQypP5hlG2OO4FcnDUagGhj1M5KNC4OPF8 rWi/LUWyLLs32FMZiq4Y561ev6OTCsqlgO1r8DVQAsaZVhPcn9TfiDOQp/HaCeRo DAsncfhZEk9Cm6/vsv3NijYTlHBXfgWd7AKYCiUEVFqdGqUZ+1RdFxdqcj0CM7Fp HNfcXRAcTA1b0EJrLKQK472vW38RhFzvfvWs5xnX4O/JHDxo0x9Mb4N8pUYMRcFb W2Md6wkDlESuYv8XD2cId/zmb36TyKSZQfBkuCmXxiG1zJK+phoNuUICF+a4ApRk cYG3xI2aM1ayPFQE+4njm3MuaS9/G+6XzyEn9qzeas4Kc1M1xiw= =e1F4 -----END PGP SIGNATURE----- --Sig_/BJ.jj8xoOBPKImJW1n2hw0J-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B780C54EBE for ; Sun, 8 Jan 2023 19:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=STtg07PnEAwXFc3AcTuzXxc/tZRNmbR3Ld1CEZia40k=; b=2nsJXQ1d69J6Be3cWMm9749CdH 9i+Q/yuo+NK3wmJNswbr8Yc6f2FbuyZDJZp40Y/6H4nhqrriUhFpeRkQEJ6cX2E8W2pMTcjpo6AB/ 4PyuG8Ege30nbiyqEFMHHQBhfupsvrHxHqZGqxQU48hvwb0ekmtMsnMaxSl3Csv64mpDMj90RBpXL zdTaau0n5j9hi7oTc7cWgtgfrAdTkFq1fdmKlEKjl9WGUFiD5xOSigCtQkm2IHdddjCcQCCcs1wUN xbD6s6GI/XJB9/E/DqeWT+WOleiRxdfXsUMCS0Ony4C9ZcMfAB9AjDce6iqwj4wIP8sKJ4L3pjIWx SUPHncjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEbMY-00FS3k-At; Sun, 08 Jan 2023 19:29:46 +0000 Received: from 13.mo561.mail-out.ovh.net ([188.165.33.202]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEbMT-00FS22-U7 for linux-arm-kernel@lists.infradead.org; Sun, 08 Jan 2023 19:29:44 +0000 Received: from director10.ghost.mail-out.ovh.net (unknown [10.109.146.143]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 8E2542233B for ; Sun, 8 Jan 2023 19:29:37 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-5zc6k (unknown [10.111.208.1]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 256A21FF13; Sun, 8 Jan 2023 19:29:33 +0000 (UTC) Received: from sk2.org ([37.59.142.102]) by ghost-submission-6684bf9d7b-5zc6k with ESMTPSA id NzpKBp0Zu2OoSAEAosFdow (envelope-from ); Sun, 08 Jan 2023 19:29:33 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-102R00419398439-321a-44a9-9cd6-de394649d1c8, 5128B599F7D401446F64D4771BE19AB2B9CD7A8B) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 Date: Sun, 8 Jan 2023 20:29:31 +0100 From: Stephen Kitt To: Sam Ravnborg via B4 Submission Endpoint Subject: Re: [PATCH 10/15] staging: fbtft: core: Introduce backlight_is_blank() Message-ID: <20230108202931.42c9ee66@heffalump.sk2.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-10-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-10-1bd9bafb351f@ravnborg.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Ovh-Tracer-Id: 1846757322849420934 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkeeggdduvdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfofggtgesghdtreerredtvdenucfhrhhomhepufhtvghphhgvnhcumfhithhtuceoshhtvghvvgesshhkvddrohhrgheqnecuggftrfgrthhtvghrnhepfeffgefhgfeuueeffeejieefieefgfefffethfdtudegvdejueelhffhfeegjeeinecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutddvnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdfovfetjfhoshhtpehmohehiedupdhmohguvgepshhmthhpohhuth X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230108_112942_937323_8FA44270 X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-staging@lists.linux.dev, Greg Kroah-Hartman , Benjamin Herrenschmidt , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Mackerras , sam@ravnborg.org, Peter Suti , Daniel Thompson , Andy Shevchenko , Helge Deller , Lee Jones , Javier Martinez Canillas , Miguel Ojeda , Antonino Daplas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Robin van der Gracht , Thomas Zimmermann , Jingoo Han , linuxppc-dev@lists.ozlabs.org, Claudiu Beznea Content-Type: multipart/mixed; boundary="===============1976305419660226431==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1976305419660226431== Content-Type: multipart/signed; boundary="Sig_/BJ.jj8xoOBPKImJW1n2hw0J"; protocol="application/pgp-signature"; micalg=pgp-sha512 --Sig_/BJ.jj8xoOBPKImJW1n2hw0J Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 07 Jan 2023 19:26:24 +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg >=20 > Avoiding direct access to backlight_properties.props. >=20 > Access to the deprecated props.fb_blank replaced by backlight_is_blank(). > Access to props.power is dropped - it was only used for debug. >=20 > Signed-off-by: Sam Ravnborg > Cc: Thomas Zimmermann > Cc: Andy Shevchenko > Cc: Javier Martinez Canillas > Cc: Greg Kroah-Hartman > Cc: Sam Ravnborg > Cc: Stephen Kitt > Cc: Peter Suti > Cc: linux-fbdev@vger.kernel.org > --- > drivers/staging/fbtft/fbtft-core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/staging/fbtft/fbtft-core.c > b/drivers/staging/fbtft/fbtft-core.c index afaba94d1d1c..1746327e1939 100= 644 > --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c > @@ -132,15 +132,15 @@ static int fbtft_backlight_update_status(struct > backlight_device *bd) { > struct fbtft_par *par =3D bl_get_data(bd); > bool polarity =3D par->polarity; > + bool blank =3D backlight_is_blank(bd); > =20 > - fbtft_par_dbg(DEBUG_BACKLIGHT, par, > - "%s: polarity=3D%d, power=3D%d, fb_blank=3D%d\n", > - __func__, polarity, bd->props.power, > bd->props.fb_blank); > + fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s: polarity=3D%d, blank=3D%d\n", > + __func__, polarity, blank); > =20 > - if (!backlight_is_blank(bd)) > - gpiod_set_value(par->gpio.led[0], polarity); > - else > + if (blank) > gpiod_set_value(par->gpio.led[0], !polarity); > + else > + gpiod_set_value(par->gpio.led[0], polarity); > =20 > return 0; > } >=20 > --=20 > 2.34.1 Reviewed-by: Stephen Kitt --Sig_/BJ.jj8xoOBPKImJW1n2hw0J Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmO7GZsACgkQgNMC9Yht g5wubw/+OjnQ4CEmY5Wjdqc5kVNQk3JFua1QNs/C0p6yt+0Z+jZGg/gsNAzlKXCI Gm1o0/JkT8sJ3Th8mMKikKDs8y8SiHfHkm7gR0HRcUwdML8RHDCDr4d0yBS/xLtP 7fwQNf604rHXvP2Tlt/hZvM6r6gfGve+t9pFqwhToCARgZgEY08UEf4rfPTkBYBz vRcvriKaj9O59OBgG7QjSxKWNPyhYumnL1GRJZzbrOgu5zAk8zJUCxAy/LD3fMy6 x+rePxWXUOQQtVlW4T/jMBADrnHgwoluBNA12CnsXBm14ZXrennS6bm0f3xjaHka KkreOCwMglpI1/UaLTwqlRUQALocxWsQypP5hlG2OO4FcnDUagGhj1M5KNC4OPF8 rWi/LUWyLLs32FMZiq4Y561ev6OTCsqlgO1r8DVQAsaZVhPcn9TfiDOQp/HaCeRo DAsncfhZEk9Cm6/vsv3NijYTlHBXfgWd7AKYCiUEVFqdGqUZ+1RdFxdqcj0CM7Fp HNfcXRAcTA1b0EJrLKQK472vW38RhFzvfvWs5xnX4O/JHDxo0x9Mb4N8pUYMRcFb W2Md6wkDlESuYv8XD2cId/zmb36TyKSZQfBkuCmXxiG1zJK+phoNuUICF+a4ApRk cYG3xI2aM1ayPFQE+4njm3MuaS9/G+6XzyEn9qzeas4Kc1M1xiw= =e1F4 -----END PGP SIGNATURE----- --Sig_/BJ.jj8xoOBPKImJW1n2hw0J-- --===============1976305419660226431== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1976305419660226431==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 18.mo581.mail-out.ovh.net (18.mo581.mail-out.ovh.net [188.165.56.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABBF228F9 for ; Sun, 8 Jan 2023 20:08:40 +0000 (UTC) Received: from director10.ghost.mail-out.ovh.net (unknown [10.109.143.249]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id CA75F2365A for ; Sun, 8 Jan 2023 19:29:37 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-5zc6k (unknown [10.111.208.1]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 256A21FF13; Sun, 8 Jan 2023 19:29:33 +0000 (UTC) Received: from sk2.org ([37.59.142.102]) by ghost-submission-6684bf9d7b-5zc6k with ESMTPSA id NzpKBp0Zu2OoSAEAosFdow (envelope-from ); Sun, 08 Jan 2023 19:29:33 +0000 Authentication-Results:garm.ovh; auth=pass (GARM-102R00419398439-321a-44a9-9cd6-de394649d1c8, 5128B599F7D401446F64D4771BE19AB2B9CD7A8B) smtp.auth=steve@sk2.org X-OVh-ClientIp:82.65.25.201 Date: Sun, 8 Jan 2023 20:29:31 +0100 From: Stephen Kitt To: Sam Ravnborg via B4 Submission Endpoint Cc: , Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Thomas Zimmermann , Andy Shevchenko , Javier Martinez Canillas , Peter Suti Subject: Re: [PATCH 10/15] staging: fbtft: core: Introduce backlight_is_blank() Message-ID: <20230108202931.42c9ee66@heffalump.sk2.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-10-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-10-1bd9bafb351f@ravnborg.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/BJ.jj8xoOBPKImJW1n2hw0J"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Ovh-Tracer-Id: 1846757322849420934 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkeeggdduvdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfofggtgesghdtreerredtvdenucfhrhhomhepufhtvghphhgvnhcumfhithhtuceoshhtvghvvgesshhkvddrohhrgheqnecuggftrfgrthhtvghrnhepfeffgefhgfeuueeffeejieefieefgfefffethfdtudegvdejueelhffhfeegjeeinecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutddvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqshhtrghgihhngheslhhishhtshdrlhhinhhugidruggvvhdpoffvtefjohhsthepmhhoheekuddpmhhouggvpehsmhhtphhouhht --Sig_/BJ.jj8xoOBPKImJW1n2hw0J Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 07 Jan 2023 19:26:24 +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg >=20 > Avoiding direct access to backlight_properties.props. >=20 > Access to the deprecated props.fb_blank replaced by backlight_is_blank(). > Access to props.power is dropped - it was only used for debug. >=20 > Signed-off-by: Sam Ravnborg > Cc: Thomas Zimmermann > Cc: Andy Shevchenko > Cc: Javier Martinez Canillas > Cc: Greg Kroah-Hartman > Cc: Sam Ravnborg > Cc: Stephen Kitt > Cc: Peter Suti > Cc: linux-fbdev@vger.kernel.org > --- > drivers/staging/fbtft/fbtft-core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/staging/fbtft/fbtft-core.c > b/drivers/staging/fbtft/fbtft-core.c index afaba94d1d1c..1746327e1939 100= 644 > --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c > @@ -132,15 +132,15 @@ static int fbtft_backlight_update_status(struct > backlight_device *bd) { > struct fbtft_par *par =3D bl_get_data(bd); > bool polarity =3D par->polarity; > + bool blank =3D backlight_is_blank(bd); > =20 > - fbtft_par_dbg(DEBUG_BACKLIGHT, par, > - "%s: polarity=3D%d, power=3D%d, fb_blank=3D%d\n", > - __func__, polarity, bd->props.power, > bd->props.fb_blank); > + fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s: polarity=3D%d, blank=3D%d\n", > + __func__, polarity, blank); > =20 > - if (!backlight_is_blank(bd)) > - gpiod_set_value(par->gpio.led[0], polarity); > - else > + if (blank) > gpiod_set_value(par->gpio.led[0], !polarity); > + else > + gpiod_set_value(par->gpio.led[0], polarity); > =20 > return 0; > } >=20 > --=20 > 2.34.1 Reviewed-by: Stephen Kitt --Sig_/BJ.jj8xoOBPKImJW1n2hw0J Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmO7GZsACgkQgNMC9Yht g5wubw/+OjnQ4CEmY5Wjdqc5kVNQk3JFua1QNs/C0p6yt+0Z+jZGg/gsNAzlKXCI Gm1o0/JkT8sJ3Th8mMKikKDs8y8SiHfHkm7gR0HRcUwdML8RHDCDr4d0yBS/xLtP 7fwQNf604rHXvP2Tlt/hZvM6r6gfGve+t9pFqwhToCARgZgEY08UEf4rfPTkBYBz vRcvriKaj9O59OBgG7QjSxKWNPyhYumnL1GRJZzbrOgu5zAk8zJUCxAy/LD3fMy6 x+rePxWXUOQQtVlW4T/jMBADrnHgwoluBNA12CnsXBm14ZXrennS6bm0f3xjaHka KkreOCwMglpI1/UaLTwqlRUQALocxWsQypP5hlG2OO4FcnDUagGhj1M5KNC4OPF8 rWi/LUWyLLs32FMZiq4Y561ev6OTCsqlgO1r8DVQAsaZVhPcn9TfiDOQp/HaCeRo DAsncfhZEk9Cm6/vsv3NijYTlHBXfgWd7AKYCiUEVFqdGqUZ+1RdFxdqcj0CM7Fp HNfcXRAcTA1b0EJrLKQK472vW38RhFzvfvWs5xnX4O/JHDxo0x9Mb4N8pUYMRcFb W2Md6wkDlESuYv8XD2cId/zmb36TyKSZQfBkuCmXxiG1zJK+phoNuUICF+a4ApRk cYG3xI2aM1ayPFQE+4njm3MuaS9/G+6XzyEn9qzeas4Kc1M1xiw= =e1F4 -----END PGP SIGNATURE----- --Sig_/BJ.jj8xoOBPKImJW1n2hw0J--