From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A58DC54EBE for ; Sun, 8 Jan 2023 19:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VhTM+xK+n9SxhJ/phLEL8GczSW3d5Squws1xIab3odU=; b=QZ4JtcJZCH5uoUAT7xeYOWhxxG DK1d/A0M3MhBWArK/503tRLdTzt+68FFb4fFKown1/N7a/56WNi+dKqGiBfqkyIriiGXxSUKYl/zg xm29oC/LYo4tsCklGiNFqC2eKBET2wMZndTRC1x1Rvt4fgby16ngLtwP8SnEA4OAUJKrmddksgR+q LdiDfVO98fjRHr6jFm1bcK/v8rYBlpXQ8jx8j3gpH3BvIlQrvhZdTIoKWJgOFrJ8uBUf1kxCdwkBs QGXLtxWGxK7pPO+FTOhzztskUx3STRwkPM9Y0+YBnz85WbFxEltGidT+/Yh92rVYV1kOUgAPr8FN7 sBLm+drA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEbPA-00FSad-Fo; Sun, 08 Jan 2023 19:32:28 +0000 Received: from 10.mo583.mail-out.ovh.net ([46.105.52.148]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEbP5-00FSZL-J8 for linux-arm-kernel@lists.infradead.org; Sun, 08 Jan 2023 19:32:26 +0000 Received: from director9.ghost.mail-out.ovh.net (unknown [10.108.4.132]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 685A321E01 for ; Sun, 8 Jan 2023 19:32:18 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-rxrrl (unknown [10.110.208.237]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 531A61FED5; Sun, 8 Jan 2023 19:32:17 +0000 (UTC) Received: from sk2.org ([37.59.142.102]) by ghost-submission-6684bf9d7b-rxrrl with ESMTPSA id GQDvD0Eau2MQfAAAaOw9AQ (envelope-from ); Sun, 08 Jan 2023 19:32:17 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-102R004bd0c23e1-a184-484d-af6b-234daf9726ce, 5128B599F7D401446F64D4771BE19AB2B9CD7A8B) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 Date: Sun, 8 Jan 2023 20:32:15 +0100 From: Stephen Kitt To: Sam Ravnborg via B4 Submission Endpoint Subject: Re: [PATCH 13/15] backlight: omap1: Use backlight helpers Message-ID: <20230108203215.30037a70@heffalump.sk2.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-13-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-13-1bd9bafb351f@ravnborg.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Ovh-Tracer-Id: 1892074796039898758 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkeeggdduvdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfofggtgesghdtreerredtvdenucfhrhhomhepufhtvghphhgvnhcumfhithhtuceoshhtvghvvgesshhkvddrohhrgheqnecuggftrfgrthhtvghrnhepfeffgefhgfeuueeffeejieefieefgfefffethfdtudegvdejueelhffhfeegjeeinecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutddvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdfovfetjfhoshhtpehmohehkeefpdhmohguvgepshhmthhpohhuth X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230108_113224_784355_A48BDDC5 X-CRM114-Status: GOOD ( 24.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-omap@vger.kernel.org, Antonino Daplas , Robin van der Gracht , Benjamin Herrenschmidt , Helge Deller , Lee Jones , linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Jingoo Han , Paul Mackerras , linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Miguel Ojeda , Daniel Thompson , sam@ravnborg.org, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0562765937084496825==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0562765937084496825== Content-Type: multipart/signed; boundary="Sig_/GypAq4FXG4m.CwTF5BhTXQF"; protocol="application/pgp-signature"; micalg=pgp-sha512 --Sig_/GypAq4FXG4m.CwTF5BhTXQF Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 07 Jan 2023 19:26:27 +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg >=20 > Rework backlight handling to avoid access to the deprecated > backlight_properties.fb_blank member. >=20 > The rework includes removal of get_brightness() operation, > because there was no read back from HW so no use for it. >=20 > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > --- > drivers/video/backlight/omap1_bl.c | 67 > +++++--------------------------------- 1 file changed, 9 insertions(+), 58 > deletions(-) >=20 > diff --git a/drivers/video/backlight/omap1_bl.c > b/drivers/video/backlight/omap1_bl.c index 69a49384b3de..49f37da857e7 100= 644 > --- a/drivers/video/backlight/omap1_bl.c > +++ b/drivers/video/backlight/omap1_bl.c > @@ -20,9 +20,6 @@ > #define OMAPBL_MAX_INTENSITY 0xff > =20 > struct omap_backlight { > - int powermode; > - int current_intensity; > - > struct device *dev; > struct omap_backlight_config *pdata; > }; > @@ -37,82 +34,40 @@ static inline void omapbl_send_enable(int enable) > omap_writeb(enable, OMAP_PWL_CLK_ENABLE); > } > =20 > -static void omapbl_blank(struct omap_backlight *bl, int mode) > -{ > - if (bl->pdata->set_power) > - bl->pdata->set_power(bl->dev, mode); > - > - switch (mode) { > - case FB_BLANK_NORMAL: > - case FB_BLANK_VSYNC_SUSPEND: > - case FB_BLANK_HSYNC_SUSPEND: > - case FB_BLANK_POWERDOWN: > - omapbl_send_intensity(0); > - omapbl_send_enable(0); > - break; > - > - case FB_BLANK_UNBLANK: > - omapbl_send_intensity(bl->current_intensity); > - omapbl_send_enable(1); > - break; > - } > -} > - > #ifdef CONFIG_PM_SLEEP > static int omapbl_suspend(struct device *dev) > { > struct backlight_device *bl_dev =3D dev_get_drvdata(dev); > - struct omap_backlight *bl =3D bl_get_data(bl_dev); > =20 > - omapbl_blank(bl, FB_BLANK_POWERDOWN); > + backlight_disable(bl_dev); > return 0; > } > =20 > static int omapbl_resume(struct device *dev) > { > struct backlight_device *bl_dev =3D dev_get_drvdata(dev); > - struct omap_backlight *bl =3D bl_get_data(bl_dev); > =20 > - omapbl_blank(bl, bl->powermode); > + backlight_enable(bl_dev); > return 0; > } > #endif > =20 > -static int omapbl_set_power(struct backlight_device *dev, int state) > -{ > - struct omap_backlight *bl =3D bl_get_data(dev); > - > - omapbl_blank(bl, state); > - bl->powermode =3D state; > - > - return 0; > -} > - > static int omapbl_update_status(struct backlight_device *dev) > { > - struct omap_backlight *bl =3D bl_get_data(dev); > + int brightness =3D backlight_get_brightness(dev); > =20 > - if (bl->current_intensity !=3D dev->props.brightness) { > - if (bl->powermode =3D=3D FB_BLANK_UNBLANK) > - omapbl_send_intensity(dev->props.brightness); > - bl->current_intensity =3D dev->props.brightness; > + if (brightness > 0) { > + omapbl_send_intensity(dev->props.brightness); > + omapbl_send_enable(1); > + } else { > + omapbl_send_intensity(0); > + omapbl_send_enable(0); > } > =20 > - if (dev->props.fb_blank !=3D bl->powermode) > - omapbl_set_power(dev, dev->props.fb_blank); > - > return 0; > } > =20 > -static int omapbl_get_intensity(struct backlight_device *dev) > -{ > - struct omap_backlight *bl =3D bl_get_data(dev); > - > - return bl->current_intensity; > -} > - > static const struct backlight_ops omapbl_ops =3D { > - .get_brightness =3D omapbl_get_intensity, > .update_status =3D omapbl_update_status, > }; > =20 > @@ -139,9 +94,6 @@ static int omapbl_probe(struct platform_device *pdev) > if (IS_ERR(dev)) > return PTR_ERR(dev); > =20 > - bl->powermode =3D FB_BLANK_POWERDOWN; > - bl->current_intensity =3D 0; > - > bl->pdata =3D pdata; > bl->dev =3D &pdev->dev; > =20 > @@ -149,7 +101,6 @@ static int omapbl_probe(struct platform_device *pdev) > =20 > omap_cfg_reg(PWL); /* Conflicts with UART3 */ > =20 > - dev->props.fb_blank =3D FB_BLANK_UNBLANK; > dev->props.brightness =3D pdata->default_intensity; > omapbl_update_status(dev); > =20 >=20 > --=20 > 2.34.1 Wow that gets rid of a lot of unnecessary code! Reviewed-by: Stephen Kitt --Sig_/GypAq4FXG4m.CwTF5BhTXQF Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmO7GkAACgkQgNMC9Yht g5wbPw//Ss+kTsAfHvbPabK9dJV/X66aYDEyoOZ3yDLe6E2BoTflL+WrHBw8VFNa AJvgfHwrJ1T4yIWpz0T/hzHKeO1gx0bj+VMDMJnCwGueAAZoz3rE9NXDPclWfqzb LkSkCDgIu44dDRbvFE3Sd0azg0lN35evn+zyEqbpw+QKfsv5O3S+LX9iY2rkLXcv CkEynsPcOzfQSUBMgCvrvkDK0L0Gi0OghVh5WEnYfB0RMs31qFaEd8i+maho3DKP p78tgvWNxAw62OxEvlXK66XvibuCJpwsVmDCN6pLZXQCqmIUgUa3U6PS3kINzIVp vd0Mlca7QxaPrqWINi8SQhO8O9bVhQWK5FgPP719ay6QGtyR85FhNsW5DZQHG7yd kxrvExOJDvZ0GnrAvSNGPrPXqp/rlelpeHW4dyf67t8bQkpaUIsNYVha0XrhuZv9 tFwdW5RA0Ay/uqReXzMn+qXJqcakZ0YBsRunzpSjvXC2ejg8K056tncizpvAFY6o B427h2bO5F1gZ83eXMFVNuhxk8ve2Bi4A62l2J0lJb1UZNuLy0I2YSTgvvOlHN/E GCsrQFZZc6T0ETq1STqS1b8yGFbB47xQTluCqOD5Pk91cisLsUL7uFAyI/6HnbrA gdlHJTW4bxnEHedzYUUIW40PlyoAW01YP3dvwrUSUgFvQqJQfAs= =WGiV -----END PGP SIGNATURE----- --Sig_/GypAq4FXG4m.CwTF5BhTXQF-- --===============0562765937084496825== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0562765937084496825==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10E31C54EBC for ; Sun, 8 Jan 2023 19:42:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 427F710E029; Sun, 8 Jan 2023 19:42:06 +0000 (UTC) X-Greylist: delayed 301 seconds by postgrey-1.36 at gabe; Sun, 08 Jan 2023 19:42:03 UTC Received: from 20.mo583.mail-out.ovh.net (20.mo583.mail-out.ovh.net [91.121.55.239]) by gabe.freedesktop.org (Postfix) with ESMTPS id 48C0410E029 for ; Sun, 8 Jan 2023 19:42:03 +0000 (UTC) Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.138.246]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 6424621DC0 for ; Sun, 8 Jan 2023 19:32:18 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-rxrrl (unknown [10.110.208.237]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 531A61FED5; Sun, 8 Jan 2023 19:32:17 +0000 (UTC) Received: from sk2.org ([37.59.142.102]) by ghost-submission-6684bf9d7b-rxrrl with ESMTPSA id GQDvD0Eau2MQfAAAaOw9AQ (envelope-from ); Sun, 08 Jan 2023 19:32:17 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-102R004bd0c23e1-a184-484d-af6b-234daf9726ce, 5128B599F7D401446F64D4771BE19AB2B9CD7A8B) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 Date: Sun, 8 Jan 2023 20:32:15 +0100 From: Stephen Kitt To: Sam Ravnborg via B4 Submission Endpoint Subject: Re: [PATCH 13/15] backlight: omap1: Use backlight helpers Message-ID: <20230108203215.30037a70@heffalump.sk2.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-13-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-13-1bd9bafb351f@ravnborg.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/GypAq4FXG4m.CwTF5BhTXQF"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Ovh-Tracer-Id: 1892074796039898758 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkeeggdduvdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfofggtgesghdtreerredtvdenucfhrhhomhepufhtvghphhgvnhcumfhithhtuceoshhtvghvvgesshhkvddrohhrgheqnecuggftrfgrthhtvghrnhepfeffgefhgfeuueeffeejieefieefgfefffethfdtudegvdejueelhffhfeegjeeinecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutddvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepughrihdquggvvhgvlheslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrghdpoffvtefjohhsthepmhhoheekfedpmhhouggvpehsmhhtphhouhht X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-omap@vger.kernel.org, Antonino Daplas , Robin van der Gracht , Helge Deller , Lee Jones , linux-staging@lists.linux.dev, Nicolas Ferre , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Jingoo Han , Paul Mackerras , linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Miguel Ojeda , Daniel Thompson , sam@ravnborg.org, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --Sig_/GypAq4FXG4m.CwTF5BhTXQF Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 07 Jan 2023 19:26:27 +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg >=20 > Rework backlight handling to avoid access to the deprecated > backlight_properties.fb_blank member. >=20 > The rework includes removal of get_brightness() operation, > because there was no read back from HW so no use for it. >=20 > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > --- > drivers/video/backlight/omap1_bl.c | 67 > +++++--------------------------------- 1 file changed, 9 insertions(+), 58 > deletions(-) >=20 > diff --git a/drivers/video/backlight/omap1_bl.c > b/drivers/video/backlight/omap1_bl.c index 69a49384b3de..49f37da857e7 100= 644 > --- a/drivers/video/backlight/omap1_bl.c > +++ b/drivers/video/backlight/omap1_bl.c > @@ -20,9 +20,6 @@ > #define OMAPBL_MAX_INTENSITY 0xff > =20 > struct omap_backlight { > - int powermode; > - int current_intensity; > - > struct device *dev; > struct omap_backlight_config *pdata; > }; > @@ -37,82 +34,40 @@ static inline void omapbl_send_enable(int enable) > omap_writeb(enable, OMAP_PWL_CLK_ENABLE); > } > =20 > -static void omapbl_blank(struct omap_backlight *bl, int mode) > -{ > - if (bl->pdata->set_power) > - bl->pdata->set_power(bl->dev, mode); > - > - switch (mode) { > - case FB_BLANK_NORMAL: > - case FB_BLANK_VSYNC_SUSPEND: > - case FB_BLANK_HSYNC_SUSPEND: > - case FB_BLANK_POWERDOWN: > - omapbl_send_intensity(0); > - omapbl_send_enable(0); > - break; > - > - case FB_BLANK_UNBLANK: > - omapbl_send_intensity(bl->current_intensity); > - omapbl_send_enable(1); > - break; > - } > -} > - > #ifdef CONFIG_PM_SLEEP > static int omapbl_suspend(struct device *dev) > { > struct backlight_device *bl_dev =3D dev_get_drvdata(dev); > - struct omap_backlight *bl =3D bl_get_data(bl_dev); > =20 > - omapbl_blank(bl, FB_BLANK_POWERDOWN); > + backlight_disable(bl_dev); > return 0; > } > =20 > static int omapbl_resume(struct device *dev) > { > struct backlight_device *bl_dev =3D dev_get_drvdata(dev); > - struct omap_backlight *bl =3D bl_get_data(bl_dev); > =20 > - omapbl_blank(bl, bl->powermode); > + backlight_enable(bl_dev); > return 0; > } > #endif > =20 > -static int omapbl_set_power(struct backlight_device *dev, int state) > -{ > - struct omap_backlight *bl =3D bl_get_data(dev); > - > - omapbl_blank(bl, state); > - bl->powermode =3D state; > - > - return 0; > -} > - > static int omapbl_update_status(struct backlight_device *dev) > { > - struct omap_backlight *bl =3D bl_get_data(dev); > + int brightness =3D backlight_get_brightness(dev); > =20 > - if (bl->current_intensity !=3D dev->props.brightness) { > - if (bl->powermode =3D=3D FB_BLANK_UNBLANK) > - omapbl_send_intensity(dev->props.brightness); > - bl->current_intensity =3D dev->props.brightness; > + if (brightness > 0) { > + omapbl_send_intensity(dev->props.brightness); > + omapbl_send_enable(1); > + } else { > + omapbl_send_intensity(0); > + omapbl_send_enable(0); > } > =20 > - if (dev->props.fb_blank !=3D bl->powermode) > - omapbl_set_power(dev, dev->props.fb_blank); > - > return 0; > } > =20 > -static int omapbl_get_intensity(struct backlight_device *dev) > -{ > - struct omap_backlight *bl =3D bl_get_data(dev); > - > - return bl->current_intensity; > -} > - > static const struct backlight_ops omapbl_ops =3D { > - .get_brightness =3D omapbl_get_intensity, > .update_status =3D omapbl_update_status, > }; > =20 > @@ -139,9 +94,6 @@ static int omapbl_probe(struct platform_device *pdev) > if (IS_ERR(dev)) > return PTR_ERR(dev); > =20 > - bl->powermode =3D FB_BLANK_POWERDOWN; > - bl->current_intensity =3D 0; > - > bl->pdata =3D pdata; > bl->dev =3D &pdev->dev; > =20 > @@ -149,7 +101,6 @@ static int omapbl_probe(struct platform_device *pdev) > =20 > omap_cfg_reg(PWL); /* Conflicts with UART3 */ > =20 > - dev->props.fb_blank =3D FB_BLANK_UNBLANK; > dev->props.brightness =3D pdata->default_intensity; > omapbl_update_status(dev); > =20 >=20 > --=20 > 2.34.1 Wow that gets rid of a lot of unnecessary code! Reviewed-by: Stephen Kitt --Sig_/GypAq4FXG4m.CwTF5BhTXQF Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmO7GkAACgkQgNMC9Yht g5wbPw//Ss+kTsAfHvbPabK9dJV/X66aYDEyoOZ3yDLe6E2BoTflL+WrHBw8VFNa AJvgfHwrJ1T4yIWpz0T/hzHKeO1gx0bj+VMDMJnCwGueAAZoz3rE9NXDPclWfqzb LkSkCDgIu44dDRbvFE3Sd0azg0lN35evn+zyEqbpw+QKfsv5O3S+LX9iY2rkLXcv CkEynsPcOzfQSUBMgCvrvkDK0L0Gi0OghVh5WEnYfB0RMs31qFaEd8i+maho3DKP p78tgvWNxAw62OxEvlXK66XvibuCJpwsVmDCN6pLZXQCqmIUgUa3U6PS3kINzIVp vd0Mlca7QxaPrqWINi8SQhO8O9bVhQWK5FgPP719ay6QGtyR85FhNsW5DZQHG7yd kxrvExOJDvZ0GnrAvSNGPrPXqp/rlelpeHW4dyf67t8bQkpaUIsNYVha0XrhuZv9 tFwdW5RA0Ay/uqReXzMn+qXJqcakZ0YBsRunzpSjvXC2ejg8K056tncizpvAFY6o B427h2bO5F1gZ83eXMFVNuhxk8ve2Bi4A62l2J0lJb1UZNuLy0I2YSTgvvOlHN/E GCsrQFZZc6T0ETq1STqS1b8yGFbB47xQTluCqOD5Pk91cisLsUL7uFAyI/6HnbrA gdlHJTW4bxnEHedzYUUIW40PlyoAW01YP3dvwrUSUgFvQqJQfAs= =WGiV -----END PGP SIGNATURE----- --Sig_/GypAq4FXG4m.CwTF5BhTXQF-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 18.mo561.mail-out.ovh.net (18.mo561.mail-out.ovh.net [87.98.172.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34849163 for ; Mon, 9 Jan 2023 00:19:04 +0000 (UTC) Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.156.215]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 703D724137 for ; Sun, 8 Jan 2023 19:32:18 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-rxrrl (unknown [10.110.208.237]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 531A61FED5; Sun, 8 Jan 2023 19:32:17 +0000 (UTC) Received: from sk2.org ([37.59.142.102]) by ghost-submission-6684bf9d7b-rxrrl with ESMTPSA id GQDvD0Eau2MQfAAAaOw9AQ (envelope-from ); Sun, 08 Jan 2023 19:32:17 +0000 Authentication-Results:garm.ovh; auth=pass (GARM-102R004bd0c23e1-a184-484d-af6b-234daf9726ce, 5128B599F7D401446F64D4771BE19AB2B9CD7A8B) smtp.auth=steve@sk2.org X-OVh-ClientIp:82.65.25.201 Date: Sun, 8 Jan 2023 20:32:15 +0100 From: Stephen Kitt To: Sam Ravnborg via B4 Submission Endpoint Cc: , Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 13/15] backlight: omap1: Use backlight helpers Message-ID: <20230108203215.30037a70@heffalump.sk2.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-13-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-13-1bd9bafb351f@ravnborg.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/GypAq4FXG4m.CwTF5BhTXQF"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Ovh-Tracer-Id: 1892074796039898758 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkeeggdduvdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfofggtgesghdtreerredtvdenucfhrhhomhepufhtvghphhgvnhcumfhithhtuceoshhtvghvvgesshhkvddrohhrgheqnecuggftrfgrthhtvghrnhepfeffgefhgfeuueeffeejieefieefgfefffethfdtudegvdejueelhffhfeegjeeinecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutddvnecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqshhtrghgihhngheslhhishhtshdrlhhinhhugidruggvvhdpoffvtefjohhsthepmhhoheeiuddpmhhouggvpehsmhhtphhouhht --Sig_/GypAq4FXG4m.CwTF5BhTXQF Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 07 Jan 2023 19:26:27 +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg >=20 > Rework backlight handling to avoid access to the deprecated > backlight_properties.fb_blank member. >=20 > The rework includes removal of get_brightness() operation, > because there was no read back from HW so no use for it. >=20 > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > --- > drivers/video/backlight/omap1_bl.c | 67 > +++++--------------------------------- 1 file changed, 9 insertions(+), 58 > deletions(-) >=20 > diff --git a/drivers/video/backlight/omap1_bl.c > b/drivers/video/backlight/omap1_bl.c index 69a49384b3de..49f37da857e7 100= 644 > --- a/drivers/video/backlight/omap1_bl.c > +++ b/drivers/video/backlight/omap1_bl.c > @@ -20,9 +20,6 @@ > #define OMAPBL_MAX_INTENSITY 0xff > =20 > struct omap_backlight { > - int powermode; > - int current_intensity; > - > struct device *dev; > struct omap_backlight_config *pdata; > }; > @@ -37,82 +34,40 @@ static inline void omapbl_send_enable(int enable) > omap_writeb(enable, OMAP_PWL_CLK_ENABLE); > } > =20 > -static void omapbl_blank(struct omap_backlight *bl, int mode) > -{ > - if (bl->pdata->set_power) > - bl->pdata->set_power(bl->dev, mode); > - > - switch (mode) { > - case FB_BLANK_NORMAL: > - case FB_BLANK_VSYNC_SUSPEND: > - case FB_BLANK_HSYNC_SUSPEND: > - case FB_BLANK_POWERDOWN: > - omapbl_send_intensity(0); > - omapbl_send_enable(0); > - break; > - > - case FB_BLANK_UNBLANK: > - omapbl_send_intensity(bl->current_intensity); > - omapbl_send_enable(1); > - break; > - } > -} > - > #ifdef CONFIG_PM_SLEEP > static int omapbl_suspend(struct device *dev) > { > struct backlight_device *bl_dev =3D dev_get_drvdata(dev); > - struct omap_backlight *bl =3D bl_get_data(bl_dev); > =20 > - omapbl_blank(bl, FB_BLANK_POWERDOWN); > + backlight_disable(bl_dev); > return 0; > } > =20 > static int omapbl_resume(struct device *dev) > { > struct backlight_device *bl_dev =3D dev_get_drvdata(dev); > - struct omap_backlight *bl =3D bl_get_data(bl_dev); > =20 > - omapbl_blank(bl, bl->powermode); > + backlight_enable(bl_dev); > return 0; > } > #endif > =20 > -static int omapbl_set_power(struct backlight_device *dev, int state) > -{ > - struct omap_backlight *bl =3D bl_get_data(dev); > - > - omapbl_blank(bl, state); > - bl->powermode =3D state; > - > - return 0; > -} > - > static int omapbl_update_status(struct backlight_device *dev) > { > - struct omap_backlight *bl =3D bl_get_data(dev); > + int brightness =3D backlight_get_brightness(dev); > =20 > - if (bl->current_intensity !=3D dev->props.brightness) { > - if (bl->powermode =3D=3D FB_BLANK_UNBLANK) > - omapbl_send_intensity(dev->props.brightness); > - bl->current_intensity =3D dev->props.brightness; > + if (brightness > 0) { > + omapbl_send_intensity(dev->props.brightness); > + omapbl_send_enable(1); > + } else { > + omapbl_send_intensity(0); > + omapbl_send_enable(0); > } > =20 > - if (dev->props.fb_blank !=3D bl->powermode) > - omapbl_set_power(dev, dev->props.fb_blank); > - > return 0; > } > =20 > -static int omapbl_get_intensity(struct backlight_device *dev) > -{ > - struct omap_backlight *bl =3D bl_get_data(dev); > - > - return bl->current_intensity; > -} > - > static const struct backlight_ops omapbl_ops =3D { > - .get_brightness =3D omapbl_get_intensity, > .update_status =3D omapbl_update_status, > }; > =20 > @@ -139,9 +94,6 @@ static int omapbl_probe(struct platform_device *pdev) > if (IS_ERR(dev)) > return PTR_ERR(dev); > =20 > - bl->powermode =3D FB_BLANK_POWERDOWN; > - bl->current_intensity =3D 0; > - > bl->pdata =3D pdata; > bl->dev =3D &pdev->dev; > =20 > @@ -149,7 +101,6 @@ static int omapbl_probe(struct platform_device *pdev) > =20 > omap_cfg_reg(PWL); /* Conflicts with UART3 */ > =20 > - dev->props.fb_blank =3D FB_BLANK_UNBLANK; > dev->props.brightness =3D pdata->default_intensity; > omapbl_update_status(dev); > =20 >=20 > --=20 > 2.34.1 Wow that gets rid of a lot of unnecessary code! Reviewed-by: Stephen Kitt --Sig_/GypAq4FXG4m.CwTF5BhTXQF Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmO7GkAACgkQgNMC9Yht g5wbPw//Ss+kTsAfHvbPabK9dJV/X66aYDEyoOZ3yDLe6E2BoTflL+WrHBw8VFNa AJvgfHwrJ1T4yIWpz0T/hzHKeO1gx0bj+VMDMJnCwGueAAZoz3rE9NXDPclWfqzb LkSkCDgIu44dDRbvFE3Sd0azg0lN35evn+zyEqbpw+QKfsv5O3S+LX9iY2rkLXcv CkEynsPcOzfQSUBMgCvrvkDK0L0Gi0OghVh5WEnYfB0RMs31qFaEd8i+maho3DKP p78tgvWNxAw62OxEvlXK66XvibuCJpwsVmDCN6pLZXQCqmIUgUa3U6PS3kINzIVp vd0Mlca7QxaPrqWINi8SQhO8O9bVhQWK5FgPP719ay6QGtyR85FhNsW5DZQHG7yd kxrvExOJDvZ0GnrAvSNGPrPXqp/rlelpeHW4dyf67t8bQkpaUIsNYVha0XrhuZv9 tFwdW5RA0Ay/uqReXzMn+qXJqcakZ0YBsRunzpSjvXC2ejg8K056tncizpvAFY6o B427h2bO5F1gZ83eXMFVNuhxk8ve2Bi4A62l2J0lJb1UZNuLy0I2YSTgvvOlHN/E GCsrQFZZc6T0ETq1STqS1b8yGFbB47xQTluCqOD5Pk91cisLsUL7uFAyI/6HnbrA gdlHJTW4bxnEHedzYUUIW40PlyoAW01YP3dvwrUSUgFvQqJQfAs= =WGiV -----END PGP SIGNATURE----- --Sig_/GypAq4FXG4m.CwTF5BhTXQF--