From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 064ADC54EBD for ; Sun, 8 Jan 2023 19:37:19 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NqnQk2kMrz3cdL for ; Mon, 9 Jan 2023 06:37:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sk2.org (client-ip=178.33.253.54; helo=7.mo584.mail-out.ovh.net; envelope-from=steve@sk2.org; receiver=) X-Greylist: delayed 229 seconds by postgrey-1.36 at boromir; Mon, 09 Jan 2023 06:36:47 AEDT Received: from 7.mo584.mail-out.ovh.net (7.mo584.mail-out.ovh.net [178.33.253.54]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NqnQ72SkJz2ylk for ; Mon, 9 Jan 2023 06:36:46 +1100 (AEDT) Received: from director7.ghost.mail-out.ovh.net (unknown [10.109.156.39]) by mo584.mail-out.ovh.net (Postfix) with ESMTP id 6FE8823D9B for ; Sun, 8 Jan 2023 19:36:42 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-wl7j5 (unknown [10.109.138.190]) by director7.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 18A311FED9; Sun, 8 Jan 2023 19:36:39 +0000 (UTC) Received: from sk2.org ([37.59.142.106]) by ghost-submission-6684bf9d7b-wl7j5 with ESMTPSA id Tf9QAUcbu2N19wAAid5/uw (envelope-from ); Sun, 08 Jan 2023 19:36:39 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-106R0064db9debf-ab59-4406-8e3b-2900436b4735, 5128B599F7D401446F64D4771BE19AB2B9CD7A8B) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 Date: Sun, 8 Jan 2023 20:36:37 +0100 From: Stephen Kitt To: Sam Ravnborg via B4 Submission Endpoint Subject: Re: [PATCH 11/15] powerpc: via-pmu-backlight: Introduce backlight_get_brightness() Message-ID: <20230108203637.0eb346fb@heffalump.sk2.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-11-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-11-1bd9bafb351f@ravnborg.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/uukmOXDDn4g_OXGHTWj0dxU"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Ovh-Tracer-Id: 1966384190180525702 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkeeggddufedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfofggtgesghdtreerredtvdenucfhrhhomhepufhtvghphhgvnhcumfhithhtuceoshhtvghvvgesshhkvddrohhrgheqnecuggftrfgrthhtvghrnhepfeffgefhgfeuueeffeejieefieefgfefffethfdtudegvdejueelhffhfeegjeeinecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugihpphgtqdguvghvsehlihhsthhsrdhoiihlrggsshdrohhrghdpoffvtefjohhsthepmhhoheekgedpmhhouggvpehsmhhtphhouhht X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-omap@vger.kernel.org, Antonino Daplas , Robin van der Gracht , Helge Deller , Lee Jones , linux-staging@lists.linux.dev, Nicolas Ferre , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Jingoo Han , Paul Mackerras , linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Miguel Ojeda , Daniel Thompson , sam@ravnborg.org, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --Sig_/uukmOXDDn4g_OXGHTWj0dxU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 07 Jan 2023 19:26:25 +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg >=20 > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties. >=20 > Signed-off-by: Sam Ravnborg > Cc: Benjamin Herrenschmidt > Cc: Sam Ravnborg > Cc: linuxppc-dev@lists.ozlabs.org > --- > drivers/macintosh/via-pmu-backlight.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/drivers/macintosh/via-pmu-backlight.c > b/drivers/macintosh/via-pmu-backlight.c index 2194016122d2..c2d87e7fa85b > 100644 --- a/drivers/macintosh/via-pmu-backlight.c > +++ b/drivers/macintosh/via-pmu-backlight.c > @@ -71,12 +71,7 @@ static int pmu_backlight_get_level_brightness(int leve= l) > static int __pmu_backlight_update_status(struct backlight_device *bd) > { > struct adb_request req; > - int level =3D bd->props.brightness; > - > - > - if (bd->props.power !=3D FB_BLANK_UNBLANK || > - bd->props.fb_blank !=3D FB_BLANK_UNBLANK) > - level =3D 0; > + int level =3D backlight_get_brightness(bd); > =20 > if (level > 0) { > int pmulevel =3D pmu_backlight_get_level_brightness(level); >=20 > --=20 > 2.34.1 This one is already in 6.2-rc1, it went in via powerpc/next. Regards, Stephen --Sig_/uukmOXDDn4g_OXGHTWj0dxU Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmO7G0UACgkQgNMC9Yht g5xMrQ/+PwvgQ0CHCn8HmbOrtCc6qRRFkBMOMZAVkGha3M3hYGioht4oHn4GrnMy TjIR7v3/JOkUdOLbjB/64to5DRhpRA1ViZ5+rzli6mJQi4D/vcf83SUedofbYnjy L/qOMiT/c73cpoldhKsOkvgATQSLfTQfddDthcS09XVmldfqgxqcEtSrnJ6cJ3QT eguOeI9WR/MqVNXT8y+NYlQttBWVAk0xoZQJgQcFBt5pS41b8Eql9n7A7+Zn5cxs fZLnmt9N2ul1oWFIc75dwcd803z/huqueMI/lnZ/ClSPuO2Cyvy75j9MOeWdOqBt iFQFUSATbNJS+WqXZQ2Tgxdz2f84jqDheSB3znCijKJuRZT9Z8JyncQKElbaqayB bTUIOcxFQUjQzSj01lRLrvV8R+xoZwSjJzL+DDev9FKbqXrS6lPVh2ZjGveJWvXy 5ERsDt/BScQ0LqR2e7UjXh3md0NGHBts8eQM+sLGSeHp6R8CyxP6et3GdGJrQdBF BfDGcN/PbNufCzTxuVMEEYXkNDqxTtvz/V+rNJJS9KkeEYp8rp4kQIbC00TXDIDQ ZekvV+TKZ4JkqEX+z44qRw+kI0mza8D9FUCx8mxh20WU1JVRtr1IGc8zyl8Y1wu1 0vLNwdTdxVfj8Z7NnIvcI8RxxcwZVT/XoIXauX9N3/iintzk5G8= =ImCK -----END PGP SIGNATURE----- --Sig_/uukmOXDDn4g_OXGHTWj0dxU-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54A05C54EBC for ; Sun, 8 Jan 2023 19:38:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SUroFK5rfKDygwMK1gClmNVNFsP+uSVV6q5Ek7lfQE0=; b=g1eXQ07ybOgmW3iEgwTcbnqACi Eu0KSARQCc7mg2APLC4ZaSR+Yl4GURMCm2wx20h+i8T6554zAbQEjj5TLPA/IKKOQv5FEYTRnjezJ DWDVqSJR5qdTW+hUDiPkpksWcPy5qt6BfAawVEWEW2W8/kywLm9J9jA56+qxt+TuStmbmASkGIXwg NTz1xEWhiBQeZZgYLM9i6u8udgj99iGCCpjULs/anpqvbclMHtM7iTsa7tyilxj0hqaVJNc6Z3jZG fMIS1b/XT9Ba5f/72I7Bk2nPSUK6dyxahWGubCwKvrSxvekJYWxpfSF3MCQ2fJT/AEZnAZaLHDHK6 LnCuK+wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEbTN-00FTpU-Vq; Sun, 08 Jan 2023 19:36:50 +0000 Received: from 1.mo560.mail-out.ovh.net ([46.105.63.121]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEbTK-00FTns-28 for linux-arm-kernel@lists.infradead.org; Sun, 08 Jan 2023 19:36:48 +0000 Received: from director7.ghost.mail-out.ovh.net (unknown [10.109.156.142]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 6E55421E32 for ; Sun, 8 Jan 2023 19:36:42 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-wl7j5 (unknown [10.109.138.190]) by director7.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 18A311FED9; Sun, 8 Jan 2023 19:36:39 +0000 (UTC) Received: from sk2.org ([37.59.142.106]) by ghost-submission-6684bf9d7b-wl7j5 with ESMTPSA id Tf9QAUcbu2N19wAAid5/uw (envelope-from ); Sun, 08 Jan 2023 19:36:39 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-106R0064db9debf-ab59-4406-8e3b-2900436b4735, 5128B599F7D401446F64D4771BE19AB2B9CD7A8B) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 Date: Sun, 8 Jan 2023 20:36:37 +0100 From: Stephen Kitt To: Sam Ravnborg via B4 Submission Endpoint Subject: Re: [PATCH 11/15] powerpc: via-pmu-backlight: Introduce backlight_get_brightness() Message-ID: <20230108203637.0eb346fb@heffalump.sk2.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-11-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-11-1bd9bafb351f@ravnborg.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Ovh-Tracer-Id: 1966384190180525702 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkeeggddufedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfofggtgesghdtreerredtvdenucfhrhhomhepufhtvghphhgvnhcumfhithhtuceoshhtvghvvgesshhkvddrohhrgheqnecuggftrfgrthhtvghrnhepfeffgefhgfeuueeffeejieefieefgfefffethfdtudegvdejueelhffhfeegjeeinecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdfovfetjfhoshhtpehmohehiedtpdhmohguvgepshhmthhpohhuth X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230108_113646_411132_FFF05C23 X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-omap@vger.kernel.org, Antonino Daplas , Robin van der Gracht , Benjamin Herrenschmidt , Helge Deller , Lee Jones , linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Jingoo Han , Paul Mackerras , linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Miguel Ojeda , Daniel Thompson , sam@ravnborg.org, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============6984494094432926793==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6984494094432926793== Content-Type: multipart/signed; boundary="Sig_/uukmOXDDn4g_OXGHTWj0dxU"; protocol="application/pgp-signature"; micalg=pgp-sha512 --Sig_/uukmOXDDn4g_OXGHTWj0dxU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 07 Jan 2023 19:26:25 +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg >=20 > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties. >=20 > Signed-off-by: Sam Ravnborg > Cc: Benjamin Herrenschmidt > Cc: Sam Ravnborg > Cc: linuxppc-dev@lists.ozlabs.org > --- > drivers/macintosh/via-pmu-backlight.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/drivers/macintosh/via-pmu-backlight.c > b/drivers/macintosh/via-pmu-backlight.c index 2194016122d2..c2d87e7fa85b > 100644 --- a/drivers/macintosh/via-pmu-backlight.c > +++ b/drivers/macintosh/via-pmu-backlight.c > @@ -71,12 +71,7 @@ static int pmu_backlight_get_level_brightness(int leve= l) > static int __pmu_backlight_update_status(struct backlight_device *bd) > { > struct adb_request req; > - int level =3D bd->props.brightness; > - > - > - if (bd->props.power !=3D FB_BLANK_UNBLANK || > - bd->props.fb_blank !=3D FB_BLANK_UNBLANK) > - level =3D 0; > + int level =3D backlight_get_brightness(bd); > =20 > if (level > 0) { > int pmulevel =3D pmu_backlight_get_level_brightness(level); >=20 > --=20 > 2.34.1 This one is already in 6.2-rc1, it went in via powerpc/next. Regards, Stephen --Sig_/uukmOXDDn4g_OXGHTWj0dxU Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmO7G0UACgkQgNMC9Yht g5xMrQ/+PwvgQ0CHCn8HmbOrtCc6qRRFkBMOMZAVkGha3M3hYGioht4oHn4GrnMy TjIR7v3/JOkUdOLbjB/64to5DRhpRA1ViZ5+rzli6mJQi4D/vcf83SUedofbYnjy L/qOMiT/c73cpoldhKsOkvgATQSLfTQfddDthcS09XVmldfqgxqcEtSrnJ6cJ3QT eguOeI9WR/MqVNXT8y+NYlQttBWVAk0xoZQJgQcFBt5pS41b8Eql9n7A7+Zn5cxs fZLnmt9N2ul1oWFIc75dwcd803z/huqueMI/lnZ/ClSPuO2Cyvy75j9MOeWdOqBt iFQFUSATbNJS+WqXZQ2Tgxdz2f84jqDheSB3znCijKJuRZT9Z8JyncQKElbaqayB bTUIOcxFQUjQzSj01lRLrvV8R+xoZwSjJzL+DDev9FKbqXrS6lPVh2ZjGveJWvXy 5ERsDt/BScQ0LqR2e7UjXh3md0NGHBts8eQM+sLGSeHp6R8CyxP6et3GdGJrQdBF BfDGcN/PbNufCzTxuVMEEYXkNDqxTtvz/V+rNJJS9KkeEYp8rp4kQIbC00TXDIDQ ZekvV+TKZ4JkqEX+z44qRw+kI0mza8D9FUCx8mxh20WU1JVRtr1IGc8zyl8Y1wu1 0vLNwdTdxVfj8Z7NnIvcI8RxxcwZVT/XoIXauX9N3/iintzk5G8= =ImCK -----END PGP SIGNATURE----- --Sig_/uukmOXDDn4g_OXGHTWj0dxU-- --===============6984494094432926793== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6984494094432926793==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 1.mo560.mail-out.ovh.net (1.mo560.mail-out.ovh.net [46.105.63.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6884E28F9 for ; Sun, 8 Jan 2023 19:56:21 +0000 (UTC) Received: from director7.ghost.mail-out.ovh.net (unknown [10.108.16.142]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 7796221E43 for ; Sun, 8 Jan 2023 19:36:42 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-wl7j5 (unknown [10.109.138.190]) by director7.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 18A311FED9; Sun, 8 Jan 2023 19:36:39 +0000 (UTC) Received: from sk2.org ([37.59.142.106]) by ghost-submission-6684bf9d7b-wl7j5 with ESMTPSA id Tf9QAUcbu2N19wAAid5/uw (envelope-from ); Sun, 08 Jan 2023 19:36:39 +0000 Authentication-Results:garm.ovh; auth=pass (GARM-106R0064db9debf-ab59-4406-8e3b-2900436b4735, 5128B599F7D401446F64D4771BE19AB2B9CD7A8B) smtp.auth=steve@sk2.org X-OVh-ClientIp:82.65.25.201 Date: Sun, 8 Jan 2023 20:36:37 +0100 From: Stephen Kitt To: Sam Ravnborg via B4 Submission Endpoint Cc: , Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 11/15] powerpc: via-pmu-backlight: Introduce backlight_get_brightness() Message-ID: <20230108203637.0eb346fb@heffalump.sk2.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-11-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-11-1bd9bafb351f@ravnborg.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/uukmOXDDn4g_OXGHTWj0dxU"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Ovh-Tracer-Id: 1966384190180525702 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkeeggddufedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfofggtgesghdtreerredtvdenucfhrhhomhepufhtvghphhgvnhcumfhithhtuceoshhtvghvvgesshhkvddrohhrgheqnecuggftrfgrthhtvghrnhepfeffgefhgfeuueeffeejieefieefgfefffethfdtudegvdejueelhffhfeegjeeinecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqshhtrghgihhngheslhhishhtshdrlhhinhhugidruggvvhdpoffvtefjohhsthepmhhoheeitddpmhhouggvpehsmhhtphhouhht --Sig_/uukmOXDDn4g_OXGHTWj0dxU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 07 Jan 2023 19:26:25 +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg >=20 > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties. >=20 > Signed-off-by: Sam Ravnborg > Cc: Benjamin Herrenschmidt > Cc: Sam Ravnborg > Cc: linuxppc-dev@lists.ozlabs.org > --- > drivers/macintosh/via-pmu-backlight.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/drivers/macintosh/via-pmu-backlight.c > b/drivers/macintosh/via-pmu-backlight.c index 2194016122d2..c2d87e7fa85b > 100644 --- a/drivers/macintosh/via-pmu-backlight.c > +++ b/drivers/macintosh/via-pmu-backlight.c > @@ -71,12 +71,7 @@ static int pmu_backlight_get_level_brightness(int leve= l) > static int __pmu_backlight_update_status(struct backlight_device *bd) > { > struct adb_request req; > - int level =3D bd->props.brightness; > - > - > - if (bd->props.power !=3D FB_BLANK_UNBLANK || > - bd->props.fb_blank !=3D FB_BLANK_UNBLANK) > - level =3D 0; > + int level =3D backlight_get_brightness(bd); > =20 > if (level > 0) { > int pmulevel =3D pmu_backlight_get_level_brightness(level); >=20 > --=20 > 2.34.1 This one is already in 6.2-rc1, it went in via powerpc/next. Regards, Stephen --Sig_/uukmOXDDn4g_OXGHTWj0dxU Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmO7G0UACgkQgNMC9Yht g5xMrQ/+PwvgQ0CHCn8HmbOrtCc6qRRFkBMOMZAVkGha3M3hYGioht4oHn4GrnMy TjIR7v3/JOkUdOLbjB/64to5DRhpRA1ViZ5+rzli6mJQi4D/vcf83SUedofbYnjy L/qOMiT/c73cpoldhKsOkvgATQSLfTQfddDthcS09XVmldfqgxqcEtSrnJ6cJ3QT eguOeI9WR/MqVNXT8y+NYlQttBWVAk0xoZQJgQcFBt5pS41b8Eql9n7A7+Zn5cxs fZLnmt9N2ul1oWFIc75dwcd803z/huqueMI/lnZ/ClSPuO2Cyvy75j9MOeWdOqBt iFQFUSATbNJS+WqXZQ2Tgxdz2f84jqDheSB3znCijKJuRZT9Z8JyncQKElbaqayB bTUIOcxFQUjQzSj01lRLrvV8R+xoZwSjJzL+DDev9FKbqXrS6lPVh2ZjGveJWvXy 5ERsDt/BScQ0LqR2e7UjXh3md0NGHBts8eQM+sLGSeHp6R8CyxP6et3GdGJrQdBF BfDGcN/PbNufCzTxuVMEEYXkNDqxTtvz/V+rNJJS9KkeEYp8rp4kQIbC00TXDIDQ ZekvV+TKZ4JkqEX+z44qRw+kI0mza8D9FUCx8mxh20WU1JVRtr1IGc8zyl8Y1wu1 0vLNwdTdxVfj8Z7NnIvcI8RxxcwZVT/XoIXauX9N3/iintzk5G8= =ImCK -----END PGP SIGNATURE----- --Sig_/uukmOXDDn4g_OXGHTWj0dxU--