All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juhyung Park <qkrwngud825@gmail.com>
To: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
	gregkh@linuxfoundation.org
Cc: stern@rowland.harvard.edu, zenghongling@kylinos.cn,
	zhongling0719@126.com, Juhyung Park <qkrwngud825@gmail.com>
Subject: [PATCH] Revert "usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS"
Date: Mon,  9 Jan 2023 20:55:50 +0900	[thread overview]
Message-ID: <20230109115550.71688-1-qkrwngud825@gmail.com> (raw)

This reverts commit e00b488e813f0f1ad9f778e771b7cd2fe2877023.

The commit e00b488e813f ("usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS")
blacklists UAS for the entire RTL9210 enclosures. Realtek's VendorId is 0x0bda
and RTL9210 enclosures reports 0x9210 for its ProductId.

The RTL9210 controller was advertised with UAS since its release back in 2019
and was shipped with a lot of enclosure products with different firmware
combinations.

If UAS blacklisting is really required said product (Hiksemi USB3-FW), it
should be done without blacklisting the entire RTL9210 products.

Fixes: e00b488e813f ("usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS")
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Hongling Zeng <zenghongling@kylinos.cn>
Signed-off-by: Juhyung Park <qkrwngud825@gmail.com>
---
 drivers/usb/storage/unusual_uas.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
index 251778d14e2d..c7b763d6d102 100644
--- a/drivers/usb/storage/unusual_uas.h
+++ b/drivers/usb/storage/unusual_uas.h
@@ -83,13 +83,6 @@ UNUSUAL_DEV(0x0bc2, 0x331a, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_NO_REPORT_LUNS),
 
-/* Reported-by: Hongling Zeng <zenghongling@kylinos.cn> */
-UNUSUAL_DEV(0x0bda, 0x9210, 0x0000, 0x9999,
-		"Hiksemi",
-		"External HDD",
-		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
-		US_FL_IGNORE_UAS),
-
 /* Reported-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> */
 UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999,
 		"Initio Corporation",
-- 
2.39.0


             reply	other threads:[~2023-01-09 11:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 11:55 Juhyung Park [this message]
2023-01-09 12:02 ` [PATCH] Revert "usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS" Oliver Neukum
2023-01-09 12:16   ` Juhyung Park
2023-01-09 15:48 ` Alan Stern
2023-01-10  5:24   ` Juhyung Park
     [not found] <2mw02fh6hzd-2mw3w8xfngq@nsmail7.0.0--kylin--1>
     [not found] ` <CAD14+f1p3j3WJUYshneH7A38b8JsiXjtScESB2uOQ-ZyBi57tg@mail.gmail.com>
2023-01-10  5:37   ` Juhyung Park
2023-01-17  6:16     ` Juhyung Park
2023-01-17  8:09       ` Oliver Neukum
2023-01-17  8:18         ` Juhyung Park
2023-01-17  8:34           ` Oliver Neukum
2023-01-17  9:00             ` Juhyung Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230109115550.71688-1-qkrwngud825@gmail.com \
    --to=qkrwngud825@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=usb-storage@lists.one-eyed-alien.net \
    --cc=zenghongling@kylinos.cn \
    --cc=zhongling0719@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.