From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EDD2C54EBD for ; Mon, 9 Jan 2023 14:12:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 289C8854CA; Mon, 9 Jan 2023 15:12:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="pnXEpGnh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5E908854EA; Mon, 9 Jan 2023 15:12:23 +0100 (CET) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A2C63852EF for ; Mon, 9 Jan 2023 15:12:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id c7so7817982qtw.8 for ; Mon, 09 Jan 2023 06:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=45ySE7BId1LUPVn7vFbZuWagORqYOcHUh0S8SKGhZzw=; b=pnXEpGnhXDPIf30Y67REiF2KAxsup6AtayGh/t7eN/VhudMjIjid/+8YqJoYbnzN4F 2ZtYg4c62sofZGL1l0kA5S771iTWmXyt5v7o/zo2BWfdJbUG6KhDISUGjT53r21Hs4rA GaScqPhiMM9iHvIpvAvU3LLLv1FGHIrvLpvwg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=45ySE7BId1LUPVn7vFbZuWagORqYOcHUh0S8SKGhZzw=; b=b4NdOfVCrwRz3G3FIF9tAJd2+7iaF5AHlD0/idtsGwSPFy9/12qAgH1+V7qfkI4JMO 9ZVonb11r6KzemUnd4jRSx5HsoTT5hUq8Ed4JnHqHNEsArEYhxlxpxRVlXzg8rKPr8Vi sshbetIihMXjA4+/5RbbPj6C9rpvuSKwiSLBMSwtHZWYXRaw58AUMdjpURbc40ui3X77 MPNikzxDxo/0S37s0gMlo3dTcjAX0ZuD274wq9uLIbnjYUMZqNQW5FzAZ/4wKeprQEZ3 nWuGrjx7cip7XhqENF3MfHg5+kjgzLqDBwtZLacBIsYvaHFg0Wgdyb619ZY6hvh/wjw3 1nMA== X-Gm-Message-State: AFqh2kronP+RH0pSQ6Qllb6uZqTlddhLb1iL92KoIJbU/qIKq6cRCvk6 Ih+yrXiAWk9stI0udoiecchX0Q== X-Google-Smtp-Source: AMrXdXtqToB/h7bjViMS2wcJmyWvq5h+Uj6EvZ3MEUas6Ceto0di9EwO3FdPD8AQcYOlhGmJa7c29g== X-Received: by 2002:ac8:4a10:0:b0:3ab:5e21:65be with SMTP id x16-20020ac84a10000000b003ab5e2165bemr86556405qtq.16.1673273538334; Mon, 09 Jan 2023 06:12:18 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0159-9ce3-e1a8-fcba.res6.spectrum.com. [2603:6081:7b00:6400:159:9ce3:e1a8:fcba]) by smtp.gmail.com with ESMTPSA id gb15-20020a05622a598f00b003a530a32f67sm4545787qtb.65.2023.01.09.06.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 06:12:17 -0800 (PST) Date: Mon, 9 Jan 2023 09:12:15 -0500 From: Tom Rini To: Michal Simek Cc: Simon Glass , Luca Ceresoli , U-Boot Mailing List , Roger Quadros , Alper Nebi Yasak , Peter Geis , Jerome Forissier , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , Ivan Mikhaylov , Quentin Schulz , Philippe Reynes Subject: Re: [PATCH v9 14/14] treewide: Disable USE_SPL_FIT_GENERATOR by default Message-ID: <20230109141215.GI3787616@bill-the-cat> References: <20230107210721.478062-1-sjg@chromium.org> <20230107210721.478062-15-sjg@chromium.org> <20230108134132.GY3787616@bill-the-cat> <20230108160605.GB3787616@bill-the-cat> <20230108162438.GC3787616@bill-the-cat> <128e89b7-db5b-a842-6990-19c52de9da22@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wfU9hg8y/SNaC6Y2" Content-Disposition: inline In-Reply-To: <128e89b7-db5b-a842-6990-19c52de9da22@amd.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --wfU9hg8y/SNaC6Y2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 09, 2023 at 12:07:05PM +0100, Michal Simek wrote: > Hi, >=20 > On 1/8/23 20:36, Simon Glass wrote: > > Hi Tom, > >=20 > > On Sun, 8 Jan 2023 at 09:24, Tom Rini wrote: > > >=20 > > > On Sun, Jan 08, 2023 at 09:20:09AM -0700, Simon Glass wrote: > > > > Hi Tom, > > > >=20 > > > > On Sun, 8 Jan 2023 at 09:06, Tom Rini wrote: > > > > >=20 > > > > > On Sun, Jan 08, 2023 at 08:48:37AM -0700, Simon Glass wrote: > > > > > > Hi Tom, > > > > > >=20 > > > > > > On Sun, 8 Jan 2023 at 06:41, Tom Rini wrot= e: > > > > > > >=20 > > > > > > > On Sat, Jan 07, 2023 at 02:07:21PM -0700, Simon Glass wrote: > > > > > > >=20 > > > > > > > > This option is deprecated and only used by two boards. Enab= le it for just > > > > > > > > those two boards, so others don't accidentally enable it. > > > > > > > >=20 > > > > > > > > Signed-off-by: Simon Glass > > > > > > > [snip] > > > > > > > > diff --git a/boot/Kconfig b/boot/Kconfig > > > > > > > > index 55f06761ef8..7ab0dd14211 100644 > > > > > > > > --- a/boot/Kconfig > > > > > > > > +++ b/boot/Kconfig > > > > > > > > @@ -282,12 +282,13 @@ config SPL_FIT_SOURCE > > > > > > > > config USE_SPL_FIT_GENERATOR > > > > > > > > bool "Use a script to generate the .its script" > > > > > > > > depends on SPL_FIT > > > > > > > > - default y if SPL_FIT && ARCH_ZYNQMP > > > > > > > > + help > > > > > > > > + This is deprecated. Please do not use it. Use binma= n instead. > > > > > > >=20 > > > > > > > Lets remove the text around bool so it can't be enabled, and = move to > > > > > > > select'ing it from the two boards that need it. Michal, Luca,= what's > > > > > > > needed to move your two platforms > > > > > > > (avnet_ultrazedev_cc_v1_0_ultrazedev_som_v1_0 and xilinx_zynq= mp_virt off > > > > > > > of this very legacy option, given that other xilinx platforms= have > > > > > > > already migrated to binman ? > > > > > >=20 > > > > > > That's a good idea, but these two boards do not have TARGET Kco= nfig > > > > > > options so it is not possible without adding some Kconfig speci= fic to > > > > > > those boards, then defining it in the defconfig files. > > > > > >=20 > > > > > > We already have the legacy warning. > > > > >=20 > > > > > Yes, but I swear these are new legacy users as when we started tr= ying to > > > > > kill off this option it was just a few i.MX platforms lagging beh= ind. > > > > >=20 > > > > > Maybe make ARCH_ZYNQMP select DEPRECATED, USE_SPL_FIT_GENERATOR d= epend > > > > > on DEPRECATED and add "DERECATED" to the end of the text line? O= r maybe > > > > > Michal or Luca will speak up soon and migrate these over quickly = so we > > > > > can just nuke this. > > > >=20 > > > > Isn't that just more tortuous? I can disable SPL_LOAD_FIT on these = two > > > > boards since they don't appear in CI. Then they can convert them wh= en > > > > ready. > > > >=20 > > > > That way we can drop the option now, if that is your goal. > > >=20 > > > I thought xilinx_zynqmp_virt was in CI, but I see I'm mistaken. I sti= ll > > > don't want to break platforms outright, and since it's Sunday right n= ow > > > afterall, we should let Michal and Luca a chance to catch up and chime > > > in. I hope it's either going to be a quick conversion or expose > > > something missing and needed in binman, as to why these still haven't > > > been converted. > > >=20 > >=20 > > OK let's hold off on this patch for now. It is just a clean-up anyway. >=20 > First of all. ZynqMP is not wired in CI simply because we are missing some > bits and pieces in upstream qemu to run it. If we can wire it with Xilinx > version we can do it. I have asked to fix it our qemu team but they have > never done it. Ah yes, I remember you saying that now. I guess it comes down to how hard it would be to patch that support in to 6.1.0 (or, move us up to a newer release and patch on top of that) in tools/docker/Dockerfile. We special-case the nokia_rx51 support in QEMU because it's so old, so I'd rather avoid that for another platform if we can. > In U-Boot SPL flow this script is used all the time. I use it all the time > when I build work on ZynqMP. Also buildroot is using it. >=20 > In connection to binman. I have looked at it 2/3 times in past. The bigge= st > issue which I have with it is that DT node presence in DT which goes to t= he > system. >=20 > Here is example >=20 > [u-boot](binman)$ make kontron_sl28_defconfig >/dev/null > [u-boot](binman)$ make -j8 >/dev/null > [u-boot](binman)$ dtc -I dtb -O dts dts/dt.dtb 2>/dev/null | grep binman > binman { > binman =3D "/binman"; > u_boot_rom =3D "/binman/u-boot-rom"; >=20 > where binmap is the part of target DT. >=20 > It has side effects. > 1. DT is bigger > 2. It contains information how firmware was packed which is just addition= al > information which don't need to be shared. > 3. binman node as is placed in not documented in dt binding to be able to > pass dtb check. >=20 > I can call binman externally but that would mean additional build step wh= ich > everybody wants to avoid. > Can we update Makefile and add Kconfig option to pass configuration dtb f= ile > instead of u-boot.dtb by default? >=20 > Something like: >=20 > diff --git a/Makefile b/Makefile > index 75a599b2c437..4d8d67c7d938 100644 > --- a/Makefile > +++ b/Makefile > @@ -1322,7 +1322,7 @@ cmd_binman =3D $(srctree)/tools/binman/binman $(if > $(BINMAN_DEBUG),-D) \ > $(foreach f,$(BINMAN_TOOLPATHS),--toolpath $(f)) \ > --toolpath $(objtree)/tools \ > $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \ > - build -u -d u-boot.dtb -O . -m \ > + build -u -d $(CONFIG_BINMAN_CONFIG_DTB) -O . -m \ > $(if $(BINMAN_ALLOW_MISSING),--allow-missing --ignore-mis= sing) \ > -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \ > -I arch/$(ARCH)/dts -a of-list=3D$(CONFIG_OF_LIST) \ >=20 > Then by default u-boot.dtb can be used or platforms can use different fil= e. > Then I would add zynqmp-binman.dts with configurations which can replace > existing arch/arm/mach-zynqmp/mkimage_fit_atf.sh script. > What do you think? >=20 > BTW: Is there a way to generate also capsules from binman? This is the kind of feedback I think we've been needing here, and I'll leave it to Simon to address, thanks! --=20 Tom --wfU9hg8y/SNaC6Y2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO8ILIACgkQFHw5/5Y0 tyzU8Av+LfwKrjokXXnNXzxEqQpcvlF45VFDDko91n+h5PlB8TPFCUHROAF+IBFk a4v78hcujLWGiIfZSAvMdUejPlCb0WOVPM3VnfK+aql5QIA7HFTXMiGVKO2Y6wlV 9TXMW8E/TxQM45ncKxm0kE+ZRtxbPZRj3iACHUGw5PPo7VWVp3aYtxLz3jQRl8hG KrME+yLQdevfnTq7LeLlwV6wWOT10vn/ivlvt9KNTh/LundkiTkEIESLdWGMEajl S8uwLGWqtJ2DBY1r0AM7V60d9d+YMy8LaPX2JaR5hewMj37ZFeaQGVkq77Unb/N9 yFG5vLak/EsA8KwoSwbGvmoRlEuvyyjRR9BA7RMX1lWXKx3GNukSkjzmIOTPP+ZB 72oTxSNjRY4dKHGG/Eky3fwXrKKNoaOiYk5t7bVN7hKPhhSP7KuVhUOlfDYvzBNb LRBLqYK0Tu6vCemBogqFqO6HwtowmvBw3G9JTOwa+kjJBWqeLx6qIsJEimlGZFSW aaFcIjoC =nvcC -----END PGP SIGNATURE----- --wfU9hg8y/SNaC6Y2--