From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2D1CC5479D for ; Mon, 9 Jan 2023 18:56:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 085FA83014; Mon, 9 Jan 2023 19:56:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="q5BFD2A0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C1D7582FE7; Mon, 9 Jan 2023 19:56:08 +0100 (CET) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 571AB84FB4 for ; Mon, 9 Jan 2023 19:55:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id c7so8572532qtw.8 for ; Mon, 09 Jan 2023 10:55:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IrwnuhC1ifGVKtZLjeJEvOHaAN6VWCRf/7qsuUOLMJE=; b=q5BFD2A0PR41MwA3O9+9Nx1TLJ4Z/cDvtAys3PtEgrpH172fIXrYDMDu9YrUw2Pcnn fvNhfKGwGl3fV4gD0iIjKc498M/cvnTzjdyM5rfbhNQR5oXhw9mcVy/tC0v2r3tOLbk+ MUbOk/q9b+ALpRttjCsqZbsHGk4oYtSEEOL3A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IrwnuhC1ifGVKtZLjeJEvOHaAN6VWCRf/7qsuUOLMJE=; b=ExQD9QLqiKaT+Af4lGCgIXcCyh1gc6xKUGfrxQNJUe4ZM5y6m4y7vjh0X11ReTRg1e ws7ZdIKJBAR8cu1VVoiJfIXpu5dHytLMirqzs+NYbxDZUi4AHfiuqjzXtMvel4YRjOby ipfTiSB10Wi5S0WexxNlnIN2nEuKkXc+yAdEir4qg/eIyriOb/0gCHVk07qM0IHciKZ3 9pJ3tSqCFDSYhzEPmU3bfRJ7JWfp3sOl4S7RCw+ykDIAym78bKta3IAzYHloreRDqJoL l/K8W7mA1j7ub8uSZrsRqGOABLdn0tdnCMcpQakxm2XkMZbjKuFAIJ8DQavuM7JpHORR mCLw== X-Gm-Message-State: AFqh2kp+z4pm6i8BFxS7hVlHB4FR8ZIfD5X16mHflzH4JT3bzAeLV0Vr tvSi0LQeQHM5bn1NgyC6eLgmadPan/gumkZ3z4E= X-Google-Smtp-Source: AMrXdXtwqNrVbwhBmt6x+JSSUvE/X+a9Ss5KhvcINpKbVhb0tir3wPub/eWB2urWJkCaQa2jMZKkXA== X-Received: by 2002:a05:622a:4184:b0:3a8:9d1:4b5e with SMTP id cd4-20020a05622a418400b003a809d14b5emr90621458qtb.53.1673290558082; Mon, 09 Jan 2023 10:55:58 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0159-9ce3-e1a8-fcba.res6.spectrum.com. [2603:6081:7b00:6400:159:9ce3:e1a8:fcba]) by smtp.gmail.com with ESMTPSA id k2-20020a05620a414200b006faaf6dc55asm5873757qko.22.2023.01.09.10.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 10:55:57 -0800 (PST) Date: Mon, 9 Jan 2023 13:55:55 -0500 From: Tom Rini To: Simon Glass Cc: Michal Simek , Luca Ceresoli , U-Boot Mailing List , Roger Quadros , Alper Nebi Yasak , Peter Geis , Jerome Forissier , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , Ivan Mikhaylov , Quentin Schulz , Philippe Reynes Subject: Re: [PATCH v9 14/14] treewide: Disable USE_SPL_FIT_GENERATOR by default Message-ID: <20230109185555.GC3787616@bill-the-cat> References: <20230107210721.478062-1-sjg@chromium.org> <20230107210721.478062-15-sjg@chromium.org> <20230108134132.GY3787616@bill-the-cat> <20230108160605.GB3787616@bill-the-cat> <20230108162438.GC3787616@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ExsmtmdSHjgdryD0" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --ExsmtmdSHjgdryD0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 08, 2023 at 12:36:15PM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Sun, 8 Jan 2023 at 09:24, Tom Rini wrote: > > > > On Sun, Jan 08, 2023 at 09:20:09AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Sun, 8 Jan 2023 at 09:06, Tom Rini wrote: > > > > > > > > On Sun, Jan 08, 2023 at 08:48:37AM -0700, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Sun, 8 Jan 2023 at 06:41, Tom Rini wrote: > > > > > > > > > > > > On Sat, Jan 07, 2023 at 02:07:21PM -0700, Simon Glass wrote: > > > > > > > > > > > > > This option is deprecated and only used by two boards. Enable= it for just > > > > > > > those two boards, so others don't accidentally enable it. > > > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > [snip] > > > > > > > diff --git a/boot/Kconfig b/boot/Kconfig > > > > > > > index 55f06761ef8..7ab0dd14211 100644 > > > > > > > --- a/boot/Kconfig > > > > > > > +++ b/boot/Kconfig > > > > > > > @@ -282,12 +282,13 @@ config SPL_FIT_SOURCE > > > > > > > config USE_SPL_FIT_GENERATOR > > > > > > > bool "Use a script to generate the .its script" > > > > > > > depends on SPL_FIT > > > > > > > - default y if SPL_FIT && ARCH_ZYNQMP > > > > > > > + help > > > > > > > + This is deprecated. Please do not use it. Use binman = instead. > > > > > > > > > > > > Lets remove the text around bool so it can't be enabled, and mo= ve to > > > > > > select'ing it from the two boards that need it. Michal, Luca, w= hat's > > > > > > needed to move your two platforms > > > > > > (avnet_ultrazedev_cc_v1_0_ultrazedev_som_v1_0 and xilinx_zynqmp= _virt off > > > > > > of this very legacy option, given that other xilinx platforms h= ave > > > > > > already migrated to binman ? > > > > > > > > > > That's a good idea, but these two boards do not have TARGET Kconf= ig > > > > > options so it is not possible without adding some Kconfig specifi= c to > > > > > those boards, then defining it in the defconfig files. > > > > > > > > > > We already have the legacy warning. > > > > > > > > Yes, but I swear these are new legacy users as when we started tryi= ng to > > > > kill off this option it was just a few i.MX platforms lagging behin= d. > > > > > > > > Maybe make ARCH_ZYNQMP select DEPRECATED, USE_SPL_FIT_GENERATOR dep= end > > > > on DEPRECATED and add "DERECATED" to the end of the text line? Or = maybe > > > > Michal or Luca will speak up soon and migrate these over quickly so= we > > > > can just nuke this. > > > > > > Isn't that just more tortuous? I can disable SPL_LOAD_FIT on these two > > > boards since they don't appear in CI. Then they can convert them when > > > ready. > > > > > > That way we can drop the option now, if that is your goal. > > > > I thought xilinx_zynqmp_virt was in CI, but I see I'm mistaken. I still > > don't want to break platforms outright, and since it's Sunday right now > > afterall, we should let Michal and Luca a chance to catch up and chime > > in. I hope it's either going to be a quick conversion or expose > > something missing and needed in binman, as to why these still haven't > > been converted. > > >=20 > OK let's hold off on this patch for now. It is just a clean-up anyway. In light of the feedback, for this series, lets just make the generator option depend on ARCH_ZYNQMP as well and leave it default y. This should prevent any new users from showing up while the feedback Michal has provided gets addressed and leave this series with one less blocker at least. --=20 Tom --ExsmtmdSHjgdryD0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO8YzoACgkQFHw5/5Y0 tywVsQwAtByAjmCVmjG4MX1uIAiwY64bD28GpcrfdBG0GTHeuD04mr05VyxC5kHy S+3N7RngPkafpUjnVvr9bnflhETZ5S9CTdZ/CdWv+r6iCsiJu2aYY6PzAnX75/jN LSisbWoUlhqPSWvjvjy3FkZnmIPPw8ccht4aTuGFV7Tt6dclmSHX5ixmSHKgNP4d FhKGBX/pm80jZu3aQ+iejTckloyp60uyDzQaxoLFbxr/NasGSVOWdIVY7fduoM59 xe1n5xN/31pUYz4HTj3MGxMOpWJQIg5UTJzz5alxGiGNpPIjWtXZLf84sMQ7R83M YNlAi4Vbh8VNk+vVC9SjMoVvD2sKUqw62uuFOOosWpODxKrUzm4IpbUxmaChBn10 N3zpWsUD6Xd17ThNn0Tj6V+MDFsSOgvDgCd9h7PbR4xiKBH0qZFVBgi2CBNBYwtx kZnJ519sm3qm+MhjP+9eCIeS8B3D+pM2A89tIPhvw8qLdQfZcTpA5Br0sI9vGMVo EU95ncFr =GNxP -----END PGP SIGNATURE----- --ExsmtmdSHjgdryD0--