All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Vivek Kasireddy <vivek.kasireddy@intel.com>
Cc: Dongwon Kim <dongwon.kim@intel.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1 1/2] drm/virtio: Attach and set suggested_x/y properties for the connector
Date: Tue, 10 Jan 2023 10:33:14 +0100	[thread overview]
Message-ID: <20230110093314.d3zbz4k2oxypz5sm@sirius.home.kraxel.org> (raw)
In-Reply-To: <20221118013054.182304-2-vivek.kasireddy@intel.com>

  Hi,

> +static void virtio_gpu_update_output_position(struct virtio_gpu_output *output)
> +{
> +	struct drm_connector *connector = &output->conn;
> +	struct drm_device *dev = connector->dev;
> +
> +	drm_object_property_set_value(&connector->base,
> +		dev->mode_config.suggested_x_property, output->info.r.x);
> +	drm_object_property_set_value(&connector->base,
> +		dev->mode_config.suggested_y_property, output->info.r.y);
> +}

This fails sparse checking

sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/virtio/virtgpu_vq.c:654:70: sparse: sparse: incorrect type in argument 3 (different base types) @@     expected unsigned long long [usertype] val @@     got restricted __le32 [usertype] x @@
   drivers/gpu/drm/virtio/virtgpu_vq.c:654:70: sparse:     expected unsigned long long [usertype] val
   drivers/gpu/drm/virtio/virtgpu_vq.c:654:70: sparse:     got restricted __le32 [usertype] x
>> drivers/gpu/drm/virtio/virtgpu_vq.c:656:70: sparse: sparse: incorrect type in argument 3 (different base types) @@     expected unsigned long long [usertype] val @@     got restricted __le32 [usertype] y @@
   drivers/gpu/drm/virtio/virtgpu_vq.c:656:70: sparse:     expected unsigned long long [usertype] val
   drivers/gpu/drm/virtio/virtgpu_vq.c:656:70: sparse:     got restricted __le32 [usertype] y

take care,
  Gerd


  reply	other threads:[~2023-01-10  9:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18  1:30 [PATCH v1 0/2] drm/virtio: Add hotplug_mode_update and suggested_x/y properties Vivek Kasireddy
2022-11-18  1:30 ` [PATCH v1 1/2] drm/virtio: Attach and set suggested_x/y properties for the connector Vivek Kasireddy
2023-01-10  9:33   ` Gerd Hoffmann [this message]
2022-11-18  1:30 ` [PATCH v1 2/2] drm/virtio: Add the hotplug_mode_update property for rescanning of modes Vivek Kasireddy
2023-01-06  8:56   ` Gerd Hoffmann
2023-01-06  9:35     ` Daniel Vetter
2023-01-10  1:58       ` Kasireddy, Vivek
2023-01-11 22:12         ` Daniel Vetter
2023-01-12  7:17           ` Gerd Hoffmann
2023-01-12  9:17             ` Daniel Vetter
2023-01-10  9:28       ` Gerd Hoffmann
2023-01-11 22:08         ` Daniel Vetter
2023-01-10  1:42     ` Kasireddy, Vivek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230110093314.d3zbz4k2oxypz5sm@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=dongwon.kim@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=vivek.kasireddy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.