From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA36C749A for ; Thu, 12 Jan 2023 14:07:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECE26C433D2; Thu, 12 Jan 2023 14:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673532457; bh=tux6KU2OyUFp7H2CsRUMqzPGvjFm91D5gvGxVMxjcu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cvbLCuUrniv/MGc/zpBBpfBITZjE4Xyug2zAofmFQiKah8cwPe+fzLspc5DcGV2Hi nNf+06Aj/tbylj4ZMTqJijJ2l2L8YKNTlOO60hWiAcCXaek6N0eAjF1x/Hd5y0A2q8 d7zKIuar3NvrA+vNqZTAxnwsbn4AvTXlYhj+uMXo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wang ShaoBo , Mark Brown , Sasha Levin Subject: [PATCH 5.10 167/783] regulator: core: use kfree_const() to free space conditionally Date: Thu, 12 Jan 2023 14:48:03 +0100 Message-Id: <20230112135532.059578554@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230112135524.143670746@linuxfoundation.org> References: <20230112135524.143670746@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Wang ShaoBo [ Upstream commit dc8d006d15b623c1d80b90b45d6dcb6e890dad09 ] Use kfree_const() to free supply_name conditionally in create_regulator() as supply_name may be allocated from kmalloc() or directly from .rodata section. Fixes: 87fe29b61f95 ("regulator: push allocations in create_regulator() outside of lock") Signed-off-by: Wang ShaoBo Link: https://lore.kernel.org/r/20221123034616.3609537-1-bobo.shaobowang@huawei.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 876afa3919c1..60c0be2ea5c5 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1645,7 +1645,7 @@ static struct regulator *create_regulator(struct regulator_dev *rdev, regulator = kzalloc(sizeof(*regulator), GFP_KERNEL); if (regulator == NULL) { - kfree(supply_name); + kfree_const(supply_name); return NULL; } -- 2.35.1