From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC555749A for ; Thu, 12 Jan 2023 14:10:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52299C433D2; Thu, 12 Jan 2023 14:10:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673532613; bh=TjTx/Aw6QLentYJOM35GIxSm5jJH7XCLPS+eNsKlrgA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XzdnEV86OmR+c1GfaBn7lTA6z5szdXZc6qqXWC35Tmyrfoa+RpnpoDIPlOsnkxcav Ryxfejdi5JfT0bg6Qfeo+GYDFe7NPIC5YSj9cZJosULaY/4rZP3WWwIZbvc4jtX56c YVS9U4zAC0mFmFtkqTlYzVbHXauAAzjzwTAJVR5w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhang Xiaoxu , Trond Myklebust , Sasha Levin Subject: [PATCH 5.10 220/783] xprtrdma: Fix regbuf data not freed in rpcrdma_req_create() Date: Thu, 12 Jan 2023 14:48:56 +0100 Message-Id: <20230112135534.553761825@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230112135524.143670746@linuxfoundation.org> References: <20230112135524.143670746@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Zhang Xiaoxu [ Upstream commit 9181f40fb2952fd59ecb75e7158620c9c669eee3 ] If rdma receive buffer allocate failed, should call rpcrdma_regbuf_free() to free the send buffer, otherwise, the buffer data will be leaked. Fixes: bb93a1ae2bf4 ("xprtrdma: Allocate req's regbufs at xprt create time") Signed-off-by: Zhang Xiaoxu Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- net/sunrpc/xprtrdma/verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index dcc1992b14d7..338b06de86d1 100644 --- a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -866,7 +866,7 @@ struct rpcrdma_req *rpcrdma_req_create(struct rpcrdma_xprt *r_xprt, size_t size, return req; out3: - kfree(req->rl_sendbuf); + rpcrdma_regbuf_free(req->rl_sendbuf); out2: kfree(req); out1: -- 2.35.1