From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 13 Jan 2023 11:28:43 +0100 From: Stefano Garzarella Subject: Re: [virtio-comment] [PATCH v4 11/20] virtio-vsock: Maintain socket device spec in separate directory Message-ID: <20230113102843.xktfs6l3rsqo7p3p@sgarzare-redhat> References: <20230112212254.763783-1-parav@nvidia.com> <20230112212254.763783-12-parav@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20230112212254.763783-12-parav@nvidia.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline To: Parav Pandit Cc: mst@redhat.com, virtio-dev@lists.oasis-open.org, cohuck@redhat.com, virtio-comment@lists.oasis-open.org, david@redhat.com List-ID: On Thu, Jan 12, 2023 at 11:22:45PM +0200, Parav Pandit wrote: >Place device specification, its driver and device >conformance into its own directory to have self contained device >specification. > >Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 >Signed-off-by: Parav Pandit >--- >changelog: >v3->v4: >- rename device-types/virtio-vsock to device-types/vsock >v2->v3: >- file name changed from device.tex to description.tex >- use input instead of import to insert a file >v0->v1: >- new patch >--- > conformance.tex | 23 ++----------------- > content.tex | 2 +- > .../vsock/description.tex | 0 > device-types/vsock/device-conformance.tex | 9 ++++++++ > device-types/vsock/driver-conformance.tex | 10 ++++++++ > 5 files changed, 22 insertions(+), 22 deletions(-) > rename virtio-vsock.tex => device-types/vsock/description.tex (100%) > create mode 100644 device-types/vsock/device-conformance.tex > create mode 100644 device-types/vsock/driver-conformance.tex LGTM: Reviewed-by: Stefano Garzarella > >diff --git a/conformance.tex b/conformance.tex >index 970ef12..527949c 100644 >--- a/conformance.tex >+++ b/conformance.tex >@@ -142,17 +142,7 @@ \section{Conformance Targets}\label{sec:Conformance / Conformance Targets} > \input{device-types/scsi/driver-conformance.tex} > \input{device-types/input/driver-conformance.tex} > \input{device-types/crypto/driver-conformance.tex} >- >-\conformance{\subsection}{Socket Driver Conformance}\label{sec:Conformance / Driver Conformance / Socket Driver Conformance} >- >-A socket driver MUST conform to the following normative statements: >- >-\begin{itemize} >-\item \ref{drivernormative:Device Types / Socket Device / Feature bits} >-\item \ref{drivernormative:Device Types / Socket Device / Device Operation / Buffer Space Management} >-\item \ref{drivernormative:Device Types / Socket Device / Device Operation / Receive and Transmit} >-\item \ref{drivernormative:Device Types / Socket Device / Device Operation / Device Events} >-\end{itemize} >+\input{device-types/vsock/driver-conformance.tex} > > \conformance{\subsection}{File System Driver Conformance}\label{sec:Conformance / Driver Conformance / File System Driver Conformance} > >@@ -328,16 +318,7 @@ \section{Conformance Targets}\label{sec:Conformance / Conformance Targets} > \input{device-types/gpu/device-conformance.tex} > \input{device-types/input/device-conformance.tex} > \input{device-types/crypto/device-conformance.tex} >- >-\conformance{\subsection}{Socket Device Conformance}\label{sec:Conformance / Device Conformance / Socket Device Conformance} >- >-A socket device MUST conform to the following normative statements: >- >-\begin{itemize} >-\item \ref{devicenormative:Device Types / Socket Device / Feature bits} >-\item \ref{devicenormative:Device Types / Socket Device / Device Operation / Buffer Space Management} >-\item \ref{devicenormative:Device Types / Socket Device / Device Operation / Receive and Transmit} >-\end{itemize} >+\input{device-types/vsock/device-conformance.tex} > > \conformance{\subsection}{File System Device Conformance}\label{sec:Conformance / Device Conformance / File System Device Conformance} > >diff --git a/content.tex b/content.tex >index 2ee50d3..a154822 100644 >--- a/content.tex >+++ b/content.tex >@@ -3012,7 +3012,7 @@ \chapter{Device Types}\label{sec:Device Types} > \input{device-types/gpu/description.tex} > \input{device-types/input/description.tex} > \input{device-types/crypto/description.tex} >-\input{virtio-vsock.tex} >+\input{device-types/vsock/description.tex} > \input{virtio-fs.tex} > \input{virtio-rpmb.tex} > \input{virtio-iommu.tex} >diff --git a/virtio-vsock.tex b/device-types/vsock/description.tex >similarity index 100% >rename from virtio-vsock.tex >rename to device-types/vsock/description.tex >diff --git a/device-types/vsock/device-conformance.tex b/device-types/vsock/device-conformance.tex >new file mode 100644 >index 0000000..93b0c4d >--- /dev/null >+++ b/device-types/vsock/device-conformance.tex >@@ -0,0 +1,9 @@ >+\conformance{\subsection}{Socket Device Conformance}\label{sec:Conformance / Device Conformance / Socket Device Conformance} >+ >+A socket device MUST conform to the following normative statements: >+ >+\begin{itemize} >+\item \ref{devicenormative:Device Types / Socket Device / Feature bits} >+\item \ref{devicenormative:Device Types / Socket Device / Device Operation / Buffer Space Management} >+\item \ref{devicenormative:Device Types / Socket Device / Device Operation / Receive and Transmit} >+\end{itemize} >diff --git a/device-types/vsock/driver-conformance.tex b/device-types/vsock/driver-conformance.tex >new file mode 100644 >index 0000000..988b0c3 >--- /dev/null >+++ b/device-types/vsock/driver-conformance.tex >@@ -0,0 +1,10 @@ >+\conformance{\subsection}{Socket Driver Conformance}\label{sec:Conformance / Driver Conformance / Socket Driver Conformance} >+ >+A socket driver MUST conform to the following normative statements: >+ >+\begin{itemize} >+\item \ref{drivernormative:Device Types / Socket Device / Feature bits} >+\item \ref{drivernormative:Device Types / Socket Device / Device Operation / Buffer Space Management} >+\item \ref{drivernormative:Device Types / Socket Device / Device Operation / Receive and Transmit} >+\item \ref{drivernormative:Device Types / Socket Device / Device Operation / Device Events} >+\end{itemize} >-- >2.26.2 > > >This publicly archived list offers a means to provide input to the >OASIS Virtual I/O Device (VIRTIO) TC. > >In order to verify user consent to the Feedback License terms and >to minimize spam in the list archive, subscription is required >before posting. > >Subscribe: virtio-comment-subscribe@lists.oasis-open.org >Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org >List help: virtio-comment-help@lists.oasis-open.org >List archive: https://lists.oasis-open.org/archives/virtio-comment/ >Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf >List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists >Committee: https://www.oasis-open.org/committees/virtio/ >Join OASIS: https://www.oasis-open.org/join/ >