From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE76C6379F for ; Fri, 13 Jan 2023 20:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbjAMUL3 (ORCPT ); Fri, 13 Jan 2023 15:11:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbjAMUL0 (ORCPT ); Fri, 13 Jan 2023 15:11:26 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E064088A30 for ; Fri, 13 Jan 2023 12:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673640640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rED86BZTa2+y92QALSBGJH4WIbHXICXT8jHSNDAfqm8=; b=ejhwm8Kw1VCOXYyuioadR75EQJM6R+cYMah5srPDAkJETEsF4kmvXumuFlV6TrPrUXokM9 wrNRd0o6EOzOsPNVT/9bYrVvu69/Ws3eLBLYLk75hdCzNQwLHa1Pa/S3ZtOaMzOGLN2LB2 v3zGMDMBI3Yn78nCv4P3CIdUfhM8S7I= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-554-xOFbJ6QvN1qetV4Woi1Qcg-1; Fri, 13 Jan 2023 15:10:39 -0500 X-MC-Unique: xOFbJ6QvN1qetV4Woi1Qcg-1 Received: by mail-pg1-f200.google.com with SMTP id 84-20020a630257000000b00477f88d334eso10199847pgc.11 for ; Fri, 13 Jan 2023 12:10:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rED86BZTa2+y92QALSBGJH4WIbHXICXT8jHSNDAfqm8=; b=cicgSWVW36RwodRdlbgIXuNF11/Y2JUnyyZniAmQzY0YOSwjhrLtH61EXAx2r9++9g if6TDm+TlmXPwOUyo5DV8lBLX5s5hunCSZi93Nvn27YkEgEaP9jq8pJTuAdEj41PawnZ wHpnMPepQoTEMB5BBkkKOloOr2aioPBFLEZvEEKWIvwWgKo0vj+U3AkVe7jwZ5R3TG+w vDJ4eWSron50Xe3K4ErVx7zFPQibMeaE4o6KBW9onmmbvXzt2ncB7Oyl8nNVDNdUR0pL gNTXQBmkF/jO2SNE8bJUCH0lRnxvAATHCEvFkhIXUMtgUH8k8vNrfkqPTFE6Ri5lAW5R /XDQ== X-Gm-Message-State: AFqh2kq2ne8zg84CK1+fajcjgH9ZfgMDqvjQ/y+FhvbZEjXHNvf0xWuf w0xk0cANiMhGpwqTpmsEbBV5EK4gDgOdbvZhWQiOr4AnI5fmNEcGmU80JkXMpw/faXhdWwBIqoA scyawyEBxfyC+6su+yA== X-Received: by 2002:a17:90a:bb03:b0:225:a226:9fbb with SMTP id u3-20020a17090abb0300b00225a2269fbbmr80587601pjr.39.1673640637900; Fri, 13 Jan 2023 12:10:37 -0800 (PST) X-Google-Smtp-Source: AMrXdXvM38vHUcZYBj0DdseVmrXZUaSEI6IFXSkhYkERPDYaF5PRjPd3yuHTwEfk82n337WALECtBQ== X-Received: by 2002:a17:90a:bb03:b0:225:a226:9fbb with SMTP id u3-20020a17090abb0300b00225a2269fbbmr80587587pjr.39.1673640637621; Fri, 13 Jan 2023 12:10:37 -0800 (PST) Received: from zlang-mailbox ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id y4-20020a17090ad0c400b00218fb3bec27sm12944531pjw.56.2023.01.13.12.10.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 12:10:37 -0800 (PST) Date: Sat, 14 Jan 2023 04:10:33 +0800 From: Zorro Lang To: "Darrick J. Wong" Cc: xfs , fstests Subject: Re: [NYE DELUGE 1/4] xfs: all pending online scrub improvements Message-ID: <20230113201033.h2otptldp232pz3p@zlang-mailbox> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Fri, Dec 30, 2022 at 01:13:21PM -0800, Darrick J. Wong wrote: > Hi everyone, > > As I've mentioned several times throughout 2022, I would like to merge > the online fsck feature in time for the 2023 LTS kernel. The first big > step in this process is to merge all the pending bug fixes, validation > improvements, and general reorganization of the existing metadata > scrubbing functionality. > > This first deluge starts with the design document for the entirety of > the online fsck feature. The design doc should be familiar to most of > you, as it's been on the list for review for months already. It > outlines in brief the problems we're trying to solve, the use cases and > testing plan, and the fundamental data structures and algorithms > underlying the entire feature. > > After that come all the code changes to wrap up the metadata checking > part of the feature. The biggest piece here is the scrub drains that > allow scrub to quiesce deferred ops targeting AGs so that it can > cross-reference recordsets. Most of the rest is tweaking the btree code > so that we can do keyspace scans to look for conflicting records. > > For this review, I would like people to focus the following: > > - Are the major subsystems sufficiently documented that you could figure > out what the code does? > > - Do you see any problems that are severe enough to cause long term > support hassles? (e.g. bad API design, writing weird metadata to disk) > > - Can you spot mis-interactions between the subsystems? > > - What were my blind spots in devising this feature? > > - Are there missing pieces that you'd like to help build? > > - Can I just merge all of this? > > The one thing that is /not/ in scope for this review are requests for > more refactoring of existing subsystems. While there are usually valid > arguments for performing such cleanups, those are separate tasks to be > prioritized separately. I will get to them after merging online fsck. > > I've been running daily online scrubs of every computer I own for the > last five years, which has helped me iron out real problems in (limited > scope) production. All issues observed in that time have been corrected > in this submission. The 3 fstests patchsets of the [NYE DELUGE 1/4] look good to me. And I didn't find more critical issues after Darrick fixed that "group name missing" problem. By testing it a whole week, I decide to merge this 3 patchsets this weekend, then we can shift to later patchsets are waiting for review and merge. Reviewed-by: Zorro Lang Thanks, Zorro > > As a warning, the patches will likely take several days to trickle in. > All four patch deluges are based off kernel 6.2-rc1, xfsprogs 6.1, and > fstests 2022-12-25. > > Thank you all for your participation in the XFS community. Have a safe > New Years, and I'll see you all next year! > > --D >