From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC013C677F1 for ; Sat, 14 Jan 2023 20:03:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 50D6B85203; Sat, 14 Jan 2023 21:03:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="W5AjZJ/N"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 35E9E85084; Sat, 14 Jan 2023 21:03:48 +0100 (CET) Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B825885084 for ; Sat, 14 Jan 2023 21:03:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vk1-xa2f.google.com with SMTP id b81so11684856vkf.1 for ; Sat, 14 Jan 2023 12:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dj4OqymJoUZVOK6oQeH3smuv/tXGS3tqVEemY3/92aE=; b=W5AjZJ/NBBP+r7LLlU4gKA/pZkjvBhnBhvSSY+q3EOlcQpqj/vigh02ZuPNdIGBAdF 2xyOaNVg8AxXIKynemeu0OH/ZrvYU8p/8vrOw3ckkoyDxodM+hrf/brkpnMApNV5XEaz D1RfbKA5j3iqk/za0zz2YHgt8WABXPuZoysMs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dj4OqymJoUZVOK6oQeH3smuv/tXGS3tqVEemY3/92aE=; b=BD0DGUR6soZ5CQxIlWQLeUaTRuvtNz8GU1WcZe3Ml1w96dSZJCQiHJUF6L96k0ffHW yO+kSoa6hsuJq5hRsQ+ve5Ne2mwMmIddWtv3pip+qN2VjnDXg9NkfvbQq4tB4zyDFXoC p2kBxINlEsnbr37tzrY2f/b/qeUyuYuzeqH9fsmkcClI/L9cB0j+a1XpvQtWfHM3rbV6 1NU7C1fVUA169M+THLUXWnGVAzG2RU7IHkJWDysfdWBdQa5EtqEWfmIlyW1xZplLgaGw u4f9zhxErj2HD5r/w1cDrjQmyfwVeul8iB2ipkSsCVBVvH47SUhMzqAspIIn21KhSGXU 8yiw== X-Gm-Message-State: AFqh2kpjLeYlifWfS07PgCiC2v1iBWlA51rNjHLb+VUWpuPu8EHnaluJ vnNEdD1uWaYiDb0G+tqBvI6+Ug== X-Google-Smtp-Source: AMrXdXsvjnWETrEhb4EieI8z4jG3pkFU2hK553JA6IKuyOOfm21S7SZsgKogy4VDd4KEN2t54/hhqA== X-Received: by 2002:a1f:28c9:0:b0:3d1:ca4:ddeb with SMTP id o192-20020a1f28c9000000b003d10ca4ddebmr42441240vko.6.1673726624468; Sat, 14 Jan 2023 12:03:44 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-b9fb-5a96-85b2-3cfc.res6.spectrum.com. [2603:6081:7b00:6400:b9fb:5a96:85b2:3cfc]) by smtp.gmail.com with ESMTPSA id br31-20020a05620a461f00b006fa2cc1b0fbsm14908476qkb.11.2023.01.14.12.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Jan 2023 12:03:44 -0800 (PST) Date: Sat, 14 Jan 2023 15:03:41 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Tony Dinh , U-Boot Mailing List , Stefan Roese , Marek =?utf-8?B?QmVo77+9bg==?= , Chris Packham , Michael Trimarchi , Mark Kettenis , Simon Glass , Jaehoon Chung , Marek =?iso-8859-1?B?QmVow7pu?= Subject: Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository Message-ID: <20230114200341.GH3880571@bill-the-cat> References: <20230114003856.9208-1-mibodhi@gmail.com> <20230114014132.mtv5r7kbdl4z4zsf@pali> <20230114020021.GA3880571@bill-the-cat> <20230114185100.kco3bcgka3zg256z@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jRdC2OsRnuV8iIl8" Content-Disposition: inline In-Reply-To: <20230114185100.kco3bcgka3zg256z@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --jRdC2OsRnuV8iIl8 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 14, 2023 at 07:51:00PM +0100, Pali Roh=E1r wrote: > On Friday 13 January 2023 21:00:21 Tom Rini wrote: > > On Sat, Jan 14, 2023 at 02:41:32AM +0100, Pali Roh=E1r wrote: > > > On Friday 13 January 2023 16:38:55 Tony Dinh wrote: > > > > @@ -16,4 +19,9 @@ obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr_build_message= =2Eo > > > > obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr_common.o > > > > obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr_spd.o > > > > obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr_topology.o > > > > +obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr4_mpr_pda_if.o > > > > +obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr4_training.o > > > > +obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr4_training_calibration.o > > > > +obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr4_training_db.o > > > > +obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr4_training_leveling.o > > > > obj-$(CONFIG_SPL_BUILD) +=3D xor.o > > >=20 > > > And all these new files are ddr4 specific, so should be wrapped in ma= kefile section: > > > ifdef CONFIG_DDR4 > >=20 > > Looking at the Makefile in question, I think we might want to make the > > whole thing ifdef CONFIG_SPL_BUILD ... endif and then more finely > > control building of what objects are built. Perhaps: > > drivers/Makefile:obj-$(CONFIG_ARMADA_38X) +=3D ddr/marvell/a38x/ > > should only be for SPL instead, even? >=20 > Some cleanup like this can be done. But it is related to DDR4 support > and is mostly independent of it. So lets do it after having DDR4 there. We're going to also want to not build the DDR3 code on the DDR4 platforms, right? A little clean up would make adding the DDR4 code a bit cleaner for both cases. It's not a hard no, if someone really wants to do the clean-up after. --=20 Tom --jRdC2OsRnuV8iIl8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPDCpMACgkQFHw5/5Y0 tyyT2wv/WGWrplAB0uz1YodoC5Kjw0enKkQ0YdApiW96+a0ViDm7refGiAKnLYgy rTVQjlMv46M5dK//ncKY1M7H28eq4YHFfHRfTBdOtupZq3HXmOnLWMeEClmBNVfo 7hKvs7ZKyIkmB265uo1ZFjEplJzL5ra5qhQbcYA7gY0XvE1H/6h47Nm8FyAQSgHH RTV8Ospf6dZKqEAHuhE7+FWBBvv6TZCjPGGJT7GJPSwV9Zvgm0rhUCTY4Of66p5r 9nPv85dYMIqBwodAdPx3IS7UHQgqVmhGIJKMXV00UU2e4aYlkkmYcdb03OGxm/TV Ievuh6cU8komDr01QnJev0WLJykpMu82numyo2Nx5hEfFjPNf2aJskwqkzMdBYNO YLlnh2Gtat7KPcwMdYsx0wwbnWycljKXDUL7/kO0rVmCH6X541dGpnnIKF5focca T7xsOAMQoQ3a7IsBAMe8yI/m3Ir22rBABbmrfWHnndfpUHPSFlYzzO6/JeRdfyvS TGOxtrCH =BIGR -----END PGP SIGNATURE----- --jRdC2OsRnuV8iIl8--