All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krishna Kurapati <quic_kriskura@quicinc.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"Andy Gross" <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Felipe Balbi <balbi@kernel.org>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<quic_pkondeti@quicinc.com>, <quic_ppratap@quicinc.com>,
	<quic_wcheng@quicinc.com>, <quic_jackp@quicinc.com>,
	<quic_harshq@quicinc.com>,
	Krishna Kurapati <quic_kriskura@quicinc.com>
Subject: [RFC v4 3/5] usb: dwc3: core: Do not setup event buffers for host only controllers
Date: Sun, 15 Jan 2023 17:11:44 +0530	[thread overview]
Message-ID: <20230115114146.12628-4-quic_kriskura@quicinc.com> (raw)
In-Reply-To: <20230115114146.12628-1-quic_kriskura@quicinc.com>

Multiport controllers being host-only capable do not have GEVNTADDR
HI/LO, SIZE, COUNT reigsters present. Accsesing them to setup event
buffers during core_init can cause an SMMU Fault. Avoid event buffers
setup if the GHWPARAMS0 tells that the controller is host-only.

Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
---
 drivers/usb/dwc3/core.c | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 7e0a9a598dfd..f61ebddaecc0 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -871,9 +871,12 @@ static void dwc3_clk_disable(struct dwc3 *dwc)
 
 static void dwc3_core_exit(struct dwc3 *dwc)
 {
-	int i;
+	int		i;
+	unsigned int	hw_mode;
 
-	dwc3_event_buffers_cleanup(dwc);
+	hw_mode = DWC3_GHWPARAMS0_MODE(dwc->hwparams.hwparams0);
+	if (hw_mode != DWC3_GHWPARAMS0_MODE_HOST)
+		dwc3_event_buffers_cleanup(dwc);
 
 	usb_phy_set_suspend(dwc->usb2_phy, 1);
 	usb_phy_set_suspend(dwc->usb3_phy, 1);
@@ -1246,10 +1249,12 @@ static int dwc3_core_init(struct dwc3 *dwc)
 		}
 	}
 
-	ret = dwc3_event_buffers_setup(dwc);
-	if (ret) {
-		dev_err(dwc->dev, "failed to setup event buffers\n");
-		goto err4;
+	if (hw_mode != DWC3_GHWPARAMS0_MODE_HOST) {
+		ret = dwc3_event_buffers_setup(dwc);
+		if (ret) {
+			dev_err(dwc->dev, "failed to setup event buffers\n");
+			goto err4;
+		}
 	}
 
 	/*
@@ -1886,7 +1891,7 @@ static int dwc3_probe(struct platform_device *pdev)
 	struct resource		*res, dwc_res;
 	struct dwc3		*dwc;
 	int			ret, i;
-
+	unsigned int		hw_mode;
 	void __iomem		*regs;
 
 	dwc = devm_kzalloc(dev, sizeof(*dwc), GFP_KERNEL);
@@ -2063,7 +2068,9 @@ static int dwc3_probe(struct platform_device *pdev)
 err5:
 	dwc3_debugfs_exit(dwc);
 
-	dwc3_event_buffers_cleanup(dwc);
+	hw_mode = DWC3_GHWPARAMS0_MODE(dwc->hwparams.hwparams0);
+	if (hw_mode != DWC3_GHWPARAMS0_MODE_HOST)
+		dwc3_event_buffers_cleanup(dwc);
 
 	usb_phy_set_suspend(dwc->usb2_phy, 1);
 	usb_phy_set_suspend(dwc->usb3_phy, 1);
-- 
2.39.0


  parent reply	other threads:[~2023-01-15 11:42 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-15 11:41 [RFC v4 0/5] Add multiport support for DWC3 controllers Krishna Kurapati
2023-01-15 11:41 ` [RFC v4 1/5] dt-bindings: usb: Add bindings to support multiport properties Krishna Kurapati
2023-01-15 15:11   ` Rob Herring
2023-01-16 16:34   ` Rob Herring
2023-01-17  9:01     ` Krishna Kurapati PSSNV
2023-01-17 11:02       ` Krzysztof Kozlowski
2023-01-17 14:01         ` Krishna Kurapati PSSNV
2023-01-18 18:20   ` Bjorn Andersson
2023-01-15 11:41 ` [RFC v4 2/5] usb: dwc3: core: Refactor PHY logic to support Multiport Controller Krishna Kurapati
2023-01-19  0:36   ` Thinh Nguyen
2023-01-19  3:01     ` Krishna Kurapati PSSNV
2023-01-20  1:02       ` Thinh Nguyen
2023-01-20  1:46         ` Krishna Kurapati PSSNV
2023-01-20 22:44           ` Thinh Nguyen
2023-01-21  2:09             ` Krishna Kurapati PSSNV
2023-01-25 10:07             ` Krishna Kurapati PSSNV
2023-01-25 19:08               ` Thinh Nguyen
2023-01-25 20:49                 ` Jack Pham
2023-01-25 22:27                   ` Thinh Nguyen
2023-01-20 22:57     ` Thinh Nguyen
2023-01-21  2:06       ` Krishna Kurapati PSSNV
2023-01-21  2:19         ` Thinh Nguyen
2023-01-21  2:24           ` Krishna Kurapati PSSNV
2023-01-21  2:55             ` Thinh Nguyen
2023-01-19 22:09   ` Andrew Halaney
2023-01-20  1:55     ` Krishna Kurapati PSSNV
2023-01-20 14:37       ` Andrew Halaney
2023-01-20 15:13         ` Krishna Kurapati PSSNV
2023-01-20 15:18           ` Krishna Kurapati PSSNV
2023-01-24  8:21             ` Shazad Hussain
2023-01-15 11:41 ` Krishna Kurapati [this message]
2023-01-19  0:38   ` [RFC v4 3/5] usb: dwc3: core: Do not setup event buffers for host only controllers Thinh Nguyen
2023-01-19  1:57     ` Jack Pham
2023-01-19  2:32       ` Thinh Nguyen
2023-01-15 11:41 ` [RFC v4 4/5] usb: dwc3: qcom: Add multiport controller support for qcom wrapper Krishna Kurapati
2023-01-15 11:41 ` [RFC v4 5/5] arm: dts: msm: Add multiport controller node for usb Krishna Kurapati
2023-01-18 18:28   ` Bjorn Andersson
2023-01-18 18:31     ` Krishna Kurapati PSSNV
2023-01-19  3:43 ` [RFC v4 0/5] Add multiport support for DWC3 controllers Bjorn Andersson
2023-01-19  5:17   ` Krishna Kurapati PSSNV

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230115114146.12628-4-quic_kriskura@quicinc.com \
    --to=quic_kriskura@quicinc.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=quic_harshq@quicinc.com \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_pkondeti@quicinc.com \
    --cc=quic_ppratap@quicinc.com \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.