From: Doug Brown <doug@schmorgal.com>
To: Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Dan Williams <dcbw@redhat.com>,
Simon Horman <simon.horman@corigine.com>,
libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, Doug Brown <doug@schmorgal.com>
Subject: [PATCH v3 0/4] wifi: libertas: IE handling fixes
Date: Mon, 16 Jan 2023 12:21:22 -0800 [thread overview]
Message-ID: <20230116202126.50400-1-doug@schmorgal.com> (raw)
This series implements two fixes for the libertas driver that restore
compatibility with modern wpa_supplicant versions, and adds (or at least
improves) support for WPS in the process.
1) Better handling of the RSN/WPA IE in association requests:
The previous logic was always just grabbing the first one, and didn't
handle multiple IEs properly, which wpa_supplicant adds nowadays.
2) Support for IEs in scan requests:
Modern wpa_supplicant always adds an "extended capabilities" IE,
which violates max_scan_ie_len in this driver. Go ahead and allow
scan IEs, and handle WPS based on the info that Dan provided.
These changes have been tested on a Marvell PXA168-based device with a
Marvell 88W8686 Wi-Fi chipset. I've confirmed that with these changes
applied, modern wpa_supplicant versions connect properly and WPS also
works correctly (tested with "wpa_cli -i wlan0 wps_pbc any").
Changes since V2:
- Add missing cpu_to_le16 as suggested by Simon Horman
Changes since V1 (which was a single patch linked here [1]):
- Switch to cfg80211_find_*_elem when looking for specific IEs,
resulting in cleaner/safer code.
- Use mrvl_ie_data struct for cleaner manipulation of TLV buffer, and
fix capitalization of the "data" member to avoid checkpatch warnings.
- Implement idea suggested by Dan to change max_scan_ie_len to be
nonzero and enable WPS support in probe requests while we're at it.
- Remove "Fixes:" tag; I'm not sure if it's still appropriate or not
with it depending on the capitalization fix.
- Clarify comments.
[1] https://lore.kernel.org/all/20230102234714.169831-1-doug@schmorgal.com/
Doug Brown (4):
wifi: libertas: fix capitalization in mrvl_ie_data struct
wifi: libertas: only add RSN/WPA IE in lbs_add_wpa_tlv
wifi: libertas: add new TLV type for WPS enrollee IE
wifi: libertas: add support for WPS enrollee IE in probe requests
drivers/net/wireless/marvell/libertas/cfg.c | 76 +++++++++++++++----
drivers/net/wireless/marvell/libertas/types.h | 3 +-
2 files changed, 65 insertions(+), 14 deletions(-)
--
2.34.1
next reply other threads:[~2023-01-16 20:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 20:21 Doug Brown [this message]
2023-01-16 20:21 ` [PATCH v3 1/4] wifi: libertas: fix capitalization in mrvl_ie_data struct Doug Brown
2023-01-17 3:39 ` Ping-Ke Shih
2023-01-17 6:37 ` Doug Brown
2023-01-16 20:21 ` [PATCH v3 2/4] wifi: libertas: only add RSN/WPA IE in lbs_add_wpa_tlv Doug Brown
2023-01-17 8:59 ` Simon Horman
2023-01-18 6:35 ` Doug Brown
2023-01-18 9:14 ` Simon Horman
2023-01-16 20:21 ` [PATCH v3 3/4] wifi: libertas: add new TLV type for WPS enrollee IE Doug Brown
2023-01-16 20:21 ` [PATCH v3 4/4] wifi: libertas: add support for WPS enrollee IE in probe requests Doug Brown
2023-01-17 19:05 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116202126.50400-1-doug@schmorgal.com \
--to=doug@schmorgal.com \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.