From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
"Subbaraman Narayanamurthy" <quic_subbaram@quicinc.com>,
Johan Hovold <johan@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH v2 0/4] soc: qcom: Introduce PMIC GLINK
Date: Mon, 16 Jan 2023 18:13:43 -0800 [thread overview]
Message-ID: <20230117021343.GA2350793@hu-bjorande-lv.qualcomm.com> (raw)
In-Reply-To: <bcf497a7-66bb-9cd9-bada-4081000747a6@linaro.org>
On Fri, Jan 13, 2023 at 03:56:59PM +0100, Konrad Dybcio wrote:
>
>
> On 13.01.2023 05:11, Bjorn Andersson wrote:
> > This implements the base PMIC GLINK driver, a power_supply driver and a
> > driver for the USB Type-C altmode protocol. This has been tested and
> > shown to provide battery information, USB Type-C switch and mux requests
> > and DisplayPort notifications on SC8180X, SC8280XP and SM8350.
> >
> For the series:
>
> Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> # SM8350 PDX215
>
> Thanks a lot for working on this!
>
Thank you for testing it :)
> One thing, /sys/class/power_supply/qcom-battmgr-usb/input_current_limit
> is stuck at zero and so is the current_now as a result (the voltage
> readout is 5V + some noise, so that looks good), but I don't see any
> SET paths for it in the driver, so I suppose that's what the firmware
> default is?
>
I have not experimented with adjusting any configuration in this initial
set, but there are a few knobs that could/should be introduced on top of
this.
That said, I believe input_current_limit should somehow come from the
USB stack, rather than user space?
Regards,
Bjorn
next prev parent reply other threads:[~2023-01-17 2:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 4:11 [PATCH v2 0/4] soc: qcom: Introduce PMIC GLINK Bjorn Andersson
2023-01-13 4:11 ` [PATCH v2 1/4] dt-bindings: soc: qcom: Introduce PMIC GLINK binding Bjorn Andersson
2023-01-17 18:00 ` Rob Herring
2023-01-18 18:12 ` Bjorn Andersson
2023-01-13 4:11 ` [PATCH v2 2/4] soc: qcom: pmic_glink: Introduce base PMIC GLINK driver Bjorn Andersson
2023-01-13 4:11 ` [PATCH v2 3/4] soc: qcom: pmic_glink: Introduce altmode support Bjorn Andersson
2023-01-15 19:10 ` Steev Klimaszewski
2023-01-17 2:08 ` Bjorn Andersson
2023-01-20 10:06 ` Neil Armstrong
2023-01-20 10:33 ` Neil Armstrong
2023-01-13 4:11 ` [PATCH v2 4/4] power: supply: Introduce Qualcomm PMIC GLINK power supply Bjorn Andersson
2023-01-13 14:56 ` [PATCH v2 0/4] soc: qcom: Introduce PMIC GLINK Konrad Dybcio
2023-01-17 2:13 ` Bjorn Andersson [this message]
2023-01-13 17:10 ` Bryan O'Donoghue
2023-01-17 2:32 ` Bjorn Andersson
2023-01-17 2:37 ` Bryan O'Donoghue
2023-01-17 2:58 ` Bjorn Andersson
2023-01-17 9:26 ` Dmitry Baryshkov
2023-01-17 15:48 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117021343.GA2350793@hu-bjorande-lv.qualcomm.com \
--to=quic_bjorande@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.