From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFCBC46467 for ; Thu, 19 Jan 2023 18:14:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbjASSOz (ORCPT ); Thu, 19 Jan 2023 13:14:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbjASSOw (ORCPT ); Thu, 19 Jan 2023 13:14:52 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5CB89014 for ; Thu, 19 Jan 2023 10:14:50 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 76AA061D12 for ; Thu, 19 Jan 2023 18:14:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BECEFC433D2; Thu, 19 Jan 2023 18:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674152089; bh=+Uxtzpe7VHpQ7mR6Wx+g+3c+IPli4Rq4BJ29Aw5G0/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PJL0h7cIH/638KpbEtQDe+u9eQZYm4ToJu1EygzO9239GlRdqcl9o0i+zQmO71/hs rhqvJGS4WgTFjCFWZ1aoZNDE/GKKkO+jaXUbOxjlHlhoANKmRTa1g9O5Wv0J4sfffJ kKxI2K8ECvnd2jxeYXw5zQ5nMa0xYF6ortXEIY9tRfBoxoNyASeH5qO7f/kOtbZHq+ hMYIRyfCStb/7DKwhOuGWLy6sPxa9M8Tk2JHVNjxYNDFnysxA3SdaxQwBKM/H0n1Qh 3wT7mMTdseIt0pl3CR6rozeLCo2Vjugyki8s4hMDWxOcJJc38k3MH5djlJCpql+tNT lX1TMLvuifKRg== Date: Thu, 19 Jan 2023 18:14:44 +0000 From: Will Deacon To: Geoff Blake , robin.murphy@arm.com Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf/arm-cmn: Add shutdown routine Message-ID: <20230119181444.GA20563@willie-the-truck> References: <2bb86e97-6cef-700e-70ed-4f303da10fd9@amazon.com> <20221215180039.18035-1-blakgeof@amazon.com> <7071a073-08f5-104b-f10f-e1013d1b5390@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2023 at 11:10:29AM -0600, Geoff Blake wrote: > On Thu, 19 Jan 2023, Robin Murphy wrote: > > > If you have a convincing argument that returning IRQ_NONE for unexpected > > spurious interrupts is a real and important concern, then please propose > > a general solution, because if it matters for arm-cmn then it matters > > for hundreds of other drivers too, by rough estimate: > > > > $ git grep -l IRQ_NONE '*.c' | xargs git grep -L IRQF_SHARED | wc -l > > 834 > > The general solution for IRQ_NONE exists in the layer above the > driver, it complains with a visible warning that something might be wrong > and then moves on. Nothing more is needed. > > Your shutdown routine that flips DT_EN in CMN_DT_DTC_CTL is sufficient, as > after some testing it solves the problem with left over IRQs for my kexec > use case. Please can you two let me know when you've settled on a fix for this? I'm not going to queue something that you don't both agree on, although it seems like we're quibbling over details at this point so maybe let's get _something_ in and then work to improve it later? Cheers, Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0136C004D4 for ; Thu, 19 Jan 2023 18:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hx7c+Fmk4V/Qq/kXzSJSxe5K6okXIi05ulQD5gzC5EY=; b=bPovQbXfH11x7U 87OqPEM1cmkXcrtqMDRJDCz/Wc10y1GjMiW46vmAVPk7mKNzwLOsIaWHlGPOKsnQXIfqmjvGzvI/2 nQCukMQNKm6gz+2ys2nq2/XeVa8yjCsqUh/DQrI7bub75VHjEWaTpMhwDCbQ/M+RKTig4nxvowDeX 9vYRdNiUR8QBKzNmRqPR2f+JMljSNtfDI+eJR+Aq1dZ/bf7zlQHC/qV8YaEct2LY6+rXiSrbI5aBc hGOi1PPedM5A0TxnbRXaptyB6q9/++UvrUfeMWkYTkIfEIkSlz0/iRkSXydwDMia3FGb/18qjQTNP rw3mkdMV0t4g6hczaeEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIZR9-006VM5-EM; Thu, 19 Jan 2023 18:14:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIZR5-006VKo-1A for linux-arm-kernel@lists.infradead.org; Thu, 19 Jan 2023 18:14:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E63F61D11; Thu, 19 Jan 2023 18:14:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BECEFC433D2; Thu, 19 Jan 2023 18:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674152089; bh=+Uxtzpe7VHpQ7mR6Wx+g+3c+IPli4Rq4BJ29Aw5G0/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PJL0h7cIH/638KpbEtQDe+u9eQZYm4ToJu1EygzO9239GlRdqcl9o0i+zQmO71/hs rhqvJGS4WgTFjCFWZ1aoZNDE/GKKkO+jaXUbOxjlHlhoANKmRTa1g9O5Wv0J4sfffJ kKxI2K8ECvnd2jxeYXw5zQ5nMa0xYF6ortXEIY9tRfBoxoNyASeH5qO7f/kOtbZHq+ hMYIRyfCStb/7DKwhOuGWLy6sPxa9M8Tk2JHVNjxYNDFnysxA3SdaxQwBKM/H0n1Qh 3wT7mMTdseIt0pl3CR6rozeLCo2Vjugyki8s4hMDWxOcJJc38k3MH5djlJCpql+tNT lX1TMLvuifKRg== Date: Thu, 19 Jan 2023 18:14:44 +0000 From: Will Deacon To: Geoff Blake , robin.murphy@arm.com Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf/arm-cmn: Add shutdown routine Message-ID: <20230119181444.GA20563@willie-the-truck> References: <2bb86e97-6cef-700e-70ed-4f303da10fd9@amazon.com> <20221215180039.18035-1-blakgeof@amazon.com> <7071a073-08f5-104b-f10f-e1013d1b5390@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_101451_796199_C6356359 X-CRM114-Status: GOOD ( 18.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 19, 2023 at 11:10:29AM -0600, Geoff Blake wrote: > On Thu, 19 Jan 2023, Robin Murphy wrote: > > > If you have a convincing argument that returning IRQ_NONE for unexpected > > spurious interrupts is a real and important concern, then please propose > > a general solution, because if it matters for arm-cmn then it matters > > for hundreds of other drivers too, by rough estimate: > > > > $ git grep -l IRQ_NONE '*.c' | xargs git grep -L IRQF_SHARED | wc -l > > 834 > > The general solution for IRQ_NONE exists in the layer above the > driver, it complains with a visible warning that something might be wrong > and then moves on. Nothing more is needed. > > Your shutdown routine that flips DT_EN in CMN_DT_DTC_CTL is sufficient, as > after some testing it solves the problem with left over IRQs for my kexec > use case. Please can you two let me know when you've settled on a fix for this? I'm not going to queue something that you don't both agree on, although it seems like we're quibbling over details at this point so maybe let's get _something_ in and then work to improve it later? Cheers, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel