From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 274C87E for ; Sun, 22 Jan 2023 15:10:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2231C433EF; Sun, 22 Jan 2023 15:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674400256; bh=Ov9cBE1pApk3yYAqYpXjCylu+T+6JR64kK9M4DwDi5k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q3EUFy+zuYQ9H8nIpxww63ZmpafMAA/q6HvY4hd0HlA7Fyj4HcST+2qgtr/N76xFM Kh90Y5/mol3131B0KtdlL/75zKhUUHOFGXz7blBsiQCLygBk1wQdOR2z87Aku9dH3/ J8u3z/FKssmGUJCLS0trdMaCtQEOg2Nuy98fCKI0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Harry Wentland , Rodrigo Siqueira , hongao , Alex Deucher Subject: [PATCH 5.4 48/55] drm/amd/display: Fix set scaling doesns work Date: Sun, 22 Jan 2023 16:04:35 +0100 Message-Id: <20230122150224.168370571@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230122150222.210885219@linuxfoundation.org> References: <20230122150222.210885219@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: hongao commit 040625ab82ce6dca7772cb3867fe5c9eb279a344 upstream. [Why] Setting scaling does not correctly update CRTC state. As a result dc stream state's src (composition area) && dest (addressable area) was not calculated as expected. This causes set scaling doesn's work. [How] Correctly update CRTC state when setting scaling property. Reviewed-by: Harry Wentland Tested-by: Rodrigo Siqueira Signed-off-by: hongao Signed-off-by: Rodrigo Siqueira Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -7409,8 +7409,8 @@ static int amdgpu_dm_atomic_check(struct goto fail; } - if (dm_old_con_state->abm_level != - dm_new_con_state->abm_level) + if (dm_old_con_state->abm_level != dm_new_con_state->abm_level || + dm_old_con_state->scaling != dm_new_con_state->scaling) new_crtc_state->connectors_changed = true; }