From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 956AFC05027 for ; Mon, 23 Jan 2023 10:29:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJu4u-0000so-9s; Mon, 23 Jan 2023 05:29:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJu4m-0000sD-8P for qemu-devel@nongnu.org; Mon, 23 Jan 2023 05:29:20 -0500 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJu4j-0001ML-GV for qemu-devel@nongnu.org; Mon, 23 Jan 2023 05:29:20 -0500 Received: by mail-ej1-x634.google.com with SMTP id vw16so29142639ejc.12 for ; Mon, 23 Jan 2023 02:29:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b0oXK1SdRy74tLtiMX3fYKJ2HnHYK6rsSmwH4fzUscU=; b=ahfiun4Tijo6PquHjRJjf6KlQrrIdB8XKm69mCw5oJvxKuzeGShObomjrnu4KngRlw 8pVznH9uGVp+xab01oRTOiVBN0voMbxJ31Pt1IeZ6aPaW30FqUcMnHbW97DEpJfrgh5C g5Xpe3307g0ExkRIRPsSDAinCbne9l5xew/GkCPy4fHeBLD2gkM5siOfWFTQdQvcqkz2 qnt7VsWbqpiYCk/xLPLk0KXIHvUoSLbJZP5KVphH8AY97U+p8C3wY5waAc6olyvMPNcp Kv+F3CmfnOjfYpIxgZeAEFAmYub3zmsN6P2jAXT5xUs+F9fQqgqmdqWrqGJQcCopp3DY e8IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b0oXK1SdRy74tLtiMX3fYKJ2HnHYK6rsSmwH4fzUscU=; b=8CGsDZLi3nzh9G2vu8rVdKKSiYROYjSew4Y4Wz+eMRJLzdkOKGuy1UZdoHltkWCp4K rN/KyhwbfQUQuyzcbbmzEPmUjSQZ+rU9y/K7Oc5AQRuVUSYJmvbZ2O3Nq3SxiyCfZCv/ WFy949uMRcZ7cJVlMbrjjbNYPGrJ3c2+tqJwCFmXz7OuSt/saOKVz7JDgJkVmiiWq/f2 GxDkT0PEYECIDWdtCEnVlJtWGNSv3bA9f6489AuSoj+ByiOtvz6Un81W4mumXYu7PTDd C3uPMd1ErpLW3jEaWNJRc3hQESPYwCiaDDHxMONZ3kGaHGHE0U9shi7HL/v/tDl0ZG12 7NqA== X-Gm-Message-State: AFqh2kpUwSrJEKy4oIe2uTOc9QOjDglhYAYJynBfGy6r7U/ZWLkWuykt bcHEdYG1FcGgXEC/mqRyqTB6YQ== X-Google-Smtp-Source: AMrXdXsJVlJ6kY47pB1tE2A7cm4P8SwWyJPuWSvJnu8u4XKLHbAvyMOxrg6Yy8ofddTFs4JqqGS2Aw== X-Received: by 2002:a17:907:2a07:b0:86f:4a4e:4853 with SMTP id fd7-20020a1709072a0700b0086f4a4e4853mr22048541ejc.49.1674469754206; Mon, 23 Jan 2023 02:29:14 -0800 (PST) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id ti3-20020a170907c20300b0087190b46ab0sm10616325ejc.76.2023.01.23.02.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 02:29:13 -0800 (PST) Date: Mon, 23 Jan 2023 11:29:12 +0100 From: Andrew Jones To: Alexandre Ghiti Cc: Palmer Dabbelt , Alistair Francis , Bin Meng , Frank Chang , qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Ludovic Henry Subject: Re: [PATCH v6 3/5] riscv: Allow user to set the satp mode Message-ID: <20230123102912.kq5c47nzeg7ufkma@orel> References: <20230123090324.732681-1-alexghiti@rivosinc.com> <20230123090324.732681-4-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123090324.732681-4-alexghiti@rivosinc.com> Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=ajones@ventanamicro.com; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Jan 23, 2023 at 10:03:22AM +0100, Alexandre Ghiti wrote: ... > +/* Sets the satp mode to the max supported */ > +static void set_satp_mode_default(RISCVCPU *cpu, bool is_32_bit) > +{ nit: When passing in the cpu object pointer there's no need to also pass is_32_bit, we can just use it from the pointer, cpu->env.misa_mxl == MXL_RV32 Thanks, drew