From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C116C54E94 for ; Mon, 23 Jan 2023 12:50:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231503AbjAWMuZ (ORCPT ); Mon, 23 Jan 2023 07:50:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231437AbjAWMuY (ORCPT ); Mon, 23 Jan 2023 07:50:24 -0500 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38A0D12F0D; Mon, 23 Jan 2023 04:49:56 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id D81BCC0009; Mon, 23 Jan 2023 12:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674478166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rIQSstPgcXGmcuQdv16JqxlRCmJme9MN5dDSHfjPQck=; b=is9otCpMHRwafdtuEmY6Bor36GywFgth88qTpDgaNBO02LPYmFSrZSWkaEL6G0alBJj/IE TJc82e0yo3S0baHOFooMqVTjH+K98UclQZEA3ZoHD0pa3B56sZ7KSwzS5HtvdI9dieP+t7 mIRT9q99U52m9gZbeRrJrYCGkSeVSl6eq9KhCA3ONShwfVUZxqHWU4S1+w1y6VVOvclwYE vbC7ymf+9u+RcueU/7pnGBF9kln8MsYZdaB82658lsixGjlkXQ/yDhgGIPA1OjfFDWZQAs KfCoZnsL602EpsaepFkkAGJh8yXBNvgSNz2o6ZRxEflYg5l2t5InIsZTV/5FGg== Date: Mon, 23 Jan 2023 13:49:21 +0100 From: Miquel Raynal To: Alexander Aring Cc: Alexander Aring , Stefan Schmidt , linux-wpan@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, David Girault , Romuald Despres , Frederic Blain , Nicolas Schodet , Guilhem Imberton , Thomas Petazzoni Subject: Re: [PATCH wpan-next 0/2] ieee802154: Beaconing support Message-ID: <20230123134921.38cdfd42@xps-13> In-Reply-To: <20230118102058.3b1f275b@xps-13> References: <20230106113129.694750-1-miquel.raynal@bootlin.com> <20230118102058.3b1f275b@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Alexander, > > btw: what is about security handling... however I would declare this > > feature as experimental anyway. =20 >=20 > I haven't tested the security layer at all yet, would you have a few > commands to start with, which I could try using eg. hwsim? Using the dev_queue_xmit() doest not bypasses the whole stack anymore, the beacons got rejected by the llsec layer. I did just hack into it just to allow unsecure beacons for now: - if (hlen < 0 || hdr.fc.type !=3D IEEE802154_FC_TYPE_DATA) + if (hlen < 0 || + (hdr.fc.type !=3D IEEE802154_FC_TYPE_DATA && + hdr.fc.type !=3D IEEE802154_FC_TYPE_BEACON)) return -EINVAL; I believe that would be enough as a first step, at least for merging beacons support for now. However I'll have to look at the spec about security stuff and beaconing to know how to handle this properly if security was required, but could you drive me through useful resources were I could quickly grasp how all that works? Did you make any presentation of it? Perhaps just a blog post or something alike? Or even just a script showing its use? While I was looking at linux-wpan.org, I realized we should both contribute to it with some examples about security stuff and beaconing/scanning? Thanks, Miqu=C3=A8l