From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C906C38142 for ; Tue, 24 Jan 2023 09:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233471AbjAXJmt (ORCPT ); Tue, 24 Jan 2023 04:42:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232776AbjAXJmr (ORCPT ); Tue, 24 Jan 2023 04:42:47 -0500 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDC601704; Tue, 24 Jan 2023 01:42:41 -0800 (PST) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 07FEDC0002; Tue, 24 Jan 2023 09:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674553359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ke8PpnBYtq0uoMPZ4KXBhGHV0aGLKGiBTbsb/9DcACw=; b=OBnDzO21zBEolJhYXCoBIAM/TsM6/WMHNuUfk+l6SvClCaKodQeGNH4vJ1Wwuq5Wrj55RA JzemmolOIv0lxhYOdsx4l+ullMmYCXFvO65tMJLAOH11hF5vgXHqADpMiWz08MxIQlf+/N pWsu2/YR1/OsTa2H62xvcTqcDxHDcdrZilgLLuHdPYBUtgS63rLZevV6B7J7JCdE2hzUkL ttPcYFWO7n0IjBDqwUjoHH7ql0gqvNaIWHmMsGWfGClvQhbeN//Y4pG37AK3nnJN5fsIVN eyMitol0Xvxb7ovHzPCRBkcS+RT0koUZbMnVvlggWAy5TkDXedcYHN1E8ebEng== Date: Tue, 24 Jan 2023 10:42:32 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124104232.183cc9ff@bootlin.com> In-Reply-To: <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Tue, 17 Jan 2023 12:31:09 +0100 Krzysztof Kozlowski wrote: > On 13/01/2023 11:37, Herve Codina wrote: > > Add support for the QMC (QUICC Multichannel Controller) > > available in some PowerQUICC SoC such as MPC885 or MPC866. > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 164 ++++++++++++++++++ > > 1 file changed, 164 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fs= l,qmc.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.y= aml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > > new file mode 100644 > > index 000000000000..3ec52f1635c8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > > @@ -0,0 +1,164 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qmc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: PowerQUICC CPM QUICC Multichannel Controller (QMC) > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | > > + The QMC (QUICC Multichannel Controller) emulates up to 64 channels w= ithin > > + one serial controller using the same TDM physical interface routed f= rom > > + TSA. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - fsl,mpc885-scc-qmc > > + - fsl,mpc866-scc-qmc > > + - const: fsl,cpm1-scc-qmc > > + > > + reg: > > + items: > > + - description: SCC (Serial communication controller) register ba= se > > + - description: SCC parameter ram base > > + - description: Dual port ram base > > + > > + reg-names: > > + items: > > + - const: scc_regs > > + - const: scc_pram > > + - const: dpram > > + > > + interrupts: > > + maxItems: 1 > > + description: SCC interrupt line in the CPM interrupt controller > > + > > + fsl,tsa: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: phandle to the TSA > > + > > + fsl,tsa-cell-id: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [1, 2, 3] > > + description: | > > + TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) > > + - 1: SCC2 > > + - 2: SCC3 > > + - 3: SCC4 =20 >=20 > Is this used as argument to tsa? If so, this should be part of fsl,tsa > property, just like we do for all syscon-like phandles. Yes, indeed. I will move 'fsl,tsa' to 'fsl,tsa-cell' with 'fsl,tsa-cell' a phandle/number pair (the phandle to TSA node and the TSA cell id to use) >=20 > > + > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + '#chan-cells': > > + const: 1 > > + > > +patternProperties: > > + '^channel@([0-9]|[1-5][0-9]|6[0-3])$': > > + description: > > + A channel managed by this controller > > + type: object > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 63 > > + description: > > + The channel number > > + > > + fsl,mode: > > + $ref: /schemas/types.yaml#/definitions/string > > + enum: [transparent, hdlc] > > + default: transparent > > + description: Operational mode =20 >=20 > You still need to explain what do transparent and hdlc mean. Oups, my bad (already mentioned in the previous version review). Also, I will rename the property to 'fsl,operational-mode' to be more precise than just 'fsl,mode' >=20 > > + =20 >=20 >=20 > Best regards, > Krzysztof >=20 Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04774C38142 for ; Tue, 24 Jan 2023 09:43:43 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 74A9685D; Tue, 24 Jan 2023 10:42:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 74A9685D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674553421; bh=D+28npJeHr78s8rnLFn/pLXO5pQf1I0OViva9ukfKo8=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=En4sL+NYO0IJ6XAu78xSR7qBgMQmQdSpVqkqVH4H/JxCXD+Q+of7IFC5cUxrQo0YN kJzJin7wwb4HbmN35rGh9ZooHjcpX+Dh/nowv4wUYF9Q8bktCcx0GUI99vdr4GlddK kKUtnCFHv8VNHSzpi/K9C0lcKUGoZVIwr2XMCGuw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E0AFCF8025D; Tue, 24 Jan 2023 10:42:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1CC52F8027D; Tue, 24 Jan 2023 10:42:48 +0100 (CET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8BC8CF80163 for ; Tue, 24 Jan 2023 10:42:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8BC8CF80163 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=OBnDzO21 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 07FEDC0002; Tue, 24 Jan 2023 09:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674553359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ke8PpnBYtq0uoMPZ4KXBhGHV0aGLKGiBTbsb/9DcACw=; b=OBnDzO21zBEolJhYXCoBIAM/TsM6/WMHNuUfk+l6SvClCaKodQeGNH4vJ1Wwuq5Wrj55RA JzemmolOIv0lxhYOdsx4l+ullMmYCXFvO65tMJLAOH11hF5vgXHqADpMiWz08MxIQlf+/N pWsu2/YR1/OsTa2H62xvcTqcDxHDcdrZilgLLuHdPYBUtgS63rLZevV6B7J7JCdE2hzUkL ttPcYFWO7n0IjBDqwUjoHH7ql0gqvNaIWHmMsGWfGClvQhbeN//Y4pG37AK3nnJN5fsIVN eyMitol0Xvxb7ovHzPCRBkcS+RT0koUZbMnVvlggWAy5TkDXedcYHN1E8ebEng== Date: Tue, 24 Jan 2023 10:42:32 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124104232.183cc9ff@bootlin.com> In-Reply-To: <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Michael Ellerman , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Christophe Leroy , Krzysztof Kozlowski , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Krzysztof, On Tue, 17 Jan 2023 12:31:09 +0100 Krzysztof Kozlowski wrote: > On 13/01/2023 11:37, Herve Codina wrote: > > Add support for the QMC (QUICC Multichannel Controller) > > available in some PowerQUICC SoC such as MPC885 or MPC866. > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 164 ++++++++++++++++++ > > 1 file changed, 164 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fs= l,qmc.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.y= aml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > > new file mode 100644 > > index 000000000000..3ec52f1635c8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > > @@ -0,0 +1,164 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qmc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: PowerQUICC CPM QUICC Multichannel Controller (QMC) > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | > > + The QMC (QUICC Multichannel Controller) emulates up to 64 channels w= ithin > > + one serial controller using the same TDM physical interface routed f= rom > > + TSA. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - fsl,mpc885-scc-qmc > > + - fsl,mpc866-scc-qmc > > + - const: fsl,cpm1-scc-qmc > > + > > + reg: > > + items: > > + - description: SCC (Serial communication controller) register ba= se > > + - description: SCC parameter ram base > > + - description: Dual port ram base > > + > > + reg-names: > > + items: > > + - const: scc_regs > > + - const: scc_pram > > + - const: dpram > > + > > + interrupts: > > + maxItems: 1 > > + description: SCC interrupt line in the CPM interrupt controller > > + > > + fsl,tsa: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: phandle to the TSA > > + > > + fsl,tsa-cell-id: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [1, 2, 3] > > + description: | > > + TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) > > + - 1: SCC2 > > + - 2: SCC3 > > + - 3: SCC4 =20 >=20 > Is this used as argument to tsa? If so, this should be part of fsl,tsa > property, just like we do for all syscon-like phandles. Yes, indeed. I will move 'fsl,tsa' to 'fsl,tsa-cell' with 'fsl,tsa-cell' a phandle/number pair (the phandle to TSA node and the TSA cell id to use) >=20 > > + > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + '#chan-cells': > > + const: 1 > > + > > +patternProperties: > > + '^channel@([0-9]|[1-5][0-9]|6[0-3])$': > > + description: > > + A channel managed by this controller > > + type: object > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 63 > > + description: > > + The channel number > > + > > + fsl,mode: > > + $ref: /schemas/types.yaml#/definitions/string > > + enum: [transparent, hdlc] > > + default: transparent > > + description: Operational mode =20 >=20 > You still need to explain what do transparent and hdlc mean. Oups, my bad (already mentioned in the previous version review). Also, I will rename the property to 'fsl,operational-mode' to be more precise than just 'fsl,mode' >=20 > > + =20 >=20 >=20 > Best regards, > Krzysztof >=20 Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0B41C54EB4 for ; Tue, 24 Jan 2023 09:43:47 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4P1MVV0fS0z3cFt for ; Tue, 24 Jan 2023 20:43:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=OBnDzO21; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::226; helo=relay6-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=OBnDzO21; dkim-atps=neutral Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4P1MTT6qDSz30hl for ; Tue, 24 Jan 2023 20:42:51 +1100 (AEDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 07FEDC0002; Tue, 24 Jan 2023 09:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674553359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ke8PpnBYtq0uoMPZ4KXBhGHV0aGLKGiBTbsb/9DcACw=; b=OBnDzO21zBEolJhYXCoBIAM/TsM6/WMHNuUfk+l6SvClCaKodQeGNH4vJ1Wwuq5Wrj55RA JzemmolOIv0lxhYOdsx4l+ullMmYCXFvO65tMJLAOH11hF5vgXHqADpMiWz08MxIQlf+/N pWsu2/YR1/OsTa2H62xvcTqcDxHDcdrZilgLLuHdPYBUtgS63rLZevV6B7J7JCdE2hzUkL ttPcYFWO7n0IjBDqwUjoHH7ql0gqvNaIWHmMsGWfGClvQhbeN//Y4pG37AK3nnJN5fsIVN eyMitol0Xvxb7ovHzPCRBkcS+RT0koUZbMnVvlggWAy5TkDXedcYHN1E8ebEng== Date: Tue, 24 Jan 2023 10:42:32 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124104232.183cc9ff@bootlin.com> In-Reply-To: <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Krzysztof Kozlowski , Jaroslav Kysela , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Krzysztof, On Tue, 17 Jan 2023 12:31:09 +0100 Krzysztof Kozlowski wrote: > On 13/01/2023 11:37, Herve Codina wrote: > > Add support for the QMC (QUICC Multichannel Controller) > > available in some PowerQUICC SoC such as MPC885 or MPC866. > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 164 ++++++++++++++++++ > > 1 file changed, 164 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fs= l,qmc.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.y= aml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > > new file mode 100644 > > index 000000000000..3ec52f1635c8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > > @@ -0,0 +1,164 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qmc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: PowerQUICC CPM QUICC Multichannel Controller (QMC) > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | > > + The QMC (QUICC Multichannel Controller) emulates up to 64 channels w= ithin > > + one serial controller using the same TDM physical interface routed f= rom > > + TSA. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - fsl,mpc885-scc-qmc > > + - fsl,mpc866-scc-qmc > > + - const: fsl,cpm1-scc-qmc > > + > > + reg: > > + items: > > + - description: SCC (Serial communication controller) register ba= se > > + - description: SCC parameter ram base > > + - description: Dual port ram base > > + > > + reg-names: > > + items: > > + - const: scc_regs > > + - const: scc_pram > > + - const: dpram > > + > > + interrupts: > > + maxItems: 1 > > + description: SCC interrupt line in the CPM interrupt controller > > + > > + fsl,tsa: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: phandle to the TSA > > + > > + fsl,tsa-cell-id: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [1, 2, 3] > > + description: | > > + TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) > > + - 1: SCC2 > > + - 2: SCC3 > > + - 3: SCC4 =20 >=20 > Is this used as argument to tsa? If so, this should be part of fsl,tsa > property, just like we do for all syscon-like phandles. Yes, indeed. I will move 'fsl,tsa' to 'fsl,tsa-cell' with 'fsl,tsa-cell' a phandle/number pair (the phandle to TSA node and the TSA cell id to use) >=20 > > + > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + '#chan-cells': > > + const: 1 > > + > > +patternProperties: > > + '^channel@([0-9]|[1-5][0-9]|6[0-3])$': > > + description: > > + A channel managed by this controller > > + type: object > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 63 > > + description: > > + The channel number > > + > > + fsl,mode: > > + $ref: /schemas/types.yaml#/definitions/string > > + enum: [transparent, hdlc] > > + default: transparent > > + description: Operational mode =20 >=20 > You still need to explain what do transparent and hdlc mean. Oups, my bad (already mentioned in the previous version review). Also, I will rename the property to 'fsl,operational-mode' to be more precise than just 'fsl,mode' >=20 > > + =20 >=20 >=20 > Best regards, > Krzysztof >=20 Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C90ACC38142 for ; Tue, 24 Jan 2023 09:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xDkd1sfJR1J2IOpj9EMexdbdOP6y9bmKA+O7ckY/e1c=; b=J3VJTR6xaKV5Eo d+lfjUfc4vFAzbmU2njh6jj5oAucO4wFvZc+MTkfvvsnOUuZs/zN5HBiLgXaTi7ZgvDjdkaEIA8rK hNB5VgFSerQ2r69PIATamSefkVMcwwjGlziEEDqbFDJ0rl61KwJ0XGYkucE+P9uqovLirDLbbU85W 9cJ2f6Ll9Rk3lohPp34xX+sWIDeyQkpvwNA1QTb7Veoeo3FcH8W4SH8fbBQ0/kbyqQGabgVQT7DWt BUw/J8PJgNfGv/8lM3/p7bYpcy2rNFsSraZMFxk8C+6d5sj+H0daeKsTteFOoeYlJTt/eXnrfmwi4 Y2NIvgka/PTDUQQCcLEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKFpJ-002yvX-22; Tue, 24 Jan 2023 09:42:49 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKFpE-002yul-TO for linux-arm-kernel@lists.infradead.org; Tue, 24 Jan 2023 09:42:47 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 07FEDC0002; Tue, 24 Jan 2023 09:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674553359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ke8PpnBYtq0uoMPZ4KXBhGHV0aGLKGiBTbsb/9DcACw=; b=OBnDzO21zBEolJhYXCoBIAM/TsM6/WMHNuUfk+l6SvClCaKodQeGNH4vJ1Wwuq5Wrj55RA JzemmolOIv0lxhYOdsx4l+ullMmYCXFvO65tMJLAOH11hF5vgXHqADpMiWz08MxIQlf+/N pWsu2/YR1/OsTa2H62xvcTqcDxHDcdrZilgLLuHdPYBUtgS63rLZevV6B7J7JCdE2hzUkL ttPcYFWO7n0IjBDqwUjoHH7ql0gqvNaIWHmMsGWfGClvQhbeN//Y4pG37AK3nnJN5fsIVN eyMitol0Xvxb7ovHzPCRBkcS+RT0koUZbMnVvlggWAy5TkDXedcYHN1E8ebEng== Date: Tue, 24 Jan 2023 10:42:32 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124104232.183cc9ff@bootlin.com> In-Reply-To: <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230124_014245_431559_99A9BD68 X-CRM114-Status: GOOD ( 23.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLAoKT24gVHVlLCAxNyBKYW4gMjAyMyAxMjozMTowOSArMDEwMApLcnp5c3p0 b2YgS296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+IHdyb3RlOgoKPiBP biAxMy8wMS8yMDIzIDExOjM3LCBIZXJ2ZSBDb2RpbmEgd3JvdGU6Cj4gPiBBZGQgc3VwcG9ydCBm b3IgdGhlIFFNQyAoUVVJQ0MgTXVsdGljaGFubmVsIENvbnRyb2xsZXIpCj4gPiBhdmFpbGFibGUg aW4gc29tZSBQb3dlclFVSUNDIFNvQyBzdWNoIGFzIE1QQzg4NSBvciBNUEM4NjYuCj4gPiAKPiA+ IFNpZ25lZC1vZmYtYnk6IEhlcnZlIENvZGluYSA8aGVydmUuY29kaW5hQGJvb3RsaW4uY29tPgo+ ID4gLS0tCj4gPiAgLi4uL2JpbmRpbmdzL3NvYy9mc2wvY3BtX3FlL2ZzbCxxbWMueWFtbCAgICAg IHwgMTY0ICsrKysrKysrKysrKysrKysrKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNjQgaW5zZXJ0 aW9ucygrKQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3Mvc29jL2ZzbC9jcG1fcWUvZnNsLHFtYy55YW1sCj4gPiAKPiA+IGRpZmYgLS1naXQg YS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc29jL2ZzbC9jcG1fcWUvZnNsLHFt Yy55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9mc2wvY3BtX3Fl L2ZzbCxxbWMueWFtbAo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+IGluZGV4IDAwMDAwMDAw MDAwMC4uM2VjNTJmMTYzNWM4Cj4gPiAtLS0gL2Rldi9udWxsCj4gPiArKysgYi9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc29jL2ZzbC9jcG1fcWUvZnNsLHFtYy55YW1sCj4gPiBA QCAtMCwwICsxLDE2NCBAQAo+ID4gKyMgU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IChHUEwtMi4w LW9ubHkgT1IgQlNELTItQ2xhdXNlKQo+ID4gKyVZQU1MIDEuMgo+ID4gKy0tLQo+ID4gKyRpZDog aHR0cDovL2RldmljZXRyZWUub3JnL3NjaGVtYXMvc29jL2ZzbC9jcG1fcWUvZnNsLHFtYy55YW1s Iwo+ID4gKyRzY2hlbWE6IGh0dHA6Ly9kZXZpY2V0cmVlLm9yZy9tZXRhLXNjaGVtYXMvY29yZS55 YW1sIwo+ID4gKwo+ID4gK3RpdGxlOiBQb3dlclFVSUNDIENQTSBRVUlDQyBNdWx0aWNoYW5uZWwg Q29udHJvbGxlciAoUU1DKQo+ID4gKwo+ID4gK21haW50YWluZXJzOgo+ID4gKyAgLSBIZXJ2ZSBD b2RpbmEgPGhlcnZlLmNvZGluYUBib290bGluLmNvbT4KPiA+ICsKPiA+ICtkZXNjcmlwdGlvbjog fAo+ID4gKyAgVGhlIFFNQyAoUVVJQ0MgTXVsdGljaGFubmVsIENvbnRyb2xsZXIpIGVtdWxhdGVz IHVwIHRvIDY0IGNoYW5uZWxzIHdpdGhpbgo+ID4gKyAgb25lIHNlcmlhbCBjb250cm9sbGVyIHVz aW5nIHRoZSBzYW1lIFRETSBwaHlzaWNhbCBpbnRlcmZhY2Ugcm91dGVkIGZyb20KPiA+ICsgIFRT QS4KPiA+ICsKPiA+ICtwcm9wZXJ0aWVzOgo+ID4gKyAgY29tcGF0aWJsZToKPiA+ICsgICAgaXRl bXM6Cj4gPiArICAgICAgLSBlbnVtOgo+ID4gKyAgICAgICAgICAtIGZzbCxtcGM4ODUtc2NjLXFt Ywo+ID4gKyAgICAgICAgICAtIGZzbCxtcGM4NjYtc2NjLXFtYwo+ID4gKyAgICAgIC0gY29uc3Q6 IGZzbCxjcG0xLXNjYy1xbWMKPiA+ICsKPiA+ICsgIHJlZzoKPiA+ICsgICAgaXRlbXM6Cj4gPiAr ICAgICAgLSBkZXNjcmlwdGlvbjogU0NDIChTZXJpYWwgY29tbXVuaWNhdGlvbiBjb250cm9sbGVy KSByZWdpc3RlciBiYXNlCj4gPiArICAgICAgLSBkZXNjcmlwdGlvbjogU0NDIHBhcmFtZXRlciBy YW0gYmFzZQo+ID4gKyAgICAgIC0gZGVzY3JpcHRpb246IER1YWwgcG9ydCByYW0gYmFzZQo+ID4g Kwo+ID4gKyAgcmVnLW5hbWVzOgo+ID4gKyAgICBpdGVtczoKPiA+ICsgICAgICAtIGNvbnN0OiBz Y2NfcmVncwo+ID4gKyAgICAgIC0gY29uc3Q6IHNjY19wcmFtCj4gPiArICAgICAgLSBjb25zdDog ZHByYW0KPiA+ICsKPiA+ICsgIGludGVycnVwdHM6Cj4gPiArICAgIG1heEl0ZW1zOiAxCj4gPiAr ICAgIGRlc2NyaXB0aW9uOiBTQ0MgaW50ZXJydXB0IGxpbmUgaW4gdGhlIENQTSBpbnRlcnJ1cHQg Y29udHJvbGxlcgo+ID4gKwo+ID4gKyAgZnNsLHRzYToKPiA+ICsgICAgJHJlZjogL3NjaGVtYXMv dHlwZXMueWFtbCMvZGVmaW5pdGlvbnMvcGhhbmRsZQo+ID4gKyAgICBkZXNjcmlwdGlvbjogcGhh bmRsZSB0byB0aGUgVFNBCj4gPiArCj4gPiArICBmc2wsdHNhLWNlbGwtaWQ6Cj4gPiArICAgICRy ZWY6IC9zY2hlbWFzL3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3VpbnQzMgo+ID4gKyAgICBlbnVt OiBbMSwgMiwgM10KPiA+ICsgICAgZGVzY3JpcHRpb246IHwKPiA+ICsgICAgICBUU0EgY2VsbCBJ RCAoZHQtYmluZGluZ3Mvc29jL2ZzbCx0c2EuaCBkZWZpbmVzIHRoZXNlIHZhbHVlcykKPiA+ICsg ICAgICAgLSAxOiBTQ0MyCj4gPiArICAgICAgIC0gMjogU0NDMwo+ID4gKyAgICAgICAtIDM6IFND QzQgIAo+IAo+IElzIHRoaXMgdXNlZCBhcyBhcmd1bWVudCB0byB0c2E/IElmIHNvLCB0aGlzIHNo b3VsZCBiZSBwYXJ0IG9mIGZzbCx0c2EKPiBwcm9wZXJ0eSwganVzdCBsaWtlIHdlIGRvIGZvciBh bGwgc3lzY29uLWxpa2UgcGhhbmRsZXMuCgpZZXMsIGluZGVlZC4KSSB3aWxsIG1vdmUgJ2ZzbCx0 c2EnIHRvICdmc2wsdHNhLWNlbGwnIHdpdGggJ2ZzbCx0c2EtY2VsbCcgYSBwaGFuZGxlL251bWJl cgpwYWlyICh0aGUgcGhhbmRsZSB0byBUU0Egbm9kZSBhbmQgdGhlIFRTQSBjZWxsIGlkIHRvIHVz ZSkKCj4gCj4gPiArCj4gPiArICAnI2FkZHJlc3MtY2VsbHMnOgo+ID4gKyAgICBjb25zdDogMQo+ ID4gKwo+ID4gKyAgJyNzaXplLWNlbGxzJzoKPiA+ICsgICAgY29uc3Q6IDAKPiA+ICsKPiA+ICsg ICcjY2hhbi1jZWxscyc6Cj4gPiArICAgIGNvbnN0OiAxCj4gPiArCj4gPiArcGF0dGVyblByb3Bl cnRpZXM6Cj4gPiArICAnXmNoYW5uZWxAKFswLTldfFsxLTVdWzAtOV18NlswLTNdKSQnOgo+ID4g KyAgICBkZXNjcmlwdGlvbjoKPiA+ICsgICAgICBBIGNoYW5uZWwgbWFuYWdlZCBieSB0aGlzIGNv bnRyb2xsZXIKPiA+ICsgICAgdHlwZTogb2JqZWN0Cj4gPiArCj4gPiArICAgIHByb3BlcnRpZXM6 Cj4gPiArICAgICAgcmVnOgo+ID4gKyAgICAgICAgbWluaW11bTogMAo+ID4gKyAgICAgICAgbWF4 aW11bTogNjMKPiA+ICsgICAgICAgIGRlc2NyaXB0aW9uOgo+ID4gKyAgICAgICAgICBUaGUgY2hh bm5lbCBudW1iZXIKPiA+ICsKPiA+ICsgICAgICBmc2wsbW9kZToKPiA+ICsgICAgICAgICRyZWY6 IC9zY2hlbWFzL3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3N0cmluZwo+ID4gKyAgICAgICAgZW51 bTogW3RyYW5zcGFyZW50LCBoZGxjXQo+ID4gKyAgICAgICAgZGVmYXVsdDogdHJhbnNwYXJlbnQK PiA+ICsgICAgICAgIGRlc2NyaXB0aW9uOiBPcGVyYXRpb25hbCBtb2RlICAKPiAKPiBZb3Ugc3Rp bGwgbmVlZCB0byBleHBsYWluIHdoYXQgZG8gdHJhbnNwYXJlbnQgYW5kIGhkbGMgbWVhbi4KCk91 cHMsIG15IGJhZCAoYWxyZWFkeSBtZW50aW9uZWQgaW4gdGhlIHByZXZpb3VzIHZlcnNpb24gcmV2 aWV3KS4KCkFsc28sIEkgd2lsbCByZW5hbWUgdGhlIHByb3BlcnR5IHRvICdmc2wsb3BlcmF0aW9u YWwtbW9kZScgdG8gYmUKbW9yZSBwcmVjaXNlIHRoYW4ganVzdCAnZnNsLG1vZGUnCgo+IAo+ID4g KyAgCj4gCj4gCj4gQmVzdCByZWdhcmRzLAo+IEtyenlzenRvZgo+IAoKVGhhbmtzIGZvciB0aGUg cmV2aWV3LApIZXJ2w6kKCi0tIApIZXJ2w6kgQ29kaW5hLCBCb290bGluCkVtYmVkZGVkIExpbnV4 IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=