From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 925D9C61D97 for ; Tue, 24 Jan 2023 21:04:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234543AbjAXVEI (ORCPT ); Tue, 24 Jan 2023 16:04:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjAXVEG (ORCPT ); Tue, 24 Jan 2023 16:04:06 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E75F4E05D; Tue, 24 Jan 2023 13:04:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9B6D1B816D8; Tue, 24 Jan 2023 21:04:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E31C3C433D2; Tue, 24 Jan 2023 21:04:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1674594242; bh=zjcANJE6uGzwSR4wTIiOQxcwFMp4+Yz5YqNXXhvxlZw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FqySnI4K96d799gpZOFbX42GtEloF+F2Qd7fEzmx0GhoOLzs+V1i9DTlrU1UKd/02 Hjuu/ELjUesERXd5b+wWuorsVm2xPmIA5wtRHvl+GZny+5oN8q9FGbJBg2h57TomCz uzDtXADYIc0ipLpnAPanocU0tIlVbA416ABzGw/Y= Date: Tue, 24 Jan 2023 13:04:01 -0800 From: Andrew Morton To: Alexander Potapenko Cc: linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers Subject: Re: [PATCH 4/5] fs: hfs: initialize fsdata in hfs_file_truncate() Message-Id: <20230124130401.eb5d453213d557cf3b7a8ed6@linux-foundation.org> In-Reply-To: References: <20221121112134.407362-1-glider@google.com> <20221121112134.407362-4-glider@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Jan 2023 11:51:30 +0100 Alexander Potapenko wrote: > On Mon, Nov 21, 2022 at 12:21 PM Alexander Potapenko wrote: > > > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > an error passing the latter to aops->write_end(). > > > > Fix this by unconditionally initializing fsdata. > > > > Suggested-by: Eric Biggers > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > Signed-off-by: Alexander Potapenko > > Dear FS maintainers, > > HFS/HFSPLUS are orphaned, can someone take this patch to their tree? > Thanks in advance! > (same for "fs: hfsplus: initialize fsdata in hfsplus_file_truncate()": > https://lore.kernel.org/all/20221121112134.407362-5-glider@google.com/) I grabbed both. I removed the Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") because that might provoke the backport bots to backport this fix across eight years worth of kernels. Before KMSAN existed! If you intended that this be backported then please let's come up with a more precise Fixes: target and we'll add cc:stable. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39B2DC54E94 for ; Tue, 24 Jan 2023 21:23:43 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pKQla-0007Jt-2l; Tue, 24 Jan 2023 21:23:41 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pKQlZ-0007Jn-BV for linux-f2fs-devel@lists.sourceforge.net; Tue, 24 Jan 2023 21:23:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:Mime-Version :References:In-Reply-To:Message-Id:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fXNPgr2sAloxtIAnVNbt4nQCZh1rVHT7ASa+sYKWPoo=; b=Gjo5mBhYxR0h8PrxpmqIsqUCIL me/zZeyhI3YuripOEvXbUS32XW4QZZV1P25eUpS74eefrkz0JvMvCC/0Rz4BZJZTC+zmQGR8++FHF Iyva+GfrVj/K9gLHarYjZVoc1C63dTDfiA9vWRrT8zBSojYuY8ICzlO0baBc8XacQl8A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:Mime-Version:References: In-Reply-To:Message-Id:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fXNPgr2sAloxtIAnVNbt4nQCZh1rVHT7ASa+sYKWPoo=; b=VXjnMsdHtARZShjUfW/k1CqcHv 67FNMGaDi+PcrIcajIE4lhSj9dtECvXSsUJm6hwRnx+iEB4HfzYNYkNpwMPmbnRUmcXoO5jl67K7R mMA3m8H4qMNMQQVtpTwKjRV68iejFaGl8VGqOsdbhfz9fFZeAAR38gA9Qo61Imar8BA4=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pKQlU-0007jc-Kj for linux-f2fs-devel@lists.sourceforge.net; Tue, 24 Jan 2023 21:23:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 91C91B811DA; Tue, 24 Jan 2023 21:04:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E31C3C433D2; Tue, 24 Jan 2023 21:04:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1674594242; bh=zjcANJE6uGzwSR4wTIiOQxcwFMp4+Yz5YqNXXhvxlZw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FqySnI4K96d799gpZOFbX42GtEloF+F2Qd7fEzmx0GhoOLzs+V1i9DTlrU1UKd/02 Hjuu/ELjUesERXd5b+wWuorsVm2xPmIA5wtRHvl+GZny+5oN8q9FGbJBg2h57TomCz uzDtXADYIc0ipLpnAPanocU0tIlVbA416ABzGw/Y= Date: Tue, 24 Jan 2023 13:04:01 -0800 From: Andrew Morton To: Alexander Potapenko Message-Id: <20230124130401.eb5d453213d557cf3b7a8ed6@linux-foundation.org> In-Reply-To: References: <20221121112134.407362-1-glider@google.com> <20221121112134.407362-4-glider@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Headers-End: 1pKQlU-0007jc-Kj Subject: Re: [f2fs-dev] [PATCH 4/5] fs: hfs: initialize fsdata in hfs_file_truncate() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tytso@mit.edu, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, 24 Jan 2023 11:51:30 +0100 Alexander Potapenko wrote: > On Mon, Nov 21, 2022 at 12:21 PM Alexander Potapenko wrote: > > > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > an error passing the latter to aops->write_end(). > > > > Fix this by unconditionally initializing fsdata. > > > > Suggested-by: Eric Biggers > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > Signed-off-by: Alexander Potapenko > > Dear FS maintainers, > > HFS/HFSPLUS are orphaned, can someone take this patch to their tree? > Thanks in advance! > (same for "fs: hfsplus: initialize fsdata in hfsplus_file_truncate()": > https://lore.kernel.org/all/20221121112134.407362-5-glider@google.com/) I grabbed both. I removed the Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") because that might provoke the backport bots to backport this fix across eight years worth of kernels. Before KMSAN existed! If you intended that this be backported then please let's come up with a more precise Fixes: target and we'll add cc:stable. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel