From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472CDC61D97 for ; Thu, 26 Jan 2023 00:25:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229550AbjAZAZX (ORCPT ); Wed, 25 Jan 2023 19:25:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230458AbjAZAZU (ORCPT ); Wed, 25 Jan 2023 19:25:20 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C02B64686 for ; Wed, 25 Jan 2023 16:25:18 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id m2so640395ejb.8 for ; Wed, 25 Jan 2023 16:25:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=diag.uniroma1.it; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uOYadJvP8u49K2x2oSYl+EYqiXssZ4idBGq/e4Tz9NY=; b=O4V0DOQaxPn+3nnvaVO3+OedTg4H8gEUR2e+X840qxeB1rz3lPMUCUHPlScsQb9ImT yOEROGe1pUIaxqUwsrMKjOB9Mqj5b6UOwVGFASYzb0AVOwqDbZnExHiTorFoOWeZPaWV 5K0fcSdfaRny3eW0RpfddFm2xA7FOcBDNEvRc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uOYadJvP8u49K2x2oSYl+EYqiXssZ4idBGq/e4Tz9NY=; b=P0Fsj3d7k1JyvPgPq/AMAAhUnjfiufSbQ7Vyl8h24ubfLNPfTcJPY0aCWmGq/mlcdb 82Cv/hm9QCv1jOWASrglK/jTHdt9eVi1Dw0kxdj5xfZ5v1ROeMM4p/4WK8uW08PAjGrI nKiugUh9f/pup6qEDfcVTQUgbHCQkrRQLCNh9UhzWzwavtvPPJOAAbtatnPkK27FgycV uMKun3JafMUfELve8UUc0euUEHAymDWqHln5ol9BSEYICfxneuiV4Wb1XDOitkqPU+ND PEkuNiuLEEXhIC8o/fr3KyU9hAZ3WJ/26Suqz9Q4QKaRS+haHTBuTKt4SMEtfQLJj2A+ F4Uw== X-Gm-Message-State: AFqh2kq8kDjkd05GOuLjFfk3mCUeK595RAjJhq/BqjGTNIWFNEzuaHk7 S6Ok0tVytjLgM006i1/LRn/Zwg== X-Google-Smtp-Source: AMrXdXuntbpvN+806ZegH5ixi1SfuWScLJxEwEMFaUWL58CNZT81ZcYZ2PCbsG6v0BxwZvZ7PsRBtQ== X-Received: by 2002:a17:907:76b0:b0:7c1:7045:1a53 with SMTP id jw16-20020a17090776b000b007c170451a53mr32550663ejc.15.1674692716489; Wed, 25 Jan 2023 16:25:16 -0800 (PST) Received: from [192.168.17.2] (wolkje-127.labs.vu.nl. [130.37.198.127]) by smtp.gmail.com with ESMTPSA id jy12-20020a170907762c00b008784e808553sm555707ejc.6.2023.01.25.16.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 16:25:16 -0800 (PST) From: Pietro Borrello Date: Thu, 26 Jan 2023 00:24:53 +0000 Subject: [PATCH 1/5] HID: bigben_remove: manually unregister leds MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230125-hid-unregister-leds-v1-1-9a5192dcef16@diag.uniroma1.it> References: <20230125-hid-unregister-leds-v1-0-9a5192dcef16@diag.uniroma1.it> In-Reply-To: <20230125-hid-unregister-leds-v1-0-9a5192dcef16@diag.uniroma1.it> To: Jiri Kosina , Benjamin Tissoires , Hanno Zulla , Carlo Caione , Pavel Machek , Lee Jones , Roderick Colenbrander , Sven Eckelmann Cc: linux-leds@vger.kernel.org, Cristiano Giuffrida , "Bos, H.J." , Jakob Koschel , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , Roderick Colenbrander , Pietro Borrello X-Mailer: b4 0.11.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1674692715; l=1037; i=borrello@diag.uniroma1.it; s=20221223; h=from:subject:message-id; bh=wlU1zbXd7qFTSbVqYvqS9BOVrqglVS3eHD1ePCtISHc=; b=GeizybQArtv4+HBTakrKxETsSVRvGKMNeRue1tkG2U0KcYshHgneXwski3bWn3Wnk7Dda4OEQvQ1 jAU9iMk1B2kBNODa9HOqbXggvFc3nR73/XdctsvKQ04xtFJglhqI X-Developer-Key: i=borrello@diag.uniroma1.it; a=ed25519; pk=4xRQbiJKehl7dFvrG33o2HpveMrwQiUPKtIlObzKmdY= Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Unregister the LED controllers before device removal, as bigben_set_led() may schedule bigben->worker after the structure has been freed, causing a use-after-free. Fixes: 4eb1b01de5b9 ("HID: hid-bigbenff: fix race condition for scheduled work during removal") Signed-off-by: Pietro Borrello --- drivers/hid/hid-bigbenff.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/hid/hid-bigbenff.c b/drivers/hid/hid-bigbenff.c index e8b16665860d..d3201b755595 100644 --- a/drivers/hid/hid-bigbenff.c +++ b/drivers/hid/hid-bigbenff.c @@ -306,9 +306,14 @@ static enum led_brightness bigben_get_led(struct led_classdev *led) static void bigben_remove(struct hid_device *hid) { + int n; struct bigben_device *bigben = hid_get_drvdata(hid); bigben->removed = true; + for (n = 0; n < NUM_LEDS; n++) { + if (bigben->leds[n]) + devm_led_classdev_unregister(&hid->dev, bigben->leds[n]); + } cancel_work_sync(&bigben->worker); hid_hw_stop(hid); } -- 2.25.1