From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id D70AB10E713 for ; Wed, 25 Jan 2023 05:42:42 +0000 (UTC) From: Ville Syrjala To: igt-dev@lists.freedesktop.org Date: Wed, 25 Jan 2023 07:42:36 +0200 Message-Id: <20230125054239.26812-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t 1/4] tools/intel_reg: Simplify negative ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: From: Ville Syrjälä Let's avoid having to type in the explicit negative value for all the port enums. v2: Copy-paste the comment from intel_reg.c (Jani) Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- tools/intel_reg_spec.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/intel_reg_spec.h b/tools/intel_reg_spec.h index c94c61bab3f8..1a2c5ebd9a58 100644 --- a/tools/intel_reg_spec.h +++ b/tools/intel_reg_spec.h @@ -25,10 +25,12 @@ #define __INTEL_REG_SPEC_H__ enum port_addr { + /* Negative port numbers are not real sideband ports. */ + PORT_MMIO = -127, + PORT_PORTIO_VGA, /* see vga reg read/write */ + PORT_MMIO_VGA, /* see vga reg read/write */ + PORT_NONE = 0, - PORT_MMIO = -1, - PORT_PORTIO_VGA = -2, /* see vga reg read/write */ - PORT_MMIO_VGA = -3, /* see vga reg read/write */ /* vlv */ PORT_BUNIT = 0x03, -- 2.39.1