From: Jakub Kicinski <kuba@kernel.org>
To: Raju Rangoju <Raju.Rangoju@amd.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<Shyam-sundar.S-k@amd.com>
Subject: Re: [PATCH net-next 2/2] amd-xgbe: add support for rx-adaptation
Date: Wed, 25 Jan 2023 23:04:10 -0800 [thread overview]
Message-ID: <20230125230410.79342e6a@kernel.org> (raw)
In-Reply-To: <20230125072529.2222420-3-Raju.Rangoju@amd.com>
On Wed, 25 Jan 2023 12:55:29 +0530 Raju Rangoju wrote:
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
> @@ -387,7 +387,13 @@ struct xgbe_phy_data {
> /* I2C, MDIO and GPIO lines are muxed, so only one device at a time */
> static DEFINE_MUTEX(xgbe_phy_comm_lock);
>
> +static void xgbe_phy_perform_ratechange(struct xgbe_prv_data *pdata,
> + unsigned int cmd, unsigned int sub_cmd);
> static enum xgbe_an_mode xgbe_phy_an_mode(struct xgbe_prv_data *pdata);
> +static void xgbe_phy_rrc(struct xgbe_prv_data *pdata);
> +static void xgbe_phy_set_mode(struct xgbe_prv_data *pdata, enum xgbe_mode mode);
> +static void xgbe_phy_kr_mode(struct xgbe_prv_data *pdata);
> +static void xgbe_phy_sfi_mode(struct xgbe_prv_data *pdata);
Why the forward declarations? It's against the kernel coding style.
> static int xgbe_phy_i2c_xfer(struct xgbe_prv_data *pdata,
> struct xgbe_i2c_op *i2c_op)
> @@ -2038,6 +2044,87 @@ static void xgbe_phy_set_redrv_mode(struct xgbe_prv_data *pdata)
> xgbe_phy_put_comm_ownership(pdata);
> }
>
> +#define MAX_RX_ADAPT_RETRIES 1
> +#define XGBE_PMA_RX_VAL_SIG_MASK (XGBE_PMA_RX_SIG_DET_0_MASK | XGBE_PMA_RX_VALID_0_MASK)
> +
> +static inline void xgbe_set_rx_adap_mode(struct xgbe_prv_data *pdata, enum xgbe_mode mode)
Don't pointlessly use inline, please. The compiler will know when
to inline, and this is not the datapath.
next prev parent reply other threads:[~2023-01-26 7:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 7:25 [PATCH net-next 0/2] amd-xgbe: add support for 2.5GbE and rx-adaptation Raju Rangoju
2023-01-25 7:25 ` [PATCH net-next 1/2] amd-xgbe: add 2.5GbE support to 10G BaseT mode Raju Rangoju
2023-01-25 13:39 ` Andrew Lunn
2023-01-26 6:49 ` Raju Rangoju
2023-01-25 7:25 ` [PATCH net-next 2/2] amd-xgbe: add support for rx-adaptation Raju Rangoju
2023-01-26 7:04 ` Jakub Kicinski [this message]
2023-01-27 7:43 ` Raju Rangoju
2023-01-31 9:56 ` Raju Rangoju
2023-01-31 19:11 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125230410.79342e6a@kernel.org \
--to=kuba@kernel.org \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.