From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38C2EC54E94 for ; Thu, 26 Jan 2023 02:01:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E29A6B0071; Wed, 25 Jan 2023 21:01:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 744216B0072; Wed, 25 Jan 2023 21:01:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6333B6B0073; Wed, 25 Jan 2023 21:01:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5040C6B0071 for ; Wed, 25 Jan 2023 21:01:36 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1E3D3A0BBC for ; Thu, 26 Jan 2023 02:01:36 +0000 (UTC) X-FDA: 80395298592.24.0258EDA Received: from r3-24.sinamail.sina.com.cn (r3-24.sinamail.sina.com.cn [202.108.3.24]) by imf23.hostedemail.com (Postfix) with ESMTP id 8449714000A for ; Thu, 26 Jan 2023 02:01:31 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.24 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674698494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G7z7E4NrTvueIdOBn5ake6IrH+deWrE1X928OBYnYiM=; b=3vg8KM9YfhvJ4XTKwrcM6zDhY0NqW4qt0C4gtsj+iQzUkmb9S1493hfCjWi7nQuLCMKes/ P0uiGcPd17FXobNV3o/mwLfTyMOBDT0xocwO8SUEGfUMI13zwXAQkL/dnv1o6xj0IDcyup 945L8dgR/nxsZiWJ5EutOUGVi1kze8U= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.24 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674698494; a=rsa-sha256; cv=none; b=tn4qbxz8i33oSlhZf0dDg31NOLvHg/726QPCTJFxWBn+xoWps14OwmS9cxcbjbjp+4aKwj OhnmPHLpISZrtceLPuUE0fl//ErSrgoF0NmlNqzaYKh4t9ZzVqD0eJvmhb4Xn7GEX/JqGT 7Jn+4D8nIod8oz+vkfj0ewDpQvbc6XE= Received: from unknown (HELO localhost.localdomain)([114.249.61.130]) by sina.com (172.16.97.23) with ESMTP id 63D1DE300000227D; Thu, 26 Jan 2023 09:58:10 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 1095554925859 From: Hillf Danton To: Marcelo Tosatti Cc: Leonardo =?iso-8859-1?Q?Br=E1s?= , Michal Hocko , Johannes Weiner , Roman Gushchin , Shakeel Butt , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] Introduce memcg_stock_pcp remote draining Date: Thu, 26 Jan 2023 10:01:14 +0800 Message-Id: <20230126020114.4745-1-hdanton@sina.com> In-Reply-To: References: <20230125073502.743446-1-leobras@redhat.com> <9e61ab53e1419a144f774b95230b789244895424.camel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8449714000A X-Stat-Signature: 57qf5af49sc1suj1e18fzwso4g4cye9g X-HE-Tag: 1674698491-636268 X-HE-Meta: U2FsdGVkX1/9Fy1znj4k6mD4chRXuqhd7RrfCSSULgGubTSTT9GMO+Auh2ApFejFoB3jrMaG+2cp+tssfZKACqgWRXa270+4mazYjmgj1mULOD9mZA74uL3/iK6o1bskIIPa/08exgA+THKjaG3kx56N1AYhrSmVsBNPqvX2k555ZTjfJzOvbfeQOAIjZEL5Ddui4dW/ZKrHQU3wsib0fJ4NCnS3KzWnu31EZCNlpTByurg+iZhYLpp1eH+GUQ5PSXTVaF6Qv+w9oE7BIvLqu59Bk+NQUWiq32+EVo7KcC1i9JeOIdlKMKcapSbcYakR0Y2PpZdqwPKu9jLO+k/O6lZHwfnPC5IM8H8RG+G9PnPVhSG3lpvWLPVsG6L0F+Iew1k2scFizU6szRJA6IQBya24N0WOjBzVx4sHmSCUDRawVYVvRpa9o0Demu3U+iwWb7UrGtnQ63Nz5VQchYWhY1pOCf/N6dijDRnJ0E5mf13HJ5KpA+UAJWEMXtSK7aQBUzG80vejX4hmIMCNfwwJ55mmnCUYHG87769qRy8JwaG0OxBeRw+WQxhHrHZ/ij5WcmmYozUguagX5YkBmEaMRjdzCPk/d4jNTY9ZbZ76tCT0JvJA8W63iXZ2LQS+6M2dAYZaJIGAiwe2UPlOKUB062bGxbbvc/N85gaNWY6s4QntLbWvz7RmcfXNWXBxS+oK9YlYWNkgncyVpWTRf2FLnjlAZaa1QCxECmL32u4oVjMGELc3SodkvtGOpBT+uGfTrVkqYbOnseSPKr4TDK2rBlL0Qyaky0o5aEF5Ajkx0pGF/dkpunedfZkTRk+qqHW0sXDAQdWiGFn0kCximuupAOrfB+eXBiLaFQubb6lfyIUvgotc2SvVq2XNNKN08lXQEmZqrUMDf/QONnP2jo2/5Z/7CWWRTG7Ahj5e2yq+RQAiMWRwhXsEIPFgp82HkykCNqtONyWImv0jwdN/v7P 6go453A9 OlAhnOR1lojnsLC2DzytkqbVcLF6QEnk/9acq16viwkDt4UYc94o3uFGDo0fY7wCMGXb1TRCRBR9dke1VgGETIEV3l60k0lFYUxnncnL/PRwpua6pqJDX3Opgdzal48PjeqqZQ9hPYRuRGXz1xKTQvgr2u0mXkVLszV3inyHLUqwCnDJ56x0Zw/Qxecmz1lAX6fIiv3Sc+LDvqKJpPC9IBNbOg8ZTA4XtrWF0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 25 Jan 2023 15:22:00 -0300 Marcelo Tosatti > > Remote draining reduces interruptions whether CPU > is marked as isolated or not: > > - Allows isolated CPUs from benefiting of pcp caching. > - Removes the interruption to non isolated CPUs. See for example Why ask refill to take a pill because drain got a cough? > > https://lkml.org/lkml/2022/6/13/2769 > > "Minchan Kim tested this independently and reported; > > My workload is not NOHZ CPUs but run apps under heavy memory > pressure so they goes to direct reclaim and be stuck on > drain_all_pages until work on workqueue run. What sense are you trying to make by getting CPUs isolated and equipped with tight memory? > > unit: nanosecond > max(dur) avg(dur) count(dur) > 166713013 487511.77786438033 1283 > > From traces, system encountered the drain_all_pages 1283 times and > worst case was 166ms and avg was 487us. > > The other problem was alloc_contig_range in CMA. The PCP draining > takes several hundred millisecond sometimes though there is no > memory pressure or a few of pages to be migrated out but CPU were > fully booked. > > Your patch perfectly removed those wasted time."