From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7084BC05027 for ; Thu, 26 Jan 2023 11:50:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235193AbjAZLuQ (ORCPT ); Thu, 26 Jan 2023 06:50:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235269AbjAZLuP (ORCPT ); Thu, 26 Jan 2023 06:50:15 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 421BD41098 for ; Thu, 26 Jan 2023 03:50:14 -0800 (PST) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4P2f6j2nbZz6883d; Thu, 26 Jan 2023 19:46:05 +0800 (CST) Received: from localhost (10.122.247.231) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 26 Jan 2023 11:50:12 +0000 Date: Thu, 26 Jan 2023 11:50:10 +0000 From: Jonathan Cameron To: Ira Weiny CC: Michael Tsirkin , Ben Widawsky , Peter Maydell , , Subject: Re: [PATCH 2/2] hw/cxl: Remove check for g_new0() failure Message-ID: <20230126115010.00005289@huawei.com> In-Reply-To: <20230125-ira-cxl-events-fixups-2023-01-11-v1-2-1931378515f5@intel.com> References: <20230125-ira-cxl-events-fixups-2023-01-11-v1-0-1931378515f5@intel.com> <20230125-ira-cxl-events-fixups-2023-01-11-v1-2-1931378515f5@intel.com> Organization: Huawei Technologies R&D (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.122.247.231] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Wed, 25 Jan 2023 21:37:28 -0800 Ira Weiny wrote: > g_new0() will terminate the application if it fails. Remove the check. > > Fixes: fb64c5661d5f ("hw/cxl/events: Wire up get/clear event mailbox commands") > Reported-by: Jonathan Cameron > Signed-off-by: Ira Weiny Squashed into original patch. Thanks, Jonathan > --- > hw/cxl/cxl-events.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/hw/cxl/cxl-events.c b/hw/cxl/cxl-events.c > index 2536aafc55fb..4cbc838e8ff4 100644 > --- a/hw/cxl/cxl-events.c > +++ b/hw/cxl/cxl-events.c > @@ -124,13 +124,7 @@ bool cxl_event_insert(CXLDeviceState *cxlds, > } > > entry = g_new0(CXLEvent, 1); > - if (!entry) { > - error_report("Failed to allocate memory for event log entry"); > - return false; > - } > - > memcpy(&entry->data, event, sizeof(*event)); > - > entry->data.hdr.handle = cpu_to_le16(log->next_handle); > log->next_handle++; > /* 0 handle is never valid */ > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35BB3C05027 for ; Thu, 26 Jan 2023 11:50:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pL0lr-0004mi-34; Thu, 26 Jan 2023 06:50:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pL0lp-0004lD-1n for qemu-devel@nongnu.org; Thu, 26 Jan 2023 06:50:21 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pL0lm-0004kc-PB for qemu-devel@nongnu.org; Thu, 26 Jan 2023 06:50:20 -0500 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4P2f6j2nbZz6883d; Thu, 26 Jan 2023 19:46:05 +0800 (CST) Received: from localhost (10.122.247.231) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 26 Jan 2023 11:50:12 +0000 Date: Thu, 26 Jan 2023 11:50:10 +0000 To: Ira Weiny CC: Michael Tsirkin , Ben Widawsky , Peter Maydell , , Subject: Re: [PATCH 2/2] hw/cxl: Remove check for g_new0() failure Message-ID: <20230126115010.00005289@huawei.com> In-Reply-To: <20230125-ira-cxl-events-fixups-2023-01-11-v1-2-1931378515f5@intel.com> References: <20230125-ira-cxl-events-fixups-2023-01-11-v1-0-1931378515f5@intel.com> <20230125-ira-cxl-events-fixups-2023-01-11-v1-2-1931378515f5@intel.com> Organization: Huawei Technologies R&D (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.122.247.231] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 25 Jan 2023 21:37:28 -0800 Ira Weiny wrote: > g_new0() will terminate the application if it fails. Remove the check. > > Fixes: fb64c5661d5f ("hw/cxl/events: Wire up get/clear event mailbox commands") > Reported-by: Jonathan Cameron > Signed-off-by: Ira Weiny Squashed into original patch. Thanks, Jonathan > --- > hw/cxl/cxl-events.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/hw/cxl/cxl-events.c b/hw/cxl/cxl-events.c > index 2536aafc55fb..4cbc838e8ff4 100644 > --- a/hw/cxl/cxl-events.c > +++ b/hw/cxl/cxl-events.c > @@ -124,13 +124,7 @@ bool cxl_event_insert(CXLDeviceState *cxlds, > } > > entry = g_new0(CXLEvent, 1); > - if (!entry) { > - error_report("Failed to allocate memory for event log entry"); > - return false; > - } > - > memcpy(&entry->data, event, sizeof(*event)); > - > entry->data.hdr.handle = cpu_to_le16(log->next_handle); > log->next_handle++; > /* 0 handle is never valid */ >