From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 104BAC05027 for ; Thu, 26 Jan 2023 14:52:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232372AbjAZOwi (ORCPT ); Thu, 26 Jan 2023 09:52:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232318AbjAZOwb (ORCPT ); Thu, 26 Jan 2023 09:52:31 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FDBB6B9AC; Thu, 26 Jan 2023 06:52:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8F39ACE24AD; Thu, 26 Jan 2023 14:52:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A51AC433D2; Thu, 26 Jan 2023 14:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674744722; bh=F9wPDL14DyENKQWHuzRKYw2D0Df71Uvt9kOe8yYjEdw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=fu9IRowp94gfxx7w4wpqN0NEj2N4k3iLexz/EWtyHQB8Xh/1iCvj019brhoPlhgck +2mPCLMrHoCEnZKfwkMmH0DY9SZHSSydjhSn7p1suflQQmI79Fldy5v+02PHVFI7wI 9gRDvybad8yvhkK/tmgZmEEsmw1+ExvNgc91cmtn8T11LKf7x+CzbBGOmqHimdiuuj cyD62OMNky7AbGlsH8YM9h/Fa4K/b3h+12lZvsNCMd4UYr8LgqKdWPc/lANtud22Dx j7kAKqy1BdewPyCFBDOCJGC0SiDocSB2cdH5WaPHILZjsPGor/ihQ8c5r8CGRegD2o fFPMosSs55+9Q== Date: Thu, 26 Jan 2023 08:52:00 -0600 From: Bjorn Helgaas To: Rick Wertenbroek Cc: alberto.dassatti@heig-vd.ch, xxm@rock-chips.com, wenrui.li@rock-chips.com, rick.wertenbroek@heig-vd.ch, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Jani Nikula , Greg Kroah-Hartman , Rodrigo Vivi , Mikko Kovanen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/8] PCI: rockchip: Fix PCIe endpoint controller driver Message-ID: <20230126145200.GA1270846@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230126135049.708524-1-rick.wertenbroek@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rick, Thanks very much for your work. On Thu, Jan 26, 2023 at 02:50:40PM +0100, Rick Wertenbroek wrote: > This is a series of patches that fixes the PCIe endpoint controller driver > for the Rockchip RK3399 SoC. It is based on Linux kernel 6.0.19 > > The original driver in mainline had issues and would not allow for the > RK3399 to operate in PCIe endpoint mode. This patch series fixes that so > that the PCIe core controller of the RK3399 SoC can now act as a PCIe > endpoint. So we merged cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") when it actually didn't work? Ouch. Thanks for fixing it and testing it. > Rick Wertenbroek (8): > PCI: rockchip: Removed writes to unused registers > PCI: rockchip: Fixed setup of Device ID > PCI: rockchip: Fixed endpoint controller Configuration Request Retry > Status > PCI: rockchip: Added poll and timeout to wait for PHY PLLs to be > locked > PCI: rockchip: Added dtsi entry for PCIe endpoint controller > PCI: rockchip: Fixed window mapping and address translation for > endpoint > PCI: rockchip: Fixed legacy IRQ generation for endpoint > PCI: rockchip: Fixed MSI generation from PCIe endpoint core For the next iteration, can you please update these subject lines and commit logs to: - Use imperative mood, i.e., read like a command, instead of a past tense description of what was done. For example, say "Remove writes to unused registers" instead of "Removed writes ..." - Be more specific when possible. "Fix" conveys no information about the actual code change. For example, "Fixed endpoint controller Configuration Request Retry Status" gives a general idea, but it would be more useful if it said something about clearing config mode after probe. - Say what the patch does in the commit log. The current ones often describe a *problem*, but do not explicitly say what the patch does. The commit log should be complete in itself even without the subject line, so it usually contains a slightly expanded version of the subject line. - Split patches that do more than one logical thing. The commit log for "Fixed MSI generation ..." talks about a u16/u32 shift issue, but the patch also adds an unrelated check for multi-function devices. - If a patch is a fix for an existing issue and may need to be backported, identify the commit that introduced the issue and add "Fixes: " lines. This helps distros figure out whether and how far to backport patches. - Refer to the device consistently. I see: RK3399 PCI EP core RK3399 SoC PCIe EP core RK3399 PCIe endpoint core I vote for "RK3399 PCIe Endpoint core". Notes about imperative mood: https://chris.beams.io/posts/git-commit/ https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.0#n94 > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 25 ++++ > drivers/pci/controller/pcie-rockchip-ep.c | 149 +++++++++++----------- > drivers/pci/controller/pcie-rockchip.c | 16 +++ > drivers/pci/controller/pcie-rockchip.h | 36 ++++-- > 4 files changed, 137 insertions(+), 89 deletions(-) > > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81FE2C54E94 for ; Thu, 26 Jan 2023 15:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=i73+o5LviyFOZhkixI31bGmdVcAFtRD1t1zGRnyBwkY=; b=ye38E8GbHtNGJJ ztA72mxGPxKaohO9UU3MJCZkBePPe0YiIr6b9eSHWsOiiqnndxS8AfnaCHnUB5wFQ98PYFQv4mke9 iojSogHJZpRgryE9ra7WJb0KIKjgrS513Y7pgbh55lwemiNtQ5v/VwnfcB6vXWFgW7k/9B53v3tt6 pV2FwPBRqubSHtuKXdN6tzzqTtt+zKbPv0jU0/q+prgoD6MMT/Em+y8XipO3wJ0GtrYnqGFdAefCG Gz4BVS00BePmPYuj9WGmgpdxP3NK36bQb1h9lJgMUfBwg0etu6QU74PZLqARMzFyp6h6iMDDifjPi 44iwJqrHzRI972eTHTEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL3jW-00BLsp-Tj; Thu, 26 Jan 2023 15:00:10 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL3bh-00BIqQ-Cl; Thu, 26 Jan 2023 14:52:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E425CB81DEF; Thu, 26 Jan 2023 14:52:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A51AC433D2; Thu, 26 Jan 2023 14:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674744722; bh=F9wPDL14DyENKQWHuzRKYw2D0Df71Uvt9kOe8yYjEdw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=fu9IRowp94gfxx7w4wpqN0NEj2N4k3iLexz/EWtyHQB8Xh/1iCvj019brhoPlhgck +2mPCLMrHoCEnZKfwkMmH0DY9SZHSSydjhSn7p1suflQQmI79Fldy5v+02PHVFI7wI 9gRDvybad8yvhkK/tmgZmEEsmw1+ExvNgc91cmtn8T11LKf7x+CzbBGOmqHimdiuuj cyD62OMNky7AbGlsH8YM9h/Fa4K/b3h+12lZvsNCMd4UYr8LgqKdWPc/lANtud22Dx j7kAKqy1BdewPyCFBDOCJGC0SiDocSB2cdH5WaPHILZjsPGor/ihQ8c5r8CGRegD2o fFPMosSs55+9Q== Date: Thu, 26 Jan 2023 08:52:00 -0600 From: Bjorn Helgaas To: Rick Wertenbroek Cc: alberto.dassatti@heig-vd.ch, xxm@rock-chips.com, wenrui.li@rock-chips.com, rick.wertenbroek@heig-vd.ch, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Jani Nikula , Greg Kroah-Hartman , Rodrigo Vivi , Mikko Kovanen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/8] PCI: rockchip: Fix PCIe endpoint controller driver Message-ID: <20230126145200.GA1270846@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230126135049.708524-1-rick.wertenbroek@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_065205_816304_CFF4BDE4 X-CRM114-Status: GOOD ( 31.93 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Rick, Thanks very much for your work. On Thu, Jan 26, 2023 at 02:50:40PM +0100, Rick Wertenbroek wrote: > This is a series of patches that fixes the PCIe endpoint controller driver > for the Rockchip RK3399 SoC. It is based on Linux kernel 6.0.19 > > The original driver in mainline had issues and would not allow for the > RK3399 to operate in PCIe endpoint mode. This patch series fixes that so > that the PCIe core controller of the RK3399 SoC can now act as a PCIe > endpoint. So we merged cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") when it actually didn't work? Ouch. Thanks for fixing it and testing it. > Rick Wertenbroek (8): > PCI: rockchip: Removed writes to unused registers > PCI: rockchip: Fixed setup of Device ID > PCI: rockchip: Fixed endpoint controller Configuration Request Retry > Status > PCI: rockchip: Added poll and timeout to wait for PHY PLLs to be > locked > PCI: rockchip: Added dtsi entry for PCIe endpoint controller > PCI: rockchip: Fixed window mapping and address translation for > endpoint > PCI: rockchip: Fixed legacy IRQ generation for endpoint > PCI: rockchip: Fixed MSI generation from PCIe endpoint core For the next iteration, can you please update these subject lines and commit logs to: - Use imperative mood, i.e., read like a command, instead of a past tense description of what was done. For example, say "Remove writes to unused registers" instead of "Removed writes ..." - Be more specific when possible. "Fix" conveys no information about the actual code change. For example, "Fixed endpoint controller Configuration Request Retry Status" gives a general idea, but it would be more useful if it said something about clearing config mode after probe. - Say what the patch does in the commit log. The current ones often describe a *problem*, but do not explicitly say what the patch does. The commit log should be complete in itself even without the subject line, so it usually contains a slightly expanded version of the subject line. - Split patches that do more than one logical thing. The commit log for "Fixed MSI generation ..." talks about a u16/u32 shift issue, but the patch also adds an unrelated check for multi-function devices. - If a patch is a fix for an existing issue and may need to be backported, identify the commit that introduced the issue and add "Fixes: " lines. This helps distros figure out whether and how far to backport patches. - Refer to the device consistently. I see: RK3399 PCI EP core RK3399 SoC PCIe EP core RK3399 PCIe endpoint core I vote for "RK3399 PCIe Endpoint core". Notes about imperative mood: https://chris.beams.io/posts/git-commit/ https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.0#n94 > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 25 ++++ > drivers/pci/controller/pcie-rockchip-ep.c | 149 +++++++++++----------- > drivers/pci/controller/pcie-rockchip.c | 16 +++ > drivers/pci/controller/pcie-rockchip.h | 36 ++++-- > 4 files changed, 137 insertions(+), 89 deletions(-) > > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 482D4C61D97 for ; Thu, 26 Jan 2023 15:00:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=f/ks41M+yJJ0Z+qRPOcJo9FgRSpjb4sU8moTjPPQdTw=; b=etO3oyvcspWapM Wr/fqByJH08uY2+IPmDbrzXP4UPsMb5CzRzqOePqVxRRLDCDqDs5wKqFY1D9VbJR6arw28AdPQD7+ wZ6fvgnG1J9T2Q6dw3LPaq+yCqfBhlqueh1u45wMBUx+XSVPLY9zr/eOq+HSIAI7pHepyl10WTqgy uAygaWGeNKm6QVocNUhXHtWBfYI2JUKiqtbKokiV8f+3WfuAgn3JOapaiexoXJK58Ne7NxVUHJrce lNsnVzHxubIFm34mSRaS2AbaEsCs9tJHqa7bOI96hWetVW1DRoX+rqSISyfioIO219N6VfpJF0Gln a1XoBYoffAJfohg4F6/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL3iN-00BLMy-Ng; Thu, 26 Jan 2023 14:59:00 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL3bh-00BIqQ-Cl; Thu, 26 Jan 2023 14:52:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E425CB81DEF; Thu, 26 Jan 2023 14:52:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A51AC433D2; Thu, 26 Jan 2023 14:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674744722; bh=F9wPDL14DyENKQWHuzRKYw2D0Df71Uvt9kOe8yYjEdw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=fu9IRowp94gfxx7w4wpqN0NEj2N4k3iLexz/EWtyHQB8Xh/1iCvj019brhoPlhgck +2mPCLMrHoCEnZKfwkMmH0DY9SZHSSydjhSn7p1suflQQmI79Fldy5v+02PHVFI7wI 9gRDvybad8yvhkK/tmgZmEEsmw1+ExvNgc91cmtn8T11LKf7x+CzbBGOmqHimdiuuj cyD62OMNky7AbGlsH8YM9h/Fa4K/b3h+12lZvsNCMd4UYr8LgqKdWPc/lANtud22Dx j7kAKqy1BdewPyCFBDOCJGC0SiDocSB2cdH5WaPHILZjsPGor/ihQ8c5r8CGRegD2o fFPMosSs55+9Q== Date: Thu, 26 Jan 2023 08:52:00 -0600 From: Bjorn Helgaas To: Rick Wertenbroek Cc: alberto.dassatti@heig-vd.ch, xxm@rock-chips.com, wenrui.li@rock-chips.com, rick.wertenbroek@heig-vd.ch, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Jani Nikula , Greg Kroah-Hartman , Rodrigo Vivi , Mikko Kovanen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/8] PCI: rockchip: Fix PCIe endpoint controller driver Message-ID: <20230126145200.GA1270846@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230126135049.708524-1-rick.wertenbroek@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_065205_816304_CFF4BDE4 X-CRM114-Status: GOOD ( 31.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rick, Thanks very much for your work. On Thu, Jan 26, 2023 at 02:50:40PM +0100, Rick Wertenbroek wrote: > This is a series of patches that fixes the PCIe endpoint controller driver > for the Rockchip RK3399 SoC. It is based on Linux kernel 6.0.19 > > The original driver in mainline had issues and would not allow for the > RK3399 to operate in PCIe endpoint mode. This patch series fixes that so > that the PCIe core controller of the RK3399 SoC can now act as a PCIe > endpoint. So we merged cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") when it actually didn't work? Ouch. Thanks for fixing it and testing it. > Rick Wertenbroek (8): > PCI: rockchip: Removed writes to unused registers > PCI: rockchip: Fixed setup of Device ID > PCI: rockchip: Fixed endpoint controller Configuration Request Retry > Status > PCI: rockchip: Added poll and timeout to wait for PHY PLLs to be > locked > PCI: rockchip: Added dtsi entry for PCIe endpoint controller > PCI: rockchip: Fixed window mapping and address translation for > endpoint > PCI: rockchip: Fixed legacy IRQ generation for endpoint > PCI: rockchip: Fixed MSI generation from PCIe endpoint core For the next iteration, can you please update these subject lines and commit logs to: - Use imperative mood, i.e., read like a command, instead of a past tense description of what was done. For example, say "Remove writes to unused registers" instead of "Removed writes ..." - Be more specific when possible. "Fix" conveys no information about the actual code change. For example, "Fixed endpoint controller Configuration Request Retry Status" gives a general idea, but it would be more useful if it said something about clearing config mode after probe. - Say what the patch does in the commit log. The current ones often describe a *problem*, but do not explicitly say what the patch does. The commit log should be complete in itself even without the subject line, so it usually contains a slightly expanded version of the subject line. - Split patches that do more than one logical thing. The commit log for "Fixed MSI generation ..." talks about a u16/u32 shift issue, but the patch also adds an unrelated check for multi-function devices. - If a patch is a fix for an existing issue and may need to be backported, identify the commit that introduced the issue and add "Fixes: " lines. This helps distros figure out whether and how far to backport patches. - Refer to the device consistently. I see: RK3399 PCI EP core RK3399 SoC PCIe EP core RK3399 PCIe endpoint core I vote for "RK3399 PCIe Endpoint core". Notes about imperative mood: https://chris.beams.io/posts/git-commit/ https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.0#n94 > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 25 ++++ > drivers/pci/controller/pcie-rockchip-ep.c | 149 +++++++++++----------- > drivers/pci/controller/pcie-rockchip.c | 16 +++ > drivers/pci/controller/pcie-rockchip.h | 36 ++++-- > 4 files changed, 137 insertions(+), 89 deletions(-) > > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel