From: Krister Johansen <kjlx@templeofstupid.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Juergen Gross" <jgross@suse.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"David Reaver" <me@davidreaver.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] xen/x86: public: add TSC defines for cpuid leaf 4
Date: Thu, 26 Jan 2023 09:54:51 -0800 [thread overview]
Message-ID: <20230126175451.GA1959@templeofstupid.com> (raw)
In-Reply-To: <8a07d6f8-a07a-d435-deef-1366fad29a11@suse.com>
On Thu, Jan 26, 2023 at 09:57:43AM +0100, Jan Beulich wrote:
> On 25.01.2023 19:45, Krister Johansen wrote:
> > v2:
> > - Fix whitespace between comment and #defines (feedback from Jan Beulich)
>
> Hmm, ...
>
> > --- a/xen/include/public/arch-x86/cpuid.h
> > +++ b/xen/include/public/arch-x86/cpuid.h
> > @@ -72,6 +72,14 @@
> > * Sub-leaf 2: EAX: host tsc frequency in kHz
> > */
> >
> > +#define XEN_CPUID_TSC_EMULATED (1u << 0)
> > +#define XEN_CPUID_HOST_TSC_RELIABLE (1u << 1)
> > +#define XEN_CPUID_RDTSCP_INSTR_AVAIL (1u << 2)
> > +#define XEN_CPUID_TSC_MODE_DEFAULT (0)
> > +#define XEN_CPUID_TSC_MODE_EMULATE (1u)
> > +#define XEN_CPUID_TSC_MODE_NOEMULATE (2u)
> > +#define XEN_CPUID_TSC_MODE_NOEMULATE_TSC_AUX (3u)
>
> ... while I'm fine with the leading blank line, what my earlier comment was
> about really are the two separate blocks of #define-s (the flag bits and the
> modes). I'll take care of this while committing; with the adjustment
>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
Sorry I miunderstood, and thanks for being willing to fix this up
while committing.
-K
next prev parent reply other threads:[~2023-01-26 17:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 22:35 [PATCH] xen/x86: public: add TSC defines for cpuid leaf 4 Krister Johansen
2023-01-25 6:57 ` Jan Beulich
2023-01-25 18:31 ` Krister Johansen
2023-01-25 18:45 ` [PATCH v2] " Krister Johansen
2023-01-26 8:57 ` Jan Beulich
2023-01-26 17:54 ` Krister Johansen [this message]
2023-01-26 9:57 ` Jan Beulich
2023-01-26 18:02 ` Krister Johansen
2023-01-27 7:16 ` Jan Beulich
2023-01-27 18:37 ` Krister Johansen
2023-01-27 18:51 ` [PATCH v3] " Krister Johansen
2023-01-30 8:22 ` Jan Beulich
2023-01-30 17:43 ` Krister Johansen
2023-01-30 17:44 ` [PATCH v4] " Krister Johansen
2023-01-31 8:42 ` Jan Beulich
2023-01-24 22:35 [PATCH] perf/util: Symbol lookup can fail if multiple segmets match stext Krister Johansen
2023-01-25 18:33 ` [PATCH v2] xen/x86: public: add TSC defines for cpuid leaf 4 Krister Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126175451.GA1959@templeofstupid.com \
--to=kjlx@templeofstupid.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=me@davidreaver.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.