[PATCH] wifi: ath6kl: reduce WARN to dev_dbg() in callback

* [PATCH] wifi: ath6kl: reduce WARN to dev_dbg() in callback
@ 2023-01-26 18:24 Fedor Pchelkin
  2023-02-27 12:19 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Fedor Pchelkin @ 2023-01-26 18:24 UTC (permalink / raw)
  To: Kalle Valo
  Cc: Fedor Pchelkin, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Alexey Khoroshilov, Oliver Neukum,
	Mohammed Shafi Shajakhan, linux-wireless, netdev, linux-kernel,
	lvc-project, syzbot+555908813b2ea35dae9a

The warn is triggered on a known race condition that is correctly handled.
Using WARN() hinders automated testing. Reducing severity.

Fixes: de2070fc4aa7 ("ath6kl: Fix kernel panic on continuous driver load/unload")
Reported-and-tested-by: syzbot+555908813b2ea35dae9a@syzkaller.appspotmail.com
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 drivers/net/wireless/ath/ath6kl/htc_pipe.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/htc_pipe.c b/drivers/net/wireless/ath/ath6kl/htc_pipe.c
index c68848819a52..9b88d96bfe96 100644
--- a/drivers/net/wireless/ath/ath6kl/htc_pipe.c
+++ b/drivers/net/wireless/ath/ath6kl/htc_pipe.c
@@ -960,8 +960,8 @@ static int ath6kl_htc_pipe_rx_complete(struct ath6kl *ar, struct sk_buff *skb,
 	 * Thus the possibility of ar->htc_target being NULL
 	 * via ath6kl_recv_complete -> ath6kl_usb_io_comp_work.
 	 */
-	if (WARN_ON_ONCE(!target)) {
-		ath6kl_err("Target not yet initialized\n");
+	if (!target) {
+		ath6kl_dbg(ATH6KL_DBG_HTC, "Target not yet initialized\n");
 		status = -EINVAL;
 		goto free_skb;
 	}
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread