From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B82D9C61D97 for ; Fri, 27 Jan 2023 00:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231992AbjA0ALt (ORCPT ); Thu, 26 Jan 2023 19:11:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232241AbjA0ALs (ORCPT ); Thu, 26 Jan 2023 19:11:48 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C060970D7E for ; Thu, 26 Jan 2023 16:11:45 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id 2-20020a250b02000000b0080b9a77383fso3674797ybl.22 for ; Thu, 26 Jan 2023 16:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=h6fKpqor2jTotXSn3372bFcG4CpzS45+gNVV/kwVyH8=; b=T8nzXdhvva6D8ItxjLauAJb7Lyid2FP9CiV7mBEHmzqXkhpihBiea+Ioio0cAu8xfk 38uctdNEzdnoayDngTT6u5jAB3K9SyCqO69ZHzu6SQIT4G1/4H8n5lUhteIFoEcLkrd/ NC7bGETX0A7PnfR5ScrGUjnQD80Sz0m7kXCTUVUqTJKM5nBtRvjssVXvElskyh9nOA5B kSA2Howr4hDZAHM9Lbx9b8nMy3QluBCPXDiZJRb7hYpVpwWoEHcmduWXSpIpEiJh192d rm10BYlry79ywPtc9qUZQs6Ng4FGlUz3MjWb+CD/PKIna5stlSnhXFhB/d+N00jJdvc2 wtTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=h6fKpqor2jTotXSn3372bFcG4CpzS45+gNVV/kwVyH8=; b=imjIvpv6cVqwG/rnmbs3I+0dAXE3xaDgX5OQ+gT5WvJCGnC5vyrkjM9gkIQLK8A2I8 jX4WeY6cRl/pD0wEb2XRav2D6FgTN4pBOCFkUCkMDnp23O8TdUcQwZf+8YNewXdLHqGd cV4t8nsDr2ZlmDhY1pjyEWAXYTzAwGTsdkebnYRN5ro995UBWlJL0DSDmS19oUvhO6uF I0kU1CqZTyTqWxBwX6WnzsYYhsszh+YpXyXwKH2wZ9SEA35JnslLdPtJKx8BKAw1uvyH AV13rsrrnGMn7vmi4TcvzmS6XOfwLzm3a/b2+DYslnffamBS3M+hMoCv/AnlgCqkbMjS txNQ== X-Gm-Message-State: AO0yUKWLnk/C9fcCqCPW6vcg6wwrYLGrM8pAfzGrufZUeBdMx1SD9bxa G2/hHqKoBV2zvdw4Gt+pIcglLWbBXSluxo0= X-Google-Smtp-Source: AK7set8HC3iQRXqsprtDAE3CdIOQ7dDgidlu4bwwuFWNlmxmQapx1Ya/7QpSiTTdct3N5H90xaY9cR/X6RtO3kA= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:c3b4:8b1c:e3ee:3708]) (user=saravanak job=sendgmr) by 2002:a25:df86:0:b0:80b:7fa3:d33f with SMTP id w128-20020a25df86000000b0080b7fa3d33fmr1197459ybg.599.1674778304965; Thu, 26 Jan 2023 16:11:44 -0800 (PST) Date: Thu, 26 Jan 2023 16:11:27 -0800 Message-Id: <20230127001141.407071-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.39.1.456.gfc5497dd1b-goog Subject: [PATCH v2 00/11] fw_devlink improvements From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Saravana Kannan Cc: Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org This patch series improves fw_devlink in the following ways: 1. It no longer cares about a fwnode having a "compatible" property. It figures this our more dynamically. The only expectation is that fwnode that are converted to devices actually get probed by a driver for the dependencies to be enforced correctly. 2. Finer grained dependency tracking. fw_devlink will now create device links from the consumer to the actual resource's device (if it has one, Eg: gpio_device) instead of the parent supplier device. This improves things like async suspend/resume ordering, potentially remove the need for frameworks to create device links, more parallelized async probing, and better sync_state() tracking. 3. Handle hardware/software quirks where a child firmware node gets populated as a device before its parent firmware node AND actually supplies a non-optional resource to the parent firmware node's device. 4. Way more robust at cycle handling (see patch for the insane cases). 5. Stops depending on OF_POPULATED to figure out some corner cases. 6. Simplifies the work that needs to be done by the firmware specific code. Sorry it took a while to roll in the fixes I gave in the v1 series thread[1] into a v2 series. Since I didn't make any additional changes on top of what I already gave in the v1 thread and Dmitry is very eager to get this series going, I'm sending it out without testing locally. I already tested these patches a few months ago as part of the v1 series. So I don't expect any major issues. I'll test them again on my end in the next few days and will report here if I actually find anything wrong. Tony, Naresh, Abel, Sudeep, Geert, I got the following reviewed by's and tested by's a few months back, but it's been 5 months since I sent out v1. So I wasn't sure if it was okay to include them in the v2 commits. Let me know if you are okay with this being included in the commits and/or if you want to test this series again. Reviewed-by: Tony Lindgren Tested-by: Tony Lindgren Tested-by: Linux Kernel Functional Testing Tested-by: Naresh Kamboju Tested-by: Abel Vesa Tested-by: Sudeep Holla Tested-by: Geert Uytterhoeven Dmitry, Maxim(s), Miquel, Luca, Doug, Colin, Martin, Jean-Philippe, I've Cc-ed you because I had pointed you to v1 of this series + the patches in that thread at one point or another as a fix to some issue you were facing. It'd appreciate it if you can test this series and report any issues, or things it fixed and give Tested-bys. In addition, if you can also apply a revert of this series[2] and delete driver_deferred_probe_check_state() from your tree and see if you hit any issues and report them, that'd be great too! I'm pretty sure some of you will hit issues with that. I want to fix those next and then revert[2]. Thanks, Saravana [1] - https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@google.com/ [2] - https://lore.kernel.org/lkml/20220819221616.2107893-1-saravanak@google.com/ [3] - https://lore.kernel.org/lkml/CAGETcx-JUV1nj8wBJrTPfyvM7=Mre5j_vkVmZojeiumUGG6QZQ@mail.gmail.com/ v1 -> v2: - Fixed Patch 1 to handle a corner case discussed in [3]. - New patch 10 to handle "fsl,imx8mq-gpc" being initialized by 2 drivers. - New patch 11 to add fw_devlink support for SCMI devices. Cc: Abel Vesa Cc: Alexander Stein Cc: Tony Lindgren Cc: Sudeep Holla Cc: Geert Uytterhoeven Cc: John Stultz Cc: Doug Anderson Cc: Guenter Roeck Cc: Dmitry Baryshkov Cc: Maxim Kiselev Cc: Maxim Kochetkov Cc: Miquel Raynal Cc: Luca Weiss Cc: Colin Foster Cc: Martin Kepplinger Cc: Jean-Philippe Brucker Saravana Kannan (11): driver core: fw_devlink: Don't purge child fwnode's consumer links driver core: fw_devlink: Improve check for fwnode with no device/driver soc: renesas: Move away from using OF_POPULATED for fw_devlink gpiolib: Clear the gpio_device's fwnode initialized flag before adding driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links driver core: fw_devlink: Allow marking a fwnode link as being part of a cycle driver core: fw_devlink: Consolidate device link flag computation driver core: fw_devlink: Make cycle detection more robust of: property: Simplify of_link_to_phandle() irqchip/irq-imx-gpcv2: Mark fwnode device as not initialized firmware: arm_scmi: Set fwnode for the scmi_device drivers/base/core.c | 443 +++++++++++++++++++++----------- drivers/firmware/arm_scmi/bus.c | 2 + drivers/gpio/gpiolib.c | 6 + drivers/irqchip/irq-imx-gpcv2.c | 1 + drivers/of/property.c | 84 +----- drivers/soc/imx/gpcv2.c | 1 + drivers/soc/renesas/rcar-sysc.c | 2 +- include/linux/device.h | 1 + include/linux/fwnode.h | 12 +- 9 files changed, 332 insertions(+), 220 deletions(-) -- 2.39.1.456.gfc5497dd1b-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C25DC61DA7 for ; Fri, 27 Jan 2023 00:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Mime-Version: Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=gCNvTwVJ3w1ZGFXPMiaCFVlKwlfwHgWZEkTWiFNOfds=; b=Zna WIw4JDXnip6SGBLtnXWBkFxzdJbmy59/gvel4ko4tY5td2KfAj3Rhb8ezfpDb9w1MlQFqCQZUCkeQ DXbEhfStN4cEAqpGOccYlcQ16Pn9P/pB1n1IPRrLuMGO4GsShQKLgGPltE/XIyHxeJfRykGY6KwcL ERaFuQ53Uk1ZQNDpT0ORt/A+5GJ9jB7MzKRlBT1xqiSLUlm8YPJA+EVmuhdtsbwA1kaZmp5Mlsyxz DbQcfv+YV/3a5IEb4+0RXkaONgLSA4nE6lDIamy26MISbX/3ziY4tWYvOlm/UM/ZbV7NUi6BuHqKI 7OPuGGYivDwGfr0o97c7qyDLUf5Y6Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLCLN-00CuGk-U8; Fri, 27 Jan 2023 00:11:50 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLCLK-00CuFE-QL for linux-arm-kernel@lists.infradead.org; Fri, 27 Jan 2023 00:11:48 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id b201-20020a2534d2000000b0080b87d910a2so3680050yba.21 for ; Thu, 26 Jan 2023 16:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=h6fKpqor2jTotXSn3372bFcG4CpzS45+gNVV/kwVyH8=; b=T8nzXdhvva6D8ItxjLauAJb7Lyid2FP9CiV7mBEHmzqXkhpihBiea+Ioio0cAu8xfk 38uctdNEzdnoayDngTT6u5jAB3K9SyCqO69ZHzu6SQIT4G1/4H8n5lUhteIFoEcLkrd/ NC7bGETX0A7PnfR5ScrGUjnQD80Sz0m7kXCTUVUqTJKM5nBtRvjssVXvElskyh9nOA5B kSA2Howr4hDZAHM9Lbx9b8nMy3QluBCPXDiZJRb7hYpVpwWoEHcmduWXSpIpEiJh192d rm10BYlry79ywPtc9qUZQs6Ng4FGlUz3MjWb+CD/PKIna5stlSnhXFhB/d+N00jJdvc2 wtTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=h6fKpqor2jTotXSn3372bFcG4CpzS45+gNVV/kwVyH8=; b=YuvauYnohQBhJuc6r7u1dfqKHBrrIUnTW5egQXbdUe8zcUvaQyLYpQ+NJXxU+CjyNE hOaQOPR15SzcScvTE/0WVQjWWUPeLlxiRkJ0p6DAqNwI6ng3b9QF+YvjnN9ZRdnG8CI7 RHrHPcxkb8Nif0AfP/rDHXykPTc/yPNvkQKXUjhTbM57syoSbhqDamEFAbCMwQ2zWMq8 yUmhRVK4ZDsJBasbpppf1aZ8ettlBGekhBbwmD5VL4eAyFgt5RkS2K/tm1eTSRtcJ10B 7FFRGkrEtgnTujNHBn2dA7lIuegZ/ojghE6RbpS3jnB0v/0LFHWj3tDhlqCqLavGk/R5 RR2A== X-Gm-Message-State: AO0yUKVIKOykq5yn6qyNXCpa8/zEY9Dk9yyebsdwzYtrqNOWaPyV7bcS 5N2stsFv/j5qdTTYyltqsoU4QYYj6UQdRcQ= X-Google-Smtp-Source: AK7set8HC3iQRXqsprtDAE3CdIOQ7dDgidlu4bwwuFWNlmxmQapx1Ya/7QpSiTTdct3N5H90xaY9cR/X6RtO3kA= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:c3b4:8b1c:e3ee:3708]) (user=saravanak job=sendgmr) by 2002:a25:df86:0:b0:80b:7fa3:d33f with SMTP id w128-20020a25df86000000b0080b7fa3d33fmr1197459ybg.599.1674778304965; Thu, 26 Jan 2023 16:11:44 -0800 (PST) Date: Thu, 26 Jan 2023 16:11:27 -0800 Message-Id: <20230127001141.407071-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.39.1.456.gfc5497dd1b-goog Subject: [PATCH v2 00/11] fw_devlink improvements From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Saravana Kannan Cc: Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_161146_924153_02A2855F X-CRM114-Status: GOOD ( 25.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This patch series improves fw_devlink in the following ways: 1. It no longer cares about a fwnode having a "compatible" property. It figures this our more dynamically. The only expectation is that fwnode that are converted to devices actually get probed by a driver for the dependencies to be enforced correctly. 2. Finer grained dependency tracking. fw_devlink will now create device links from the consumer to the actual resource's device (if it has one, Eg: gpio_device) instead of the parent supplier device. This improves things like async suspend/resume ordering, potentially remove the need for frameworks to create device links, more parallelized async probing, and better sync_state() tracking. 3. Handle hardware/software quirks where a child firmware node gets populated as a device before its parent firmware node AND actually supplies a non-optional resource to the parent firmware node's device. 4. Way more robust at cycle handling (see patch for the insane cases). 5. Stops depending on OF_POPULATED to figure out some corner cases. 6. Simplifies the work that needs to be done by the firmware specific code. Sorry it took a while to roll in the fixes I gave in the v1 series thread[1] into a v2 series. Since I didn't make any additional changes on top of what I already gave in the v1 thread and Dmitry is very eager to get this series going, I'm sending it out without testing locally. I already tested these patches a few months ago as part of the v1 series. So I don't expect any major issues. I'll test them again on my end in the next few days and will report here if I actually find anything wrong. Tony, Naresh, Abel, Sudeep, Geert, I got the following reviewed by's and tested by's a few months back, but it's been 5 months since I sent out v1. So I wasn't sure if it was okay to include them in the v2 commits. Let me know if you are okay with this being included in the commits and/or if you want to test this series again. Reviewed-by: Tony Lindgren Tested-by: Tony Lindgren Tested-by: Linux Kernel Functional Testing Tested-by: Naresh Kamboju Tested-by: Abel Vesa Tested-by: Sudeep Holla Tested-by: Geert Uytterhoeven Dmitry, Maxim(s), Miquel, Luca, Doug, Colin, Martin, Jean-Philippe, I've Cc-ed you because I had pointed you to v1 of this series + the patches in that thread at one point or another as a fix to some issue you were facing. It'd appreciate it if you can test this series and report any issues, or things it fixed and give Tested-bys. In addition, if you can also apply a revert of this series[2] and delete driver_deferred_probe_check_state() from your tree and see if you hit any issues and report them, that'd be great too! I'm pretty sure some of you will hit issues with that. I want to fix those next and then revert[2]. Thanks, Saravana [1] - https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@google.com/ [2] - https://lore.kernel.org/lkml/20220819221616.2107893-1-saravanak@google.com/ [3] - https://lore.kernel.org/lkml/CAGETcx-JUV1nj8wBJrTPfyvM7=Mre5j_vkVmZojeiumUGG6QZQ@mail.gmail.com/ v1 -> v2: - Fixed Patch 1 to handle a corner case discussed in [3]. - New patch 10 to handle "fsl,imx8mq-gpc" being initialized by 2 drivers. - New patch 11 to add fw_devlink support for SCMI devices. Cc: Abel Vesa Cc: Alexander Stein Cc: Tony Lindgren Cc: Sudeep Holla Cc: Geert Uytterhoeven Cc: John Stultz Cc: Doug Anderson Cc: Guenter Roeck Cc: Dmitry Baryshkov Cc: Maxim Kiselev Cc: Maxim Kochetkov Cc: Miquel Raynal Cc: Luca Weiss Cc: Colin Foster Cc: Martin Kepplinger Cc: Jean-Philippe Brucker Saravana Kannan (11): driver core: fw_devlink: Don't purge child fwnode's consumer links driver core: fw_devlink: Improve check for fwnode with no device/driver soc: renesas: Move away from using OF_POPULATED for fw_devlink gpiolib: Clear the gpio_device's fwnode initialized flag before adding driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links driver core: fw_devlink: Allow marking a fwnode link as being part of a cycle driver core: fw_devlink: Consolidate device link flag computation driver core: fw_devlink: Make cycle detection more robust of: property: Simplify of_link_to_phandle() irqchip/irq-imx-gpcv2: Mark fwnode device as not initialized firmware: arm_scmi: Set fwnode for the scmi_device drivers/base/core.c | 443 +++++++++++++++++++++----------- drivers/firmware/arm_scmi/bus.c | 2 + drivers/gpio/gpiolib.c | 6 + drivers/irqchip/irq-imx-gpcv2.c | 1 + drivers/of/property.c | 84 +----- drivers/soc/imx/gpcv2.c | 1 + drivers/soc/renesas/rcar-sysc.c | 2 +- include/linux/device.h | 1 + include/linux/fwnode.h | 12 +- 9 files changed, 332 insertions(+), 220 deletions(-) -- 2.39.1.456.gfc5497dd1b-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel