From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3908428F2; Fri, 27 Jan 2023 11:39:52 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A44601576; Fri, 27 Jan 2023 03:40:33 -0800 (PST) Received: from ewhatever.cambridge.arm.com (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1E5433F64C; Fri, 27 Jan 2023 03:39:49 -0800 (PST) From: Suzuki K Poulose To: kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: suzuki.poulose@arm.com, Alexandru Elisei , Andrew Jones , Christoffer Dall , Fuad Tabba , Jean-Philippe Brucker , Joey Gouly , Marc Zyngier , Mark Rutland , Oliver Upton , Paolo Bonzini , Quentin Perret , Steven Price , Thomas Huth , Will Deacon , Zenghui Yu , linux-coco@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC kvmtool 01/31] arm64: Disable MTE when CFI flash is emulated Date: Fri, 27 Jan 2023 11:39:02 +0000 Message-Id: <20230127113932.166089-2-suzuki.poulose@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230127113932.166089-1-suzuki.poulose@arm.com> References: <20230127112248.136810-1-suzuki.poulose@arm.com> <20230127113932.166089-1-suzuki.poulose@arm.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit CFI Flash file image cannot be mapped into the memory of the guest if MTE is enabled. Thus disable MTE if flash emulation is requested. Signed-off-by: Suzuki K Poulose --- arm/aarch64/kvm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arm/aarch64/kvm.c b/arm/aarch64/kvm.c index 54200c9e..5a53badb 100644 --- a/arm/aarch64/kvm.c +++ b/arm/aarch64/kvm.c @@ -145,6 +145,12 @@ void kvm__arch_enable_mte(struct kvm *kvm) return; } + if (kvm->cfg.flash_filename) { + kvm->cfg.arch.mte_disabled = true; + pr_info("MTE is incompatible with CFI flash support, disabling"); + return; + } + if (kvm->cfg.arch.mte_disabled) { pr_debug("MTE disabled by user"); return; -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 713C6C38142 for ; Fri, 27 Jan 2023 11:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uj/NF0i+uI96Vlq7XLeode/0g1gs9P9gXO1SBUl3k8Q=; b=SWe8TIHBtXJK7E S/ZpwN53dWrQtZQcAjtCfSJ5QIl7oyzSZfZ/tSbmUeESTajQs+cpHiSbaMHSx3xcZKQBmpH/VFjow Z0YDsQ4sa3HxrkBvNiOsuMYwJJJccefYX4GaZwwq4S9fu/+2fsM2O/ooVilfvS4I/vjd/1urdgX40 moXdUC4xPGGL9e1WiAlzhPviHHhvCG7oQIv565mq4Q2uv/Av0Xt4rL1+9qal5Qe/gn0u+VzOSyr+x Vo7IwKT/vY/yRxxB9nuU1bLtvbri0YmZDlXuz5rzQPLZdHd6hKOG5xwzLQBbq1qDKRrbxy4/9vIWo aNAV9WooTrBO24CdhvWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLNNT-00ELCY-MI; Fri, 27 Jan 2023 11:58:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLN5F-00ECfn-1V for linux-arm-kernel@lists.infradead.org; Fri, 27 Jan 2023 11:39:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A44601576; Fri, 27 Jan 2023 03:40:33 -0800 (PST) Received: from ewhatever.cambridge.arm.com (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1E5433F64C; Fri, 27 Jan 2023 03:39:49 -0800 (PST) From: Suzuki K Poulose To: kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: suzuki.poulose@arm.com, Alexandru Elisei , Andrew Jones , Christoffer Dall , Fuad Tabba , Jean-Philippe Brucker , Joey Gouly , Marc Zyngier , Mark Rutland , Oliver Upton , Paolo Bonzini , Quentin Perret , Steven Price , Thomas Huth , Will Deacon , Zenghui Yu , linux-coco@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC kvmtool 01/31] arm64: Disable MTE when CFI flash is emulated Date: Fri, 27 Jan 2023 11:39:02 +0000 Message-Id: <20230127113932.166089-2-suzuki.poulose@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230127113932.166089-1-suzuki.poulose@arm.com> References: <20230127112248.136810-1-suzuki.poulose@arm.com> <20230127113932.166089-1-suzuki.poulose@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_033953_178118_0075953A X-CRM114-Status: UNSURE ( 8.53 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CFI Flash file image cannot be mapped into the memory of the guest if MTE is enabled. Thus disable MTE if flash emulation is requested. Signed-off-by: Suzuki K Poulose --- arm/aarch64/kvm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arm/aarch64/kvm.c b/arm/aarch64/kvm.c index 54200c9e..5a53badb 100644 --- a/arm/aarch64/kvm.c +++ b/arm/aarch64/kvm.c @@ -145,6 +145,12 @@ void kvm__arch_enable_mte(struct kvm *kvm) return; } + if (kvm->cfg.flash_filename) { + kvm->cfg.arch.mte_disabled = true; + pr_info("MTE is incompatible with CFI flash support, disabling"); + return; + } + if (kvm->cfg.arch.mte_disabled) { pr_debug("MTE disabled by user"); return; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel