[PATCH] bitbake.conf: Inject a dash into PN for BB_HASH_CODEPARSER_VALS

[PATCH] bitbake.conf: Inject a dash into PN for BB_HASH_CODEPARSER_VALS

[Richard Purdie]

We've had a couple of reports of recipes expecting to be able to call
split("-") on PN. There isn't any real harm in adding a dash to the dummy
PN value to avoid these errors.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 5aadf6e7078..530b068757b 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -959,7 +959,7 @@ BB_SIGNATURE_EXCLUDE_FLAGS ?= "doc deps depends \
     sstate-lockfile-shared prefuncs postfuncs export_func deptask rdeptask \
     recrdeptask nodeprrecs stamp-extra-info sstate-outputdirs filename lineno \
     progress mcdepends number_threads"
-BB_HASH_CODEPARSER_VALS = "LOGFIFO=/ T=/ WORKDIR=/ DATE=1234 TIME=1234 PV=0.0-1 PN=nopn METADATA_REVISION=1234"
+BB_HASH_CODEPARSER_VALS = "LOGFIFO=/ T=/ WORKDIR=/ DATE=1234 TIME=1234 PV=0.0-1 PN=no-pn METADATA_REVISION=1234"
 
 MLPREFIX ??= ""
 MULTILIB_VARIANTS ??= ""
-- 
2.37.2

Re: [OE-core] [PATCH] bitbake.conf: Inject a dash into PN for BB_HASH_CODEPARSER_VALS

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]

FWIW: this change doesn't help in the case I've reported earlier, because
the bbclass which was doing the split('-') was also checking that the
suffix was one of the supported values.

So I'll continue to use:
BB_HASH_CODEPARSER_VALS:remove = "PN=no-pn"
in that .bbclass.


On Fri, Jan 27, 2023 at 5:33 PM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> We've had a couple of reports of recipes expecting to be able to call
> split("-") on PN. There isn't any real harm in adding a dash to the dummy
> PN value to avoid these errors.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/conf/bitbake.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 5aadf6e7078..530b068757b 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -959,7 +959,7 @@ BB_SIGNATURE_EXCLUDE_FLAGS ?= "doc deps depends \
>      sstate-lockfile-shared prefuncs postfuncs export_func deptask
> rdeptask \
>      recrdeptask nodeprrecs stamp-extra-info sstate-outputdirs filename
> lineno \
>      progress mcdepends number_threads"
> -BB_HASH_CODEPARSER_VALS = "LOGFIFO=/ T=/ WORKDIR=/ DATE=1234 TIME=1234
> PV=0.0-1 PN=nopn METADATA_REVISION=1234"
> +BB_HASH_CODEPARSER_VALS = "LOGFIFO=/ T=/ WORKDIR=/ DATE=1234 TIME=1234
> PV=0.0-1 PN=no-pn METADATA_REVISION=1234"
>
>  MLPREFIX ??= ""
>  MULTILIB_VARIANTS ??= ""
> --
> 2.37.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#176452):
> https://lists.openembedded.org/g/openembedded-core/message/176452
> Mute This Topic: https://lists.openembedded.org/mt/96569450/3617156
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> Martin.Jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 2998 bytes --]