From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: replicant@osuosl.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
"Martin Jücker" <martin.juecker@gmail.com>,
"Henrik Grimler" <henrik@grimler.se>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 5/8] phy: samsung,mipi-video-phy: deprecate syscon phandle
Date: Fri, 27 Jan 2023 20:40:54 +0100 [thread overview]
Message-ID: <20230127194057.186458-6-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230127194057.186458-1-krzysztof.kozlowski@linaro.org>
The MIPI phy is actually part of the Power Management Unit system
controller, thus it should be its child, instead of sibling node with
syscon phandle.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/phy/samsung/phy-exynos-mipi-video.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/samsung/phy-exynos-mipi-video.c b/drivers/phy/samsung/phy-exynos-mipi-video.c
index c1df1ef3ee3c..a7f67857e5b2 100644
--- a/drivers/phy/samsung/phy-exynos-mipi-video.c
+++ b/drivers/phy/samsung/phy-exynos-mipi-video.c
@@ -298,7 +298,7 @@ static int exynos_mipi_video_phy_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct device_node *np = dev->of_node;
struct phy_provider *phy_provider;
- unsigned int i;
+ unsigned int i = 0;
phy_dev = of_device_get_match_data(dev);
if (!phy_dev)
@@ -308,7 +308,10 @@ static int exynos_mipi_video_phy_probe(struct platform_device *pdev)
if (!state)
return -ENOMEM;
- for (i = 0; i < phy_dev->num_regmaps; i++) {
+ state->regmaps[i] = syscon_node_to_regmap(dev->parent->of_node);
+ if (!IS_ERR(state->regmaps[i]))
+ i++;
+ for (; i < phy_dev->num_regmaps; i++) {
state->regmaps[i] = syscon_regmap_lookup_by_phandle(np,
phy_dev->regmap_names[i]);
if (IS_ERR(state->regmaps[i]))
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: replicant@osuosl.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
"Martin Jücker" <martin.juecker@gmail.com>,
"Henrik Grimler" <henrik@grimler.se>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 5/8] phy: samsung,mipi-video-phy: deprecate syscon phandle
Date: Fri, 27 Jan 2023 20:40:54 +0100 [thread overview]
Message-ID: <20230127194057.186458-6-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230127194057.186458-1-krzysztof.kozlowski@linaro.org>
The MIPI phy is actually part of the Power Management Unit system
controller, thus it should be its child, instead of sibling node with
syscon phandle.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/phy/samsung/phy-exynos-mipi-video.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/samsung/phy-exynos-mipi-video.c b/drivers/phy/samsung/phy-exynos-mipi-video.c
index c1df1ef3ee3c..a7f67857e5b2 100644
--- a/drivers/phy/samsung/phy-exynos-mipi-video.c
+++ b/drivers/phy/samsung/phy-exynos-mipi-video.c
@@ -298,7 +298,7 @@ static int exynos_mipi_video_phy_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct device_node *np = dev->of_node;
struct phy_provider *phy_provider;
- unsigned int i;
+ unsigned int i = 0;
phy_dev = of_device_get_match_data(dev);
if (!phy_dev)
@@ -308,7 +308,10 @@ static int exynos_mipi_video_phy_probe(struct platform_device *pdev)
if (!state)
return -ENOMEM;
- for (i = 0; i < phy_dev->num_regmaps; i++) {
+ state->regmaps[i] = syscon_node_to_regmap(dev->parent->of_node);
+ if (!IS_ERR(state->regmaps[i]))
+ i++;
+ for (; i < phy_dev->num_regmaps; i++) {
state->regmaps[i] = syscon_regmap_lookup_by_phandle(np,
phy_dev->regmap_names[i]);
if (IS_ERR(state->regmaps[i]))
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: replicant@osuosl.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
"Martin Jücker" <martin.juecker@gmail.com>,
"Henrik Grimler" <henrik@grimler.se>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 5/8] phy: samsung,mipi-video-phy: deprecate syscon phandle
Date: Fri, 27 Jan 2023 20:40:54 +0100 [thread overview]
Message-ID: <20230127194057.186458-6-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230127194057.186458-1-krzysztof.kozlowski@linaro.org>
The MIPI phy is actually part of the Power Management Unit system
controller, thus it should be its child, instead of sibling node with
syscon phandle.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/phy/samsung/phy-exynos-mipi-video.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/samsung/phy-exynos-mipi-video.c b/drivers/phy/samsung/phy-exynos-mipi-video.c
index c1df1ef3ee3c..a7f67857e5b2 100644
--- a/drivers/phy/samsung/phy-exynos-mipi-video.c
+++ b/drivers/phy/samsung/phy-exynos-mipi-video.c
@@ -298,7 +298,7 @@ static int exynos_mipi_video_phy_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct device_node *np = dev->of_node;
struct phy_provider *phy_provider;
- unsigned int i;
+ unsigned int i = 0;
phy_dev = of_device_get_match_data(dev);
if (!phy_dev)
@@ -308,7 +308,10 @@ static int exynos_mipi_video_phy_probe(struct platform_device *pdev)
if (!state)
return -ENOMEM;
- for (i = 0; i < phy_dev->num_regmaps; i++) {
+ state->regmaps[i] = syscon_node_to_regmap(dev->parent->of_node);
+ if (!IS_ERR(state->regmaps[i]))
+ i++;
+ for (; i < phy_dev->num_regmaps; i++) {
state->regmaps[i] = syscon_regmap_lookup_by_phandle(np,
phy_dev->regmap_names[i]);
if (IS_ERR(state->regmaps[i]))
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-01-27 19:42 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 19:40 [PATCH 0/8] dt-bindings: phy/samsung: move MIPI and DP phys under PMU Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 1/8] dt-bindings: soc: samsung: exynos-pmu: allow phys as child Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 21:23 ` Rob Herring
2023-01-27 21:23 ` Rob Herring
2023-01-27 21:23 ` Rob Herring
2023-01-29 10:40 ` (subset) " Krzysztof Kozlowski
2023-01-29 10:40 ` Krzysztof Kozlowski
2023-01-29 10:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 2/8] dt-bindings: phy: samsung,dp-video-phy: deprecate syscon phandle Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-30 21:15 ` Rob Herring
2023-01-30 21:15 ` Rob Herring
2023-01-30 21:15 ` Rob Herring
2023-01-31 17:32 ` Krzysztof Kozlowski
2023-01-31 17:32 ` Krzysztof Kozlowski
2023-01-31 17:32 ` Krzysztof Kozlowski
2023-02-03 13:38 ` Vinod Koul
2023-02-03 13:38 ` Vinod Koul
2023-02-03 13:38 ` Vinod Koul
2023-02-03 15:10 ` (subset) " Krzysztof Kozlowski
2023-02-03 15:10 ` Krzysztof Kozlowski
2023-02-03 15:10 ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 3/8] dt-bindings: phy: samsung,mipi-video-phy: " Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-30 21:16 ` Rob Herring
2023-01-30 21:16 ` Rob Herring
2023-02-03 15:10 ` (subset) " Krzysztof Kozlowski
2023-02-03 15:10 ` Krzysztof Kozlowski
2023-02-03 15:10 ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 4/8] phy: samsung,dp-video-phy: " Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-02-03 13:41 ` Vinod Koul
2023-02-03 13:41 ` Vinod Koul
2023-02-03 13:41 ` Vinod Koul
2023-02-03 15:10 ` (subset) " Krzysztof Kozlowski
2023-02-03 15:10 ` Krzysztof Kozlowski
2023-02-03 15:10 ` Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski [this message]
2023-01-27 19:40 ` [PATCH 5/8] phy: samsung,mipi-video-phy: " Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-02-03 13:42 ` Vinod Koul
2023-02-03 13:42 ` Vinod Koul
2023-02-03 13:42 ` Vinod Koul
2023-02-03 15:10 ` (subset) " Krzysztof Kozlowski
2023-02-03 15:10 ` Krzysztof Kozlowski
2023-02-03 15:10 ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 6/8] ARM: dts: exynos: move DP and MIPI phys to PMU node in Exynos5420 Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 22:54 ` Marek Szyprowski
2023-01-27 22:54 ` Marek Szyprowski
2023-01-27 22:54 ` Marek Szyprowski
2023-03-06 11:39 ` (subset) " Krzysztof Kozlowski
2023-03-06 11:39 ` Krzysztof Kozlowski
2023-03-06 11:39 ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 7/8] ARM: dts: exynos: move DP and MIPI phys to PMU node in Exynos5250 Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 22:53 ` Marek Szyprowski
2023-01-27 22:53 ` Marek Szyprowski
2023-01-27 22:53 ` Marek Szyprowski
2023-03-06 11:39 ` (subset) " Krzysztof Kozlowski
2023-03-06 11:39 ` Krzysztof Kozlowski
2023-03-06 11:39 ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 8/8] arm64: dts: exynos: move MIPI phy to PMU node in Exynos5433 Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 22:16 ` Marek Szyprowski
2023-01-27 22:16 ` Marek Szyprowski
2023-01-27 22:16 ` Marek Szyprowski
2023-03-06 11:39 ` (subset) " Krzysztof Kozlowski
2023-03-06 11:39 ` Krzysztof Kozlowski
2023-03-06 11:39 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127194057.186458-6-krzysztof.kozlowski@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.juecker@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=replicant@osuosl.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.