* [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()
@ 2023-01-28 8:11 ye.xingchen
2023-01-30 4:48 ` Dmitry Torokhov
2023-01-30 12:19 ` Andy Shevchenko
0 siblings, 2 replies; 3+ messages in thread
From: ye.xingchen @ 2023-01-28 8:11 UTC (permalink / raw)
To: dmitry.torokhov
Cc: andriy.shevchenko, jonathan.cameron, linux-input, linux-kernel
From: ye xingchen <ye.xingchen@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/input/keyboard/st-keyscan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/st-keyscan.c b/drivers/input/keyboard/st-keyscan.c
index 13735a5e8391..b6e83324f97a 100644
--- a/drivers/input/keyboard/st-keyscan.c
+++ b/drivers/input/keyboard/st-keyscan.c
@@ -125,7 +125,6 @@ static int keyscan_probe(struct platform_device *pdev)
{
struct st_keyscan *keypad_data;
struct input_dev *input_dev;
- struct resource *res;
int error;
if (!pdev->dev.of_node) {
@@ -169,8 +168,7 @@ static int keyscan_probe(struct platform_device *pdev)
input_set_drvdata(input_dev, keypad_data);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- keypad_data->base = devm_ioremap_resource(&pdev->dev, res);
+ keypad_data->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(keypad_data->base))
return PTR_ERR(keypad_data->base);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()
2023-01-28 8:11 [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource() ye.xingchen
@ 2023-01-30 4:48 ` Dmitry Torokhov
2023-01-30 12:19 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2023-01-30 4:48 UTC (permalink / raw)
To: ye.xingchen
Cc: andriy.shevchenko, jonathan.cameron, linux-input, linux-kernel
On Sat, Jan 28, 2023 at 04:11:30PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()
2023-01-28 8:11 [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-01-30 4:48 ` Dmitry Torokhov
@ 2023-01-30 12:19 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-01-30 12:19 UTC (permalink / raw)
To: ye.xingchen; +Cc: dmitry.torokhov, jonathan.cameron, linux-input, linux-kernel
On Sat, Jan 28, 2023 at 04:11:30PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
...
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - keypad_data->base = devm_ioremap_resource(&pdev->dev, res);
> + keypad_data->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
Why?
What we need here is simple devm_platform_ioremap_resource().
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-30 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 8:11 [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-01-30 4:48 ` Dmitry Torokhov
2023-01-30 12:19 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.