Re: [PATCH] cxl/pci: Set the device timestamp

From: kernel test robot <lkp@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	linux-cxl@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	linuxarm@huawei.com
Subject: Re: [PATCH] cxl/pci: Set the device timestamp
Date: Sun, 29 Jan 2023 00:01:04 +0800	[thread overview]
Message-ID: <202301282342.2ZTowY3a-lkp@intel.com> (raw)
In-Reply-To: <20230126180458.5145-1-Jonathan.Cameron@huawei.com>

Hi Jonathan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 172738bbccdb4ef76bdd72fc72a315c741c39161]

url:    https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cameron/cxl-pci-Set-the-device-timestamp/20230128-152300
base:   172738bbccdb4ef76bdd72fc72a315c741c39161
patch link:    https://lore.kernel.org/r/20230126180458.5145-1-Jonathan.Cameron%40huawei.com
patch subject: [PATCH] cxl/pci: Set the device timestamp
config: powerpc-randconfig-s032-20230123 (https://download.01.org/0day-ci/archive/20230128/202301282342.2ZTowY3a-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/f36cca050cf662048001b7b7686040270e4a8c00
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jonathan-Cameron/cxl-pci-Set-the-device-timestamp/20230128-152300
        git checkout f36cca050cf662048001b7b7686040270e4a8c00
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
   drivers/cxl/core/mbox.c:834:18: sparse: sparse: cast to non-scalar
   drivers/cxl/core/mbox.c:834:18: sparse: sparse: cast from non-scalar
>> drivers/cxl/core/mbox.c:874:22: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le64 [usertype] timestamp @@     got unsigned long long [usertype] ts @@
   drivers/cxl/core/mbox.c:874:22: sparse:     expected restricted __le64 [usertype] timestamp
   drivers/cxl/core/mbox.c:874:22: sparse:     got unsigned long long [usertype] ts

vim +874 drivers/cxl/core/mbox.c

   861	
   862	int cxl_set_timestamp(struct cxl_dev_state *cxlds, u64 ts)
   863	{
   864		struct cxl_mbox_cmd mbox_cmd;
   865		struct cxl_mbox_set_timestamp_in pi;
   866	
   867		/*
   868		 * Command is optional and functionality should not be affected if
   869		 * the command is not available.
   870		 */
   871		if (!test_bit(CXL_MEM_COMMAND_ID_SET_TIMESTAMP, cxlds->enabled_cmds))
   872			return 0;
   873	
 > 874		pi.timestamp = ts;
   875		mbox_cmd = (struct cxl_mbox_cmd) {
   876			.opcode = CXL_MBOX_OP_SET_TIMESTAMP,
   877			.size_in = sizeof(pi),
   878			.payload_in = &pi,
   879		};
   880	
   881		return cxl_internal_send_cmd(cxlds, &mbox_cmd);
   882	}
   883	EXPORT_SYMBOL_NS_GPL(cxl_set_timestamp, CXL);
   884	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests