From: Christoph Hellwig <hch@lst.de> To: David Howells <dhowells@redhat.com> Cc: Christoph Hellwig <hch@lst.de>, linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 20/23] rxrpc: use bvec_set_page to initialize a bvec Date: Mon, 30 Jan 2023 13:18:20 +0100 [thread overview] Message-ID: <20230130121820.GA18981@lst.de> (raw) In-Reply-To: <3351918.1675077855@warthog.procyon.org.uk> On Mon, Jan 30, 2023 at 11:24:15AM +0000, David Howells wrote: > Seems to be something people want to do quite a lot and don't know about. Hmm. Right now there is one case where it would be used, and there's about three that are and should be using bio_add_page. > I've seen places where someone allocates a buffer and clears it just to use as > a source of zeros. There's at least one place in cifs, for example. I know > about it from wrangling arch code, but most people working on Linux haven't > done that. But we don't really need a helper for every possible page use for that. People just need to learn about ZERO_PAGE.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: David Howells <dhowells@redhat.com> Cc: linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-afs@lists.infradead.org, kvm@vger.kernel.org, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, samba-technical@lists.samba.org, linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, linux-mm@kvack.org, target-devel@vger.kernel.org, io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, Christoph Hellwig <hch@lst.de>, devel@lists.orangefs.org Subject: Re: [PATCH 20/23] rxrpc: use bvec_set_page to initialize a bvec Date: Mon, 30 Jan 2023 13:18:20 +0100 [thread overview] Message-ID: <20230130121820.GA18981@lst.de> (raw) In-Reply-To: <3351918.1675077855@warthog.procyon.org.uk> On Mon, Jan 30, 2023 at 11:24:15AM +0000, David Howells wrote: > Seems to be something people want to do quite a lot and don't know about. Hmm. Right now there is one case where it would be used, and there's about three that are and should be using bio_add_page. > I've seen places where someone allocates a buffer and clears it just to use as > a source of zeros. There's at least one place in cifs, for example. I know > about it from wrangling arch code, but most people working on Linux haven't > done that. But we don't really need a helper for every possible page use for that. People just need to learn about ZERO_PAGE. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-01-30 12:18 UTC|newest] Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-30 9:21 add bvec initialization helpers Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 9:21 ` [PATCH 01/23] block: factor out a bvec_set_page helper Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 11:55 ` Johannes Thumshirn 2023-01-30 17:09 ` Bart Van Assche 2023-01-30 17:09 ` Bart Van Assche 2023-01-30 19:24 ` Bart Van Assche 2023-01-30 19:24 ` Bart Van Assche 2023-01-31 13:45 ` Christoph Hellwig 2023-01-31 13:45 ` Christoph Hellwig 2023-01-31 4:47 ` Jakub Kicinski 2023-01-31 5:00 ` Matthew Wilcox 2023-01-31 5:00 ` Matthew Wilcox 2023-01-31 5:28 ` Matthew Wilcox 2023-01-31 5:28 ` Matthew Wilcox 2023-01-31 5:52 ` Jakub Kicinski 2023-01-31 6:55 ` Chaitanya Kulkarni 2023-01-30 9:21 ` [PATCH 02/23] block: add a bvec_set_folio helper Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 11:54 ` Johannes Thumshirn 2023-01-31 6:55 ` Chaitanya Kulkarni 2023-01-30 9:21 ` [PATCH 03/23] block: add a bvec_set_virt helper Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 12:08 ` Johannes Thumshirn 2023-01-31 6:55 ` Chaitanya Kulkarni 2023-01-30 9:21 ` [PATCH 04/23] sd: factor out a sd_set_special_bvec helper Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-31 6:56 ` Chaitanya Kulkarni 2023-01-30 9:21 ` [PATCH 05/23] target: use bvec_set_page to initialize bvecs Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-31 6:56 ` Chaitanya Kulkarni 2023-01-30 9:21 ` [PATCH 06/23] nvmet: " Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 12:07 ` Johannes Thumshirn 2023-01-31 6:57 ` Chaitanya Kulkarni 2023-01-30 9:21 ` [PATCH 07/23] nvme: use bvec_set_virt to initialize special_vec Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 12:09 ` Johannes Thumshirn 2023-01-31 6:58 ` Chaitanya Kulkarni 2023-01-30 9:21 ` [PATCH 08/23] rbd: use bvec_set_page to initialize the copy up bvec Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 17:47 ` Ilya Dryomov 2023-01-30 9:21 ` [PATCH 09/23] virtio_blk: use bvec_set_virt to initialize special_vec Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 15:17 ` Michael S. Tsirkin 2023-01-30 15:17 ` Michael S. Tsirkin 2023-01-31 3:22 ` Jason Wang 2023-01-31 3:22 ` Jason Wang 2023-01-31 6:57 ` Chaitanya Kulkarni 2023-01-30 9:21 ` [PATCH 10/23] zram: use bvec_set_page to initialize bvecs Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 13:31 ` Johannes Thumshirn 2023-01-31 2:34 ` Sergey Senozhatsky 2023-01-30 9:21 ` [PATCH 11/23] afs: use bvec_set_folio to initialize a bvec Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 9:21 ` [PATCH 12/23] ceph: use bvec_set_page " Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 18:02 ` Ilya Dryomov 2023-01-31 1:51 ` Xiubo Li 2023-01-30 9:21 ` [PATCH 13/23] cifs: use bvec_set_page to initialize bvecs Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 15:56 ` Paulo Alcantara 2023-01-30 9:21 ` [PATCH 14/23] coredump: use bvec_set_page to initialize a bvec Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 9:21 ` [PATCH 15/23] nfs: use bvec_set_page to initialize bvecs Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 9:21 ` [PATCH 16/23] orangefs: use bvec_set_{page,folio} " Christoph Hellwig 2023-01-30 9:21 ` [PATCH 16/23] orangefs: use bvec_set_{page, folio} " Christoph Hellwig 2023-01-30 9:21 ` [PATCH 17/23] splice: use bvec_set_page to initialize a bvec Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 9:21 ` [PATCH 18/23] io_uring: " Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-31 6:59 ` Chaitanya Kulkarni 2023-01-30 9:21 ` [PATCH 19/23] swap: use bvec_set_page to initialize bvecs Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 9:21 ` [PATCH 20/23] rxrpc: use bvec_set_page to initialize a bvec Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 9:21 ` [PATCH 21/23] sunrpc: use bvec_set_page to initialize bvecs Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 15:38 ` Chuck Lever III 2023-01-30 9:21 ` [PATCH 22/23] vring: use bvec_set_page to initialize a bvec Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 15:19 ` Michael S. Tsirkin 2023-01-30 15:19 ` Michael S. Tsirkin 2023-01-31 2:31 ` Jason Wang 2023-01-31 2:31 ` Jason Wang 2023-01-30 9:21 ` [PATCH 23/23] net-ceph: use bvec_set_page to initialize bvecs Christoph Hellwig 2023-01-30 9:21 ` Christoph Hellwig 2023-01-30 18:20 ` Ilya Dryomov 2023-01-30 10:31 ` [PATCH 20/23] rxrpc: use bvec_set_page to initialize a bvec David Howells 2023-01-30 10:31 ` David Howells 2023-01-30 10:33 ` Christoph Hellwig 2023-01-30 10:33 ` Christoph Hellwig 2023-01-30 11:24 ` David Howells 2023-01-30 11:24 ` David Howells 2023-01-30 12:18 ` Christoph Hellwig [this message] 2023-01-30 12:18 ` Christoph Hellwig 2023-01-30 10:33 ` [PATCH 01/23] block: factor out a bvec_set_page helper David Howells 2023-01-30 10:33 ` David Howells 2023-01-30 10:36 ` Christoph Hellwig 2023-01-30 10:36 ` Christoph Hellwig 2023-01-30 18:35 ` Ilya Dryomov 2023-01-30 15:58 ` [PATCH 20/23] rxrpc: use bvec_set_page to initialize a bvec David Howells 2023-01-30 15:58 ` David Howells 2023-01-30 15:59 ` [PATCH 11/23] afs: use bvec_set_folio " David Howells 2023-01-30 15:59 ` David Howells 2023-02-03 15:06 add bvec initialization helpers v2 Christoph Hellwig 2023-02-03 15:06 ` [PATCH 20/23] rxrpc: use bvec_set_page to initialize a bvec Christoph Hellwig 2023-02-03 15:06 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230130121820.GA18981@lst.de \ --to=hch@lst.de \ --cc=ceph-devel@vger.kernel.org \ --cc=devel@lists.orangefs.org \ --cc=dhowells@redhat.com \ --cc=io-uring@vger.kernel.org \ --cc=kvm@vger.kernel.org \ --cc=linux-afs@lists.infradead.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-cifs@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nfs@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-scsi@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=samba-technical@lists.samba.org \ --cc=target-devel@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.