From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6936EC54EED for ; Mon, 30 Jan 2023 17:05:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237265AbjA3RFD (ORCPT ); Mon, 30 Jan 2023 12:05:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbjA3REp (ORCPT ); Mon, 30 Jan 2023 12:04:45 -0500 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FE0ACC1D; Mon, 30 Jan 2023 09:04:44 -0800 (PST) Received: by mail-ot1-f48.google.com with SMTP id g21-20020a9d6495000000b0068bb336141dso2838112otl.11; Mon, 30 Jan 2023 09:04:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7Ejf7vqAQxFeMcRz+b+ludPXWyayqJapmdG5pn46nsk=; b=ium8EhYJ+khpX7bVHU+zYLKdMrWOhKMVJLJlI66d7ZGK6qddheFiHhuetKi7KVdvSV 3RPSEkhm5ubVTSA1m1qNK5uTWTH0WEhvx/h072ceqrF4VnfenbdRmQncCfG9CUaID128 kJOjn97s/8R8HoFhyLFtg3xDwUrkbTEgsL434jryLinFRpO29L2B8tRVuQfOoPNWg/3T N20xUV2vTr4M5f+f8PFeZAaDg/mBhXlM8E1OqdcLiUfn2DW7K/FQgc8KrN5gYNAZN0Cb 0LNqZ2j5Dp0IBnM1KzRAL01dHFF8bPtrVVn04UjKNQ6sS8F1tz3FDrbp2QxQ4xaHtaCK cemg== X-Gm-Message-State: AO0yUKXHicHL1IaK2xkP2JIeEh/cwqKMkqwW9S7XH8EGC35lSikgbDBH v7w1NqwoDQAWvNj6RH32yg== X-Google-Smtp-Source: AK7set8w8/Wu9DKjsKGEnq+lsfo72FtdhgNl/pG9CyvPUTTpOD8gzinQeTtCr6QRjCiwKv9eYztbDQ== X-Received: by 2002:a9d:6847:0:b0:68b:bca5:8dfa with SMTP id c7-20020a9d6847000000b0068bbca58dfamr4730987oto.28.1675098283123; Mon, 30 Jan 2023 09:04:43 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id df17-20020a056830479100b006884c42a38asm4066933otb.41.2023.01.30.09.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 09:04:42 -0800 (PST) Received: (nullmailer pid 2814224 invoked by uid 1000); Mon, 30 Jan 2023 17:04:41 -0000 Date: Mon, 30 Jan 2023 11:04:41 -0600 From: Rob Herring To: Aradhya Bhatia Cc: Krzysztof Kozlowski , Tomi Valkeinen , Jyri Sarha , David Airlie , Daniel Vetter , Laurent Pinchart , Thierry Reding , Sam Ravnborg , Maxime Ripard , Liam Girdwood , Mark Brown , Lad Prabhakar , Paul Walmsley , Palmer Dabbelt , Albert Ou , Matthias Brugger , Guo Ren , DRI Development List , Devicetree List , Linux Kernel List , Linux RISC-V List , Linux ARM Kernel List , Linux Mediatek List , Linux C-SKY Arch List , Nishanth Menon , Vignesh Raghavendra , Rahul T R , Devarsh Thakkar , Jai Luthra , Jayesh Choudhary Subject: Re: [PATCH v2 3/4] dt-bindings: panel: Introduce dual-link LVDS panel Message-ID: <20230130170441.GA2796575-robh@kernel.org> References: <20230124101238.4542-1-a-bhatia1@ti.com> <20230124101238.4542-4-a-bhatia1@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230124101238.4542-4-a-bhatia1@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2023 at 03:42:37PM +0530, Aradhya Bhatia wrote: > Dual-link LVDS interfaces have 2 links, with even pixels traveling on > one link, and odd pixels on the other. These panels are also generic in > nature, with no documented constraints, much like their single-link > counterparts, "panel-lvds". > > Add a new compatible, "panel-dual-lvds", and a dt-binding document for > these panels. > > Signed-off-by: Aradhya Bhatia > --- > .../display/panel/panel-dual-lvds.yaml | 149 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 150 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > new file mode 100644 > index 000000000000..e2ce1768e9a3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > @@ -0,0 +1,149 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/panel-dual-lvds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic Dual-Link LVDS Display Panel > + > +maintainers: > + - Aradhya Bhatia > + - Thierry Reding > + > +description: | > + A dual-LVDS interface is a dual-link connection with the even pixels > + traveling on one link, and the odd pixels traveling on the other. > + > +allOf: > + - $ref: panel-common.yaml# > + - $ref: /schemas/display/lvds.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - lincolntech,lcd185-101ct > + - microtips,mf-101hiebcaf0 > + - const: panel-dual-lvds Why do we need a new compatible? You have ports and properties to see if the panel is dual link. We already have dual link LVDS supported in advantech,idk-2121wr.yaml which says is compatible with 'panel-lvds', so that decision has already been made. The hint was you added the compatible match to the driver with 0 other changes needed. That schema is missing type definitions and constraints for dual-lvds-odd-pixels/dual-lvds-even-pixels so there does need to be some changes to add those. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: The sink for first set of LVDS pixels. > + > + properties: > + dual-lvds-odd-pixels: > + type: boolean > + > + dual-lvds-even-pixels: > + type: boolean > + > + oneOf: > + - required: [dual-lvds-odd-pixels] > + - required: [dual-lvds-even-pixels] > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: The sink for second set of LVDS pixels. > + > + properties: > + dual-lvds-even-pixels: > + type: boolean > + > + dual-lvds-odd-pixels: > + type: boolean > + > + oneOf: > + - required: [dual-lvds-even-pixels] > + - required: [dual-lvds-odd-pixels] > + > + allOf: > + - if: > + properties: > + port@0: > + required: > + - dual-lvds-odd-pixels > + then: > + properties: > + port@1: > + properties: > + dual-lvds-odd-pixels: false > + > + - if: > + properties: > + port@0: > + required: > + - dual-lvds-even-pixels > + then: > + properties: > + port@1: > + properties: > + dual-lvds-even-pixels: false > + > + required: > + - port@0 > + - port@1 > + > + port: false > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - width-mm > + - height-mm > + - data-mapping > + - panel-timing > + - ports > + > +examples: > + - | > + panel { > + compatible = "microtips,mf-101hiebcaf0", "panel-dual-lvds"; > + > + width-mm = <217>; > + height-mm = <136>; > + > + data-mapping = "vesa-24"; > + > + panel-timing { > + clock-frequency = <150275000>; > + hactive = <1920>; > + vactive = <1200>; > + hfront-porch = <32>; > + hsync-len = <52>; > + hback-porch = <24>; > + vfront-porch = <24>; > + vsync-len = <8>; > + vback-porch = <3>; > + de-active = <1>; > + }; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + dual-lvds-odd-pixels; > + lcd_in0: endpoint { > + remote-endpoint = <&oldi_out0>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + dual-lvds-even-pixels; > + lcd_in1: endpoint { > + remote-endpoint = <&oldi_out1>; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 5e18388b4579..6025bb024586 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6461,6 +6461,7 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > S: Maintained > F: drivers/gpu/drm/panel/panel-lvds.c > F: Documentation/devicetree/bindings/display/lvds.yaml > +F: Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > F: Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > > DRM DRIVER FOR MANTIX MLAF057WE51 PANELS > -- > 2.39.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01CBDC54EED for ; Mon, 30 Jan 2023 17:04:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DCBB10E013; Mon, 30 Jan 2023 17:04:46 +0000 (UTC) Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A33610E013 for ; Mon, 30 Jan 2023 17:04:44 +0000 (UTC) Received: by mail-ot1-f44.google.com with SMTP id e12-20020a0568301e4c00b0068bc93e7e34so1646184otj.4 for ; Mon, 30 Jan 2023 09:04:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7Ejf7vqAQxFeMcRz+b+ludPXWyayqJapmdG5pn46nsk=; b=DGoLIpIKnnCShcdHcyeiMrYEuWYfG6HyMBVHU5cej/zMrtZnxoY2B8/E/eLi+cwPS4 CYULGB5EBJAh128B5cAnoSgaEyRV9huhOwGldg8oN/kr5sM5TJPzBtfOi1k3C82EXhJo ep1mht7G2gwYCJQkgW+woxNwEfmZkfJV7jt46JISh7G/ChKw4C3V7mct0aLYFeXtc2/B PIZS1oLA3p0Z3SFygqndnWyrC6TJEzf36Bw1A8+5M8iMvZGWlUPoieugCQled0wL1eyR yP65EZ7xTwf2ovV5aw6YUATeYh9i1HaijwBk5hxGDZsTdswNtfBu2xHogr8g8b+2bBMq xZug== X-Gm-Message-State: AO0yUKVtoXQ88yyHmbV5yCLeY6T/JxVYJ+LF2GAns25HFM+1rOGe5Xzt NnmXDXaXTlxwNZ0j5fQAKA== X-Google-Smtp-Source: AK7set8w8/Wu9DKjsKGEnq+lsfo72FtdhgNl/pG9CyvPUTTpOD8gzinQeTtCr6QRjCiwKv9eYztbDQ== X-Received: by 2002:a9d:6847:0:b0:68b:bca5:8dfa with SMTP id c7-20020a9d6847000000b0068bbca58dfamr4730987oto.28.1675098283123; Mon, 30 Jan 2023 09:04:43 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id df17-20020a056830479100b006884c42a38asm4066933otb.41.2023.01.30.09.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 09:04:42 -0800 (PST) Received: (nullmailer pid 2814224 invoked by uid 1000); Mon, 30 Jan 2023 17:04:41 -0000 Date: Mon, 30 Jan 2023 11:04:41 -0600 From: Rob Herring To: Aradhya Bhatia Subject: Re: [PATCH v2 3/4] dt-bindings: panel: Introduce dual-link LVDS panel Message-ID: <20230130170441.GA2796575-robh@kernel.org> References: <20230124101238.4542-1-a-bhatia1@ti.com> <20230124101238.4542-4-a-bhatia1@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230124101238.4542-4-a-bhatia1@ti.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vignesh Raghavendra , Devarsh Thakkar , DRI Development List , Linux Kernel List , Thierry Reding , Guo Ren , Laurent Pinchart , Krzysztof Kozlowski , Linux RISC-V List , Sam Ravnborg , Linux C-SKY Arch List , Devicetree List , Albert Ou , Jai Luthra , Rahul T R , Lad Prabhakar , Mark Brown , Linux Mediatek List , Maxime Ripard , Paul Walmsley , Matthias Brugger , Linux ARM Kernel List , Jayesh Choudhary , Tomi Valkeinen , Liam Girdwood , Palmer Dabbelt , Jyri Sarha Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 24, 2023 at 03:42:37PM +0530, Aradhya Bhatia wrote: > Dual-link LVDS interfaces have 2 links, with even pixels traveling on > one link, and odd pixels on the other. These panels are also generic in > nature, with no documented constraints, much like their single-link > counterparts, "panel-lvds". > > Add a new compatible, "panel-dual-lvds", and a dt-binding document for > these panels. > > Signed-off-by: Aradhya Bhatia > --- > .../display/panel/panel-dual-lvds.yaml | 149 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 150 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > new file mode 100644 > index 000000000000..e2ce1768e9a3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > @@ -0,0 +1,149 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/panel-dual-lvds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic Dual-Link LVDS Display Panel > + > +maintainers: > + - Aradhya Bhatia > + - Thierry Reding > + > +description: | > + A dual-LVDS interface is a dual-link connection with the even pixels > + traveling on one link, and the odd pixels traveling on the other. > + > +allOf: > + - $ref: panel-common.yaml# > + - $ref: /schemas/display/lvds.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - lincolntech,lcd185-101ct > + - microtips,mf-101hiebcaf0 > + - const: panel-dual-lvds Why do we need a new compatible? You have ports and properties to see if the panel is dual link. We already have dual link LVDS supported in advantech,idk-2121wr.yaml which says is compatible with 'panel-lvds', so that decision has already been made. The hint was you added the compatible match to the driver with 0 other changes needed. That schema is missing type definitions and constraints for dual-lvds-odd-pixels/dual-lvds-even-pixels so there does need to be some changes to add those. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: The sink for first set of LVDS pixels. > + > + properties: > + dual-lvds-odd-pixels: > + type: boolean > + > + dual-lvds-even-pixels: > + type: boolean > + > + oneOf: > + - required: [dual-lvds-odd-pixels] > + - required: [dual-lvds-even-pixels] > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: The sink for second set of LVDS pixels. > + > + properties: > + dual-lvds-even-pixels: > + type: boolean > + > + dual-lvds-odd-pixels: > + type: boolean > + > + oneOf: > + - required: [dual-lvds-even-pixels] > + - required: [dual-lvds-odd-pixels] > + > + allOf: > + - if: > + properties: > + port@0: > + required: > + - dual-lvds-odd-pixels > + then: > + properties: > + port@1: > + properties: > + dual-lvds-odd-pixels: false > + > + - if: > + properties: > + port@0: > + required: > + - dual-lvds-even-pixels > + then: > + properties: > + port@1: > + properties: > + dual-lvds-even-pixels: false > + > + required: > + - port@0 > + - port@1 > + > + port: false > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - width-mm > + - height-mm > + - data-mapping > + - panel-timing > + - ports > + > +examples: > + - | > + panel { > + compatible = "microtips,mf-101hiebcaf0", "panel-dual-lvds"; > + > + width-mm = <217>; > + height-mm = <136>; > + > + data-mapping = "vesa-24"; > + > + panel-timing { > + clock-frequency = <150275000>; > + hactive = <1920>; > + vactive = <1200>; > + hfront-porch = <32>; > + hsync-len = <52>; > + hback-porch = <24>; > + vfront-porch = <24>; > + vsync-len = <8>; > + vback-porch = <3>; > + de-active = <1>; > + }; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + dual-lvds-odd-pixels; > + lcd_in0: endpoint { > + remote-endpoint = <&oldi_out0>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + dual-lvds-even-pixels; > + lcd_in1: endpoint { > + remote-endpoint = <&oldi_out1>; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 5e18388b4579..6025bb024586 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6461,6 +6461,7 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > S: Maintained > F: drivers/gpu/drm/panel/panel-lvds.c > F: Documentation/devicetree/bindings/display/lvds.yaml > +F: Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > F: Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > > DRM DRIVER FOR MANTIX MLAF057WE51 PANELS > -- > 2.39.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6516C54EED for ; Mon, 30 Jan 2023 17:08:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8IzEafPQZiAPUX3g95PePW/ZgQt305+E86KeXI3WQaU=; b=bpoO+GwGehM4Vf ELraviNfFkVJGNrzVTAKwJ9k92+dfkYjBPqz8qfCvGDXfAEJrsiKrg9lG9YtX5pHOkDTQ6xtdNt54 6WgSKkffD1OILKbwmp0UJEhtitLDc3JRjhHMYYTFyjfRnbqZUcw/H8b1Qpn6kMbHU35S6cQODCIWJ Wpss8zM0GFKeosg6Lpl9ObqT5DkLK2TyMNnRCrqCpxPykeowpWFZmKM9iFsZeMGY4H37oaN2imldf ALVd7MvZJb2eXglo/E/8JbsQSmAaKm/uJ0YkoATUL0Q0QF8UK9ugUHAJOhqVEUR98tgn7KDIaqp2x CUb8w2JsZfT04j8FGqgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMXdu-004P4w-VZ; Mon, 30 Jan 2023 17:08:31 +0000 Received: from mail-ot1-f47.google.com ([209.85.210.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMXaJ-004Myl-03; Mon, 30 Jan 2023 17:04:48 +0000 Received: by mail-ot1-f47.google.com with SMTP id e21-20020a9d5615000000b006884e5dce99so4697533oti.5; Mon, 30 Jan 2023 09:04:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7Ejf7vqAQxFeMcRz+b+ludPXWyayqJapmdG5pn46nsk=; b=zxus2zVZo1tINZ7z9QCLn08xrE0dIJ4EiY2BMPoi6A8hDFna9fibU40SU/T/Ilj2ro 6qTa8XmY+2PT9N7HBZqBE+aMQrApc8jlxbjxfBXNhL0JY2xR1FoDjy7fLNfJ3SGMliuI Dmowo9Fsc1MrHYVX9548IXTm/AwgVZE5TtvVU7HXTf9+/rJ8k0W2Snk/mz6mW3qF/xJn C9OfW3qg05x06xKBo0WzStAShmnzFRXX5mPRZ3LDte0GKDZzvO9kgw88qUYOCEfGnpS6 JzZpJsR+KT9hOy5ZxYaYf07PGS4dXOwrnL7i5vkoMmMWflDMzmBxqxBgLp+iTbsCtNTb aRfw== X-Gm-Message-State: AO0yUKVqoGN//qq+PhllaLoxJGGy2OCVVuyBzFw+yPykQpLDVXLEW9wA 31vUKVyEVYtQqORPNrK/fA== X-Google-Smtp-Source: AK7set8w8/Wu9DKjsKGEnq+lsfo72FtdhgNl/pG9CyvPUTTpOD8gzinQeTtCr6QRjCiwKv9eYztbDQ== X-Received: by 2002:a9d:6847:0:b0:68b:bca5:8dfa with SMTP id c7-20020a9d6847000000b0068bbca58dfamr4730987oto.28.1675098283123; Mon, 30 Jan 2023 09:04:43 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id df17-20020a056830479100b006884c42a38asm4066933otb.41.2023.01.30.09.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 09:04:42 -0800 (PST) Received: (nullmailer pid 2814224 invoked by uid 1000); Mon, 30 Jan 2023 17:04:41 -0000 Date: Mon, 30 Jan 2023 11:04:41 -0600 From: Rob Herring To: Aradhya Bhatia Cc: Krzysztof Kozlowski , Tomi Valkeinen , Jyri Sarha , David Airlie , Daniel Vetter , Laurent Pinchart , Thierry Reding , Sam Ravnborg , Maxime Ripard , Liam Girdwood , Mark Brown , Lad Prabhakar , Paul Walmsley , Palmer Dabbelt , Albert Ou , Matthias Brugger , Guo Ren , DRI Development List , Devicetree List , Linux Kernel List , Linux RISC-V List , Linux ARM Kernel List , Linux Mediatek List , Linux C-SKY Arch List , Nishanth Menon , Vignesh Raghavendra , Rahul T R , Devarsh Thakkar , Jai Luthra , Jayesh Choudhary Subject: Re: [PATCH v2 3/4] dt-bindings: panel: Introduce dual-link LVDS panel Message-ID: <20230130170441.GA2796575-robh@kernel.org> References: <20230124101238.4542-1-a-bhatia1@ti.com> <20230124101238.4542-4-a-bhatia1@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230124101238.4542-4-a-bhatia1@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_090447_064331_48F415E9 X-CRM114-Status: GOOD ( 25.97 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Jan 24, 2023 at 03:42:37PM +0530, Aradhya Bhatia wrote: > Dual-link LVDS interfaces have 2 links, with even pixels traveling on > one link, and odd pixels on the other. These panels are also generic in > nature, with no documented constraints, much like their single-link > counterparts, "panel-lvds". > > Add a new compatible, "panel-dual-lvds", and a dt-binding document for > these panels. > > Signed-off-by: Aradhya Bhatia > --- > .../display/panel/panel-dual-lvds.yaml | 149 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 150 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > new file mode 100644 > index 000000000000..e2ce1768e9a3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > @@ -0,0 +1,149 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/panel-dual-lvds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic Dual-Link LVDS Display Panel > + > +maintainers: > + - Aradhya Bhatia > + - Thierry Reding > + > +description: | > + A dual-LVDS interface is a dual-link connection with the even pixels > + traveling on one link, and the odd pixels traveling on the other. > + > +allOf: > + - $ref: panel-common.yaml# > + - $ref: /schemas/display/lvds.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - lincolntech,lcd185-101ct > + - microtips,mf-101hiebcaf0 > + - const: panel-dual-lvds Why do we need a new compatible? You have ports and properties to see if the panel is dual link. We already have dual link LVDS supported in advantech,idk-2121wr.yaml which says is compatible with 'panel-lvds', so that decision has already been made. The hint was you added the compatible match to the driver with 0 other changes needed. That schema is missing type definitions and constraints for dual-lvds-odd-pixels/dual-lvds-even-pixels so there does need to be some changes to add those. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: The sink for first set of LVDS pixels. > + > + properties: > + dual-lvds-odd-pixels: > + type: boolean > + > + dual-lvds-even-pixels: > + type: boolean > + > + oneOf: > + - required: [dual-lvds-odd-pixels] > + - required: [dual-lvds-even-pixels] > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: The sink for second set of LVDS pixels. > + > + properties: > + dual-lvds-even-pixels: > + type: boolean > + > + dual-lvds-odd-pixels: > + type: boolean > + > + oneOf: > + - required: [dual-lvds-even-pixels] > + - required: [dual-lvds-odd-pixels] > + > + allOf: > + - if: > + properties: > + port@0: > + required: > + - dual-lvds-odd-pixels > + then: > + properties: > + port@1: > + properties: > + dual-lvds-odd-pixels: false > + > + - if: > + properties: > + port@0: > + required: > + - dual-lvds-even-pixels > + then: > + properties: > + port@1: > + properties: > + dual-lvds-even-pixels: false > + > + required: > + - port@0 > + - port@1 > + > + port: false > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - width-mm > + - height-mm > + - data-mapping > + - panel-timing > + - ports > + > +examples: > + - | > + panel { > + compatible = "microtips,mf-101hiebcaf0", "panel-dual-lvds"; > + > + width-mm = <217>; > + height-mm = <136>; > + > + data-mapping = "vesa-24"; > + > + panel-timing { > + clock-frequency = <150275000>; > + hactive = <1920>; > + vactive = <1200>; > + hfront-porch = <32>; > + hsync-len = <52>; > + hback-porch = <24>; > + vfront-porch = <24>; > + vsync-len = <8>; > + vback-porch = <3>; > + de-active = <1>; > + }; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + dual-lvds-odd-pixels; > + lcd_in0: endpoint { > + remote-endpoint = <&oldi_out0>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + dual-lvds-even-pixels; > + lcd_in1: endpoint { > + remote-endpoint = <&oldi_out1>; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 5e18388b4579..6025bb024586 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6461,6 +6461,7 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > S: Maintained > F: drivers/gpu/drm/panel/panel-lvds.c > F: Documentation/devicetree/bindings/display/lvds.yaml > +F: Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > F: Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > > DRM DRIVER FOR MANTIX MLAF057WE51 PANELS > -- > 2.39.0 > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C7AFC54EED for ; Mon, 30 Jan 2023 17:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D7C7O8SxzoMieQ9a+MqDvWpVsQw5076HAFBZKLcvu6M=; b=LXqdtEmGctnmCf fVRY3k7JqM6sQrVOXGclkmPCDOWh0u8bCYbPmWojS4U42wVz5hJYmN9j1Z2wEjV5GW0IrUW+2MVv4 G7ULY+sEPJoG0CZu7ssy3XX9QP6bkwVkvgcIK1tfXqKBzOmKGwaQwiop3IYGsysfbhyb1kc/o8PrP eoBr49d+VPQd1IThjl7jddfC/48YxmnbK81D9N1VytxILeucLGZxKI8wWU8ZC0oXVmqhV6n+lgnDJ 1cTP1vWSraM0MqQOxcaYI/p5ixqZQ/5fYI0hksa49aT/Tk6CwN5bjuOUPAMvXX8gb/F6e7bB9npK6 2dFZvZK+GWezlgvHfVHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMXeY-004P8x-5u; Mon, 30 Jan 2023 17:09:10 +0000 Received: from mail-ot1-f47.google.com ([209.85.210.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMXaJ-004Myl-03; Mon, 30 Jan 2023 17:04:48 +0000 Received: by mail-ot1-f47.google.com with SMTP id e21-20020a9d5615000000b006884e5dce99so4697533oti.5; Mon, 30 Jan 2023 09:04:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7Ejf7vqAQxFeMcRz+b+ludPXWyayqJapmdG5pn46nsk=; b=zxus2zVZo1tINZ7z9QCLn08xrE0dIJ4EiY2BMPoi6A8hDFna9fibU40SU/T/Ilj2ro 6qTa8XmY+2PT9N7HBZqBE+aMQrApc8jlxbjxfBXNhL0JY2xR1FoDjy7fLNfJ3SGMliuI Dmowo9Fsc1MrHYVX9548IXTm/AwgVZE5TtvVU7HXTf9+/rJ8k0W2Snk/mz6mW3qF/xJn C9OfW3qg05x06xKBo0WzStAShmnzFRXX5mPRZ3LDte0GKDZzvO9kgw88qUYOCEfGnpS6 JzZpJsR+KT9hOy5ZxYaYf07PGS4dXOwrnL7i5vkoMmMWflDMzmBxqxBgLp+iTbsCtNTb aRfw== X-Gm-Message-State: AO0yUKVqoGN//qq+PhllaLoxJGGy2OCVVuyBzFw+yPykQpLDVXLEW9wA 31vUKVyEVYtQqORPNrK/fA== X-Google-Smtp-Source: AK7set8w8/Wu9DKjsKGEnq+lsfo72FtdhgNl/pG9CyvPUTTpOD8gzinQeTtCr6QRjCiwKv9eYztbDQ== X-Received: by 2002:a9d:6847:0:b0:68b:bca5:8dfa with SMTP id c7-20020a9d6847000000b0068bbca58dfamr4730987oto.28.1675098283123; Mon, 30 Jan 2023 09:04:43 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id df17-20020a056830479100b006884c42a38asm4066933otb.41.2023.01.30.09.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 09:04:42 -0800 (PST) Received: (nullmailer pid 2814224 invoked by uid 1000); Mon, 30 Jan 2023 17:04:41 -0000 Date: Mon, 30 Jan 2023 11:04:41 -0600 From: Rob Herring To: Aradhya Bhatia Cc: Krzysztof Kozlowski , Tomi Valkeinen , Jyri Sarha , David Airlie , Daniel Vetter , Laurent Pinchart , Thierry Reding , Sam Ravnborg , Maxime Ripard , Liam Girdwood , Mark Brown , Lad Prabhakar , Paul Walmsley , Palmer Dabbelt , Albert Ou , Matthias Brugger , Guo Ren , DRI Development List , Devicetree List , Linux Kernel List , Linux RISC-V List , Linux ARM Kernel List , Linux Mediatek List , Linux C-SKY Arch List , Nishanth Menon , Vignesh Raghavendra , Rahul T R , Devarsh Thakkar , Jai Luthra , Jayesh Choudhary Subject: Re: [PATCH v2 3/4] dt-bindings: panel: Introduce dual-link LVDS panel Message-ID: <20230130170441.GA2796575-robh@kernel.org> References: <20230124101238.4542-1-a-bhatia1@ti.com> <20230124101238.4542-4-a-bhatia1@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230124101238.4542-4-a-bhatia1@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_090447_064331_48F415E9 X-CRM114-Status: GOOD ( 25.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 24, 2023 at 03:42:37PM +0530, Aradhya Bhatia wrote: > Dual-link LVDS interfaces have 2 links, with even pixels traveling on > one link, and odd pixels on the other. These panels are also generic in > nature, with no documented constraints, much like their single-link > counterparts, "panel-lvds". > > Add a new compatible, "panel-dual-lvds", and a dt-binding document for > these panels. > > Signed-off-by: Aradhya Bhatia > --- > .../display/panel/panel-dual-lvds.yaml | 149 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 150 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > new file mode 100644 > index 000000000000..e2ce1768e9a3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > @@ -0,0 +1,149 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/panel-dual-lvds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic Dual-Link LVDS Display Panel > + > +maintainers: > + - Aradhya Bhatia > + - Thierry Reding > + > +description: | > + A dual-LVDS interface is a dual-link connection with the even pixels > + traveling on one link, and the odd pixels traveling on the other. > + > +allOf: > + - $ref: panel-common.yaml# > + - $ref: /schemas/display/lvds.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - lincolntech,lcd185-101ct > + - microtips,mf-101hiebcaf0 > + - const: panel-dual-lvds Why do we need a new compatible? You have ports and properties to see if the panel is dual link. We already have dual link LVDS supported in advantech,idk-2121wr.yaml which says is compatible with 'panel-lvds', so that decision has already been made. The hint was you added the compatible match to the driver with 0 other changes needed. That schema is missing type definitions and constraints for dual-lvds-odd-pixels/dual-lvds-even-pixels so there does need to be some changes to add those. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: The sink for first set of LVDS pixels. > + > + properties: > + dual-lvds-odd-pixels: > + type: boolean > + > + dual-lvds-even-pixels: > + type: boolean > + > + oneOf: > + - required: [dual-lvds-odd-pixels] > + - required: [dual-lvds-even-pixels] > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: The sink for second set of LVDS pixels. > + > + properties: > + dual-lvds-even-pixels: > + type: boolean > + > + dual-lvds-odd-pixels: > + type: boolean > + > + oneOf: > + - required: [dual-lvds-even-pixels] > + - required: [dual-lvds-odd-pixels] > + > + allOf: > + - if: > + properties: > + port@0: > + required: > + - dual-lvds-odd-pixels > + then: > + properties: > + port@1: > + properties: > + dual-lvds-odd-pixels: false > + > + - if: > + properties: > + port@0: > + required: > + - dual-lvds-even-pixels > + then: > + properties: > + port@1: > + properties: > + dual-lvds-even-pixels: false > + > + required: > + - port@0 > + - port@1 > + > + port: false > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - width-mm > + - height-mm > + - data-mapping > + - panel-timing > + - ports > + > +examples: > + - | > + panel { > + compatible = "microtips,mf-101hiebcaf0", "panel-dual-lvds"; > + > + width-mm = <217>; > + height-mm = <136>; > + > + data-mapping = "vesa-24"; > + > + panel-timing { > + clock-frequency = <150275000>; > + hactive = <1920>; > + vactive = <1200>; > + hfront-porch = <32>; > + hsync-len = <52>; > + hback-porch = <24>; > + vfront-porch = <24>; > + vsync-len = <8>; > + vback-porch = <3>; > + de-active = <1>; > + }; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + dual-lvds-odd-pixels; > + lcd_in0: endpoint { > + remote-endpoint = <&oldi_out0>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + dual-lvds-even-pixels; > + lcd_in1: endpoint { > + remote-endpoint = <&oldi_out1>; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 5e18388b4579..6025bb024586 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6461,6 +6461,7 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > S: Maintained > F: drivers/gpu/drm/panel/panel-lvds.c > F: Documentation/devicetree/bindings/display/lvds.yaml > +F: Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml > F: Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > > DRM DRIVER FOR MANTIX MLAF057WE51 PANELS > -- > 2.39.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel