Re: [Intel-xe] [PATCH v2] drm/xe: Add fake workaround to maintain backward compatible in MI_BATCH_BUFFER_START

[Lucas De Marchi <lucas.demarchi@intel.com>]

On Tue, Jan 31, 2023 at 04:04:08PM +0200, Jani Nikula wrote:
>On Tue, 31 Jan 2023, "Souza, Jose" <jose.souza@intel.com> wrote:
>> On Tue, 2023-01-31 at 09:24 +0200, Jani Nikula wrote:
>>> On Mon, 30 Jan 2023, José Roberto de Souza <jose.souza@intel.com> wrote:
>>> > +static const struct xe_rtp_entry lrc_additional_programming[] = {
>>> > +	{ XE_RTP_NAME("FakeWaDisableNestedBBMode"),
>>>
>>> Please add newline after {, and indent with tabs not spaces.
>>
>> All the xe_rtp_entry arrays have this style pattern, just following
>> what is already in the file.
>
>Yuck. :p

and I'm the guilty one. It is a table and when adding a lot of entries
the ", {" alone in the line for each entry consumes a lot of vertical
waste space, so I decided to merge them. I considered merging the "}"
too which would balance it, but looked nice to have at least a separator
between each entry.

As we add more entries we may decide another format for the table.
For this series I think the pending decision is more on the UABI side:
do we want to support this for older platforms knowing that future ones
will have this setting changed?

+Rodrigo, +Matt

Lucas De Marchi

>
>
>-- 
>Jani Nikula, Intel Open Source Graphics Center