All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: "Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Artur Świgoń" <a.swigon@samsung.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Johan Hovold" <johan+linaro@kernel.org>
Subject: [PATCH 23/23] interconnect: drop unused icc_link_destroy() interface
Date: Wed,  1 Feb 2023 11:15:59 +0100	[thread overview]
Message-ID: <20230201101559.15529-24-johan+linaro@kernel.org> (raw)
In-Reply-To: <20230201101559.15529-1-johan+linaro@kernel.org>

Now that the link array is deallocated when destroying nodes and the
explicit link removal has been dropped from the exynos driver there are
no further users of and no need for the icc_link_destroy() interface.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/interconnect/core.c           | 46 ---------------------------
 include/linux/interconnect-provider.h |  6 ----
 2 files changed, 52 deletions(-)

diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index 8cca5e9a9d5f..d40b35bdc6ef 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -859,52 +859,6 @@ int icc_link_create(struct icc_node *node, const int dst_id)
 }
 EXPORT_SYMBOL_GPL(icc_link_create);
 
-/**
- * icc_link_destroy() - destroy a link between two nodes
- * @src: pointer to source node
- * @dst: pointer to destination node
- *
- * Return: 0 on success, or an error code otherwise
- */
-int icc_link_destroy(struct icc_node *src, struct icc_node *dst)
-{
-	struct icc_node **new;
-	size_t slot;
-	int ret = 0;
-
-	if (IS_ERR_OR_NULL(src))
-		return -EINVAL;
-
-	if (IS_ERR_OR_NULL(dst))
-		return -EINVAL;
-
-	mutex_lock(&icc_lock);
-
-	for (slot = 0; slot < src->num_links; slot++)
-		if (src->links[slot] == dst)
-			break;
-
-	if (WARN_ON(slot == src->num_links)) {
-		ret = -ENXIO;
-		goto out;
-	}
-
-	src->links[slot] = src->links[--src->num_links];
-
-	new = krealloc(src->links, src->num_links * sizeof(*src->links),
-		       GFP_KERNEL);
-	if (new)
-		src->links = new;
-	else
-		ret = -ENOMEM;
-
-out:
-	mutex_unlock(&icc_lock);
-
-	return ret;
-}
-EXPORT_SYMBOL_GPL(icc_link_destroy);
-
 /**
  * icc_node_add() - add interconnect node to interconnect provider
  * @node: pointer to the interconnect node
diff --git a/include/linux/interconnect-provider.h b/include/linux/interconnect-provider.h
index b9af9016a95e..e6d8aca6886d 100644
--- a/include/linux/interconnect-provider.h
+++ b/include/linux/interconnect-provider.h
@@ -118,7 +118,6 @@ int icc_std_aggregate(struct icc_node *node, u32 tag, u32 avg_bw,
 struct icc_node *icc_node_create(int id);
 void icc_node_destroy(int id);
 int icc_link_create(struct icc_node *node, const int dst_id);
-int icc_link_destroy(struct icc_node *src, struct icc_node *dst);
 void icc_node_add(struct icc_node *node, struct icc_provider *provider);
 void icc_node_del(struct icc_node *node);
 int icc_nodes_remove(struct icc_provider *provider);
@@ -150,11 +149,6 @@ static inline int icc_link_create(struct icc_node *node, const int dst_id)
 	return -ENOTSUPP;
 }
 
-static inline int icc_link_destroy(struct icc_node *src, struct icc_node *dst)
-{
-	return -ENOTSUPP;
-}
-
 static inline void icc_node_add(struct icc_node *node, struct icc_provider *provider)
 {
 }
-- 
2.39.1


WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan+linaro@kernel.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: "Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Artur Świgoń" <a.swigon@samsung.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Johan Hovold" <johan+linaro@kernel.org>
Subject: [PATCH 23/23] interconnect: drop unused icc_link_destroy() interface
Date: Wed,  1 Feb 2023 11:15:59 +0100	[thread overview]
Message-ID: <20230201101559.15529-24-johan+linaro@kernel.org> (raw)
In-Reply-To: <20230201101559.15529-1-johan+linaro@kernel.org>

Now that the link array is deallocated when destroying nodes and the
explicit link removal has been dropped from the exynos driver there are
no further users of and no need for the icc_link_destroy() interface.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/interconnect/core.c           | 46 ---------------------------
 include/linux/interconnect-provider.h |  6 ----
 2 files changed, 52 deletions(-)

diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index 8cca5e9a9d5f..d40b35bdc6ef 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -859,52 +859,6 @@ int icc_link_create(struct icc_node *node, const int dst_id)
 }
 EXPORT_SYMBOL_GPL(icc_link_create);
 
-/**
- * icc_link_destroy() - destroy a link between two nodes
- * @src: pointer to source node
- * @dst: pointer to destination node
- *
- * Return: 0 on success, or an error code otherwise
- */
-int icc_link_destroy(struct icc_node *src, struct icc_node *dst)
-{
-	struct icc_node **new;
-	size_t slot;
-	int ret = 0;
-
-	if (IS_ERR_OR_NULL(src))
-		return -EINVAL;
-
-	if (IS_ERR_OR_NULL(dst))
-		return -EINVAL;
-
-	mutex_lock(&icc_lock);
-
-	for (slot = 0; slot < src->num_links; slot++)
-		if (src->links[slot] == dst)
-			break;
-
-	if (WARN_ON(slot == src->num_links)) {
-		ret = -ENXIO;
-		goto out;
-	}
-
-	src->links[slot] = src->links[--src->num_links];
-
-	new = krealloc(src->links, src->num_links * sizeof(*src->links),
-		       GFP_KERNEL);
-	if (new)
-		src->links = new;
-	else
-		ret = -ENOMEM;
-
-out:
-	mutex_unlock(&icc_lock);
-
-	return ret;
-}
-EXPORT_SYMBOL_GPL(icc_link_destroy);
-
 /**
  * icc_node_add() - add interconnect node to interconnect provider
  * @node: pointer to the interconnect node
diff --git a/include/linux/interconnect-provider.h b/include/linux/interconnect-provider.h
index b9af9016a95e..e6d8aca6886d 100644
--- a/include/linux/interconnect-provider.h
+++ b/include/linux/interconnect-provider.h
@@ -118,7 +118,6 @@ int icc_std_aggregate(struct icc_node *node, u32 tag, u32 avg_bw,
 struct icc_node *icc_node_create(int id);
 void icc_node_destroy(int id);
 int icc_link_create(struct icc_node *node, const int dst_id);
-int icc_link_destroy(struct icc_node *src, struct icc_node *dst);
 void icc_node_add(struct icc_node *node, struct icc_provider *provider);
 void icc_node_del(struct icc_node *node);
 int icc_nodes_remove(struct icc_provider *provider);
@@ -150,11 +149,6 @@ static inline int icc_link_create(struct icc_node *node, const int dst_id)
 	return -ENOTSUPP;
 }
 
-static inline int icc_link_destroy(struct icc_node *src, struct icc_node *dst)
-{
-	return -ENOTSUPP;
-}
-
 static inline void icc_node_add(struct icc_node *node, struct icc_provider *provider)
 {
 }
-- 
2.39.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-02-01 10:17 UTC|newest]

Thread overview: 118+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01 10:15 [PATCH 00/23] interconnect: fix racy provider registration Johan Hovold
2023-02-01 10:15 ` Johan Hovold
2023-02-01 10:15 ` [PATCH 01/23] interconnect: fix mem leak when freeing nodes Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-01 11:18   ` Konrad Dybcio
2023-02-01 11:18     ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 02/23] interconnect: fix icc_provider_del() error handling Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-01 11:16   ` Konrad Dybcio
2023-02-01 11:16     ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 03/23] interconnect: fix provider registration API Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-03  2:48   ` Konrad Dybcio
2023-02-03  2:48     ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 04/23] interconnect: imx: fix registration race Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-03  2:49   ` Konrad Dybcio
2023-02-03  2:49     ` Konrad Dybcio
2023-02-03 16:01   ` Luca Ceresoli
2023-02-03 16:01     ` Luca Ceresoli
2023-02-06  8:09     ` Johan Hovold
2023-02-06  8:09       ` Johan Hovold
2023-02-06 20:52       ` Luca Ceresoli
2023-02-06 20:52         ` Luca Ceresoli
2023-02-01 10:15 ` [PATCH 05/23] interconnect: qcom: osm-l3: " Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-03  2:51   ` Konrad Dybcio
2023-02-03  2:51     ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 06/23] interconnect: qcom: rpm: fix probe child-node error handling Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-03  2:52   ` Konrad Dybcio
2023-02-03  2:52     ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 07/23] interconnect: qcom: rpm: fix probe PM domain " Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-03  2:53   ` Konrad Dybcio
2023-02-03  2:53     ` Konrad Dybcio
2023-03-11 18:17   ` Christophe JAILLET
2023-03-11 18:17     ` Christophe JAILLET
2023-03-13  8:18     ` Johan Hovold
2023-03-13  8:18       ` Johan Hovold
2023-02-01 10:15 ` [PATCH 08/23] interconnect: qcom: rpm: fix registration race Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-03  2:53   ` Konrad Dybcio
2023-02-03  2:53     ` Konrad Dybcio
2023-02-03  4:06   ` Jun Nie
2023-02-03  4:06     ` Jun Nie
2023-02-01 10:15 ` [PATCH 09/23] interconnect: qcom: rpmh: fix probe child-node error handling Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-03  2:54   ` Konrad Dybcio
2023-02-03  2:54     ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 10/23] interconnect: qcom: rpmh: fix registration race Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-03  2:55   ` Konrad Dybcio
2023-02-03  2:55     ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 11/23] interconnect: qcom: msm8974: " Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-02 23:13   ` Brian Masney
2023-02-02 23:13     ` Brian Masney
2023-02-03  2:56   ` Konrad Dybcio
2023-02-03  2:56     ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 12/23] interconnect: qcom: sm8450: " Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-03  2:56   ` Konrad Dybcio
2023-02-03  2:56     ` Konrad Dybcio
2023-02-06 12:10   ` Vinod Koul
2023-02-06 12:10     ` Vinod Koul
2023-02-01 10:15 ` [PATCH 13/23] interconnect: qcom: sm8550: " Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-01 10:20   ` Abel Vesa
2023-02-01 10:20     ` Abel Vesa
2023-02-03  2:57   ` Konrad Dybcio
2023-02-03  2:57     ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 14/23] interconnect: exynos: fix node leak in probe PM QoS error path Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-02 10:58   ` Krzysztof Kozlowski
2023-02-02 10:58     ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 15/23] interconnect: exynos: fix registration race Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-02 11:04   ` Krzysztof Kozlowski
2023-02-02 11:04     ` Krzysztof Kozlowski
2023-02-02 12:17     ` Johan Hovold
2023-02-02 12:17       ` Johan Hovold
2023-02-02 12:20       ` Krzysztof Kozlowski
2023-02-02 12:20         ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 16/23] interconnect: exynos: drop redundant link destroy Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-02 11:09   ` Krzysztof Kozlowski
2023-02-02 11:09     ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 17/23] memory: tegra: fix interconnect registration race Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-02 12:21   ` Krzysztof Kozlowski
2023-02-02 12:21     ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 18/23] memory: tegra124-emc: " Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-02 12:21   ` Krzysztof Kozlowski
2023-02-02 12:21     ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 19/23] memory: tegra20-emc: " Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-02 12:21   ` Krzysztof Kozlowski
2023-02-02 12:21     ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 20/23] memory: tegra30-emc: " Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-02 12:21   ` Krzysztof Kozlowski
2023-02-02 12:21     ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 21/23] interconnect: drop racy registration API Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-03  2:58   ` Konrad Dybcio
2023-02-03  2:58     ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 22/23] interconnect: drop unused icc_get() interface Johan Hovold
2023-02-01 10:15   ` Johan Hovold
2023-02-03  2:59   ` Konrad Dybcio
2023-02-03  2:59     ` Konrad Dybcio
2023-02-01 10:15 ` Johan Hovold [this message]
2023-02-01 10:15   ` [PATCH 23/23] interconnect: drop unused icc_link_destroy() interface Johan Hovold
2023-02-02 11:13 ` [PATCH 00/23] interconnect: fix racy provider registration Krzysztof Kozlowski
2023-02-02 11:13   ` Krzysztof Kozlowski
2023-02-02 12:20   ` Johan Hovold
2023-02-02 12:20     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230201101559.15529-24-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=a.swigon@samsung.com \
    --cc=agross@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andersson@kernel.org \
    --cc=djakov@kernel.org \
    --cc=festevam@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=kernel@pengutronix.de \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s.nawrocki@samsung.com \
    --cc=shawnguo@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.