From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F4ADC05027 for ; Wed, 1 Feb 2023 14:27:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232000AbjBAO15 (ORCPT ); Wed, 1 Feb 2023 09:27:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232024AbjBAO1w (ORCPT ); Wed, 1 Feb 2023 09:27:52 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 160CE68127 for ; Wed, 1 Feb 2023 06:27:51 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id m8so8638980edd.10 for ; Wed, 01 Feb 2023 06:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+fbiDWy8ZCeEEPo3XsRTUlzcMe3rsD7fkZwC6S0cFK0=; b=gAuVsJrYc7jh8ErBsEv3KC4ZC2oYJctZttWWSRj1FJ2yUsydorfPIcxfqxhbIpT+NM VJSNjFhzuhLo2iCXIi7JP/kh0sPKfPyNhxp1sLzCMpxDDUwxa1g6RoBiWpOfxmYEMUbk vI1ZbhbaGzTVCg5d2AYbxzQT6Lht/1pTHdceiMUoBc+/tEL6HzyozcGSM/9m37UR9aSn uPZx6Y6ve8uBCqK9loEjuNnqFTWU376VNeTQOrdvDp7xk67ltLLCH9OdKA/N4GUjzlmp RzmXlvs07ezYOghcZkzVgphJEiPqALOXtnVVN8SXtbvZyjnOFA+3dqltAwVIgr/rbMoc eDQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+fbiDWy8ZCeEEPo3XsRTUlzcMe3rsD7fkZwC6S0cFK0=; b=7tHZGnQZG3AZQ9/YbqXg0f1blmWUnJ3TsyPjRQhm0W+v4FGPjglba8eEOMJTdEfuJO RqY8Xw0Yo/uMToVsuwO6GruY5jgzWGdFJFPcMCyZq93NbAexRxAeNHAJcF9NW+A+qgrx VBI9VejZKQVBoBiybEffW6Byi9QnPQbLAypb+rIUbHvIC2+e9y8LcDNk0T7H+pWUBnI8 wFMqzPhMhD/yLE881HIISstookAMK5qC2wSQJ+Q+wat9++lb7C3nUXS5fEmiWsk288/J 5T2b/jWY7y/5+bcGJF831hdC2wNMnWWE3s0yvsr0FdO5Zud4IzWSaAvJ8ansOAVk5LRE KR1A== X-Gm-Message-State: AO0yUKVVbjf0rCRjSpYkQJzEaTzjazpnl3SLFdxeYON+pIpCnQNye6S4 lv69MBwu8Ow0mYgTc9NTAeG8nLaJdKI= X-Google-Smtp-Source: AK7set+Ldupr8odgypamg0BybQedrh29v5qHb8uwrB94NJrvfSbIEZzbyHzI9wwW8XEVlszcDIL6sg== X-Received: by 2002:a05:6402:1bcd:b0:472:9af1:163f with SMTP id ch13-20020a0564021bcd00b004729af1163fmr1833744edb.37.1675261669554; Wed, 01 Feb 2023 06:27:49 -0800 (PST) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id cf8-20020a0564020b8800b004a18f2ffb86sm8975564edb.79.2023.02.01.06.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 06:27:49 -0800 (PST) From: Sergey Organov To: Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org, Fabio Estevam , Jiri Slaby , Richard Genoud , Sascha Hauer , Shawn Guo , Tim Harvey , =?UTF-8?q?Tomasz=20Mo=C5=84?= , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Johan Hovold , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sherry Sun , Stefan Wahren , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Pengutronix Kernel Team , Sergey Organov Subject: [PATCH v1 7/7] serial: imx: refine local variables in rxint() Date: Wed, 1 Feb 2023 17:27:00 +0300 Message-Id: <20230201142700.4346-8-sorganov@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230201142700.4346-1-sorganov@gmail.com> References: <87bko4e65y.fsf@osv.gnss.ru> <20230201142700.4346-1-sorganov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org The 'rx' is chip register, similar to 'usr2', so let it be of 'u32' type as well. Move 'flg' to be FIFO read loop local as it's not used outside. Signed-off-by: Sergey Organov --- drivers/tty/serial/imx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 488d8119562e..447b9060d9df 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -888,9 +888,8 @@ static void imx_uart_check_flood(struct imx_port *sport, u32 usr2) static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) { struct imx_port *sport = dev_id; - unsigned int rx, flg; struct tty_port *port = &sport->port.state->port; - u32 usr2; + u32 usr2, rx; /* If we received something, check for 0xff flood */ usr2 = imx_uart_readl(sport, USR2); @@ -898,7 +897,7 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) imx_uart_check_flood(sport, usr2); while ((rx = imx_uart_readl(sport, URXD0)) & URXD_CHARRDY) { - flg = TTY_NORMAL; + unsigned int flg = TTY_NORMAL; sport->port.icount.rx++; if (unlikely(rx & URXD_ERR)) { -- 2.30.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73820C636D7 for ; Wed, 1 Feb 2023 14:45:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OGvyD9sL77T6KiY9NU8Mz4xEMLiIUJ3nJaKDQS1z2JY=; b=yI3Phr+DmU5bXp MCq+6i7vydInAMoNyfUk/wD4kBal8x9dxpHDf8t7SZDJJEp5cbw5mbo9LLyc5nizZ3r5srga/rxQo EU39atLXIhsPc7ShPVGivK5Ii/bSnXmBmN2eliQKGgojz/noBHwlJyGQEi3Mzt35m8/YTIZocSaC6 b4bTkaXcVf7elvxS1x6l7pkwBIla/DNtkvyViQ2NiNxdz6fe3A01XzQH8Dy3LVNChvKeUXbPI64y3 1rWpZBJI38nsCmCVgVx4okKkiCpX2qKv6dpexJbswMP4U44WDqazUAvl1PaXbE3Wp4Yp/OdhAmbbC zq8TmEf5LGquzWIyo5Xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNEKw-00CSjn-B6; Wed, 01 Feb 2023 14:43:48 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNE5X-00CLr9-48 for linux-arm-kernel@lists.infradead.org; Wed, 01 Feb 2023 14:27:53 +0000 Received: by mail-ed1-x52f.google.com with SMTP id v13so17828765eda.11 for ; Wed, 01 Feb 2023 06:27:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+fbiDWy8ZCeEEPo3XsRTUlzcMe3rsD7fkZwC6S0cFK0=; b=gAuVsJrYc7jh8ErBsEv3KC4ZC2oYJctZttWWSRj1FJ2yUsydorfPIcxfqxhbIpT+NM VJSNjFhzuhLo2iCXIi7JP/kh0sPKfPyNhxp1sLzCMpxDDUwxa1g6RoBiWpOfxmYEMUbk vI1ZbhbaGzTVCg5d2AYbxzQT6Lht/1pTHdceiMUoBc+/tEL6HzyozcGSM/9m37UR9aSn uPZx6Y6ve8uBCqK9loEjuNnqFTWU376VNeTQOrdvDp7xk67ltLLCH9OdKA/N4GUjzlmp RzmXlvs07ezYOghcZkzVgphJEiPqALOXtnVVN8SXtbvZyjnOFA+3dqltAwVIgr/rbMoc eDQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+fbiDWy8ZCeEEPo3XsRTUlzcMe3rsD7fkZwC6S0cFK0=; b=2be0X7hpOlJsOZcWENkys6inra8vMf/SnWv4zbRyMhukFoesBwgu/OIiELFuuZUdJL utF03HlILEOkFtMG26qBIEk4jYT2QsHaq0DrwAF2IZoFcfSovoo4n6x1dG3XZuM2SctG EumX5XEhapUT7gOct9wP8i2cGSbcREJA/WFZrP4GFtIrANQL8OV6MkZhymsqIv5T/YC/ YZXr3XZ/2PuwU07NJ0PZrMytrlqtsbHe1R0RxwzIGQEJ0cqi762URn188MG31E3uvhEx XqWS4VQUqN78XbQv53QefbMwhgLADDpY+r6KbnNol3nhEA4B4VeB661sH4OvXtgIfL8l Zn3g== X-Gm-Message-State: AO0yUKWJz3IJZP+iEg4eSmv1zyQXD3CtzZk+yyF0OAbLZAyzTEkhwgTO VbVT2GrKotsSY7i3hMc9eEA= X-Google-Smtp-Source: AK7set+Ldupr8odgypamg0BybQedrh29v5qHb8uwrB94NJrvfSbIEZzbyHzI9wwW8XEVlszcDIL6sg== X-Received: by 2002:a05:6402:1bcd:b0:472:9af1:163f with SMTP id ch13-20020a0564021bcd00b004729af1163fmr1833744edb.37.1675261669554; Wed, 01 Feb 2023 06:27:49 -0800 (PST) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id cf8-20020a0564020b8800b004a18f2ffb86sm8975564edb.79.2023.02.01.06.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 06:27:49 -0800 (PST) From: Sergey Organov To: Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org, Fabio Estevam , Jiri Slaby , Richard Genoud , Sascha Hauer , Shawn Guo , Tim Harvey , =?UTF-8?q?Tomasz=20Mo=C5=84?= , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Johan Hovold , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sherry Sun , Stefan Wahren , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Pengutronix Kernel Team , Sergey Organov Subject: [PATCH v1 7/7] serial: imx: refine local variables in rxint() Date: Wed, 1 Feb 2023 17:27:00 +0300 Message-Id: <20230201142700.4346-8-sorganov@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230201142700.4346-1-sorganov@gmail.com> References: <87bko4e65y.fsf@osv.gnss.ru> <20230201142700.4346-1-sorganov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230201_062751_281933_38893026 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 'rx' is chip register, similar to 'usr2', so let it be of 'u32' type as well. Move 'flg' to be FIFO read loop local as it's not used outside. Signed-off-by: Sergey Organov --- drivers/tty/serial/imx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 488d8119562e..447b9060d9df 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -888,9 +888,8 @@ static void imx_uart_check_flood(struct imx_port *sport, u32 usr2) static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) { struct imx_port *sport = dev_id; - unsigned int rx, flg; struct tty_port *port = &sport->port.state->port; - u32 usr2; + u32 usr2, rx; /* If we received something, check for 0xff flood */ usr2 = imx_uart_readl(sport, USR2); @@ -898,7 +897,7 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) imx_uart_check_flood(sport, usr2); while ((rx = imx_uart_readl(sport, URXD0)) & URXD_CHARRDY) { - flg = TTY_NORMAL; + unsigned int flg = TTY_NORMAL; sport->port.icount.rx++; if (unlikely(rx & URXD_ERR)) { -- 2.30.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel