From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9BADC61DA4 for ; Thu, 2 Feb 2023 14:16:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232200AbjBBOQh (ORCPT ); Thu, 2 Feb 2023 09:16:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232206AbjBBOQc (ORCPT ); Thu, 2 Feb 2023 09:16:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7387B8FB67 for ; Thu, 2 Feb 2023 06:16:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E64A8B8266D for ; Thu, 2 Feb 2023 14:16:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 295D2C4339B; Thu, 2 Feb 2023 14:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675347388; bh=T3ZJvCbM5JYguoygRhNxV8L62VNl5R7w++Crx8Qvyck=; h=From:To:Cc:Subject:Date:From; b=DkaUE/kttzeYaVR2rC7JiKj7kJIa/c/Df0g2TNSjM1pg2ZcZSnVimf8utsHBPtqIf 8JNhGBFP4eceRXoGWvHjE7HhiPshJ7No0Fo8TjyTScdgjycCqIgi9Co6UCnTnOQBie kAW78HGFF0/YVCXFPRldlcISrY8fGgNSL21AsMv4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: [PATCH 1/2] drivers: base: component: fix memory leak with using debugfs_lookup() Date: Thu, 2 Feb 2023 15:16:20 +0100 Message-Id: <20230202141621.2296458-1-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=969; i=gregkh@linuxfoundation.org; h=from:subject; bh=T3ZJvCbM5JYguoygRhNxV8L62VNl5R7w++Crx8Qvyck=; b=owGbwMvMwCRo6H6F97bub03G02pJDMm3j26N88vMn1Rkwhj7I5b3qSpn86xF9x/XeG3keXZr8u+X CjFSHbEsDIJMDLJiiixftvEc3V9xSNHL0PY0zBxWJpAhDFycAjCRIGeGBXO3eTlxHayRO/fl5pYp9z 0+7Tmxx5FhwTxdQR8f1jblLEfuyPPOac0q72NMAA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/base/component.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/component.c b/drivers/base/component.c index 5eadeac6c532..7dbf14a1d915 100644 --- a/drivers/base/component.c +++ b/drivers/base/component.c @@ -125,7 +125,7 @@ static void component_debugfs_add(struct aggregate_device *m) static void component_debugfs_del(struct aggregate_device *m) { - debugfs_remove(debugfs_lookup(dev_name(m->parent), component_debugfs_dir)); + debugfs_lookup_and_remove(dev_name(m->parent), component_debugfs_dir); } #else -- 2.39.1