From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B61C05027 for ; Thu, 2 Feb 2023 15:19:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232604AbjBBPTN (ORCPT ); Thu, 2 Feb 2023 10:19:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232673AbjBBPS7 (ORCPT ); Thu, 2 Feb 2023 10:18:59 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85B5E5FEF for ; Thu, 2 Feb 2023 07:18:32 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 2129A68C7B; Thu, 2 Feb 2023 16:18:00 +0100 (CET) Date: Thu, 2 Feb 2023 16:17:59 +0100 From: Christoph Hellwig To: Andy Shevchenko Cc: Greg Kroah-Hartman , Daniele Ceraolo Spurio , Alexander Usyskin , linux-kernel@vger.kernel.org, Tomas Winkler , Arnd Bergmann , Christoph Hellwig Subject: Re: [PATCH v1 1/1] mei: Move uuid_le_cmp() to its only user Message-ID: <20230202151759.GA28861@lst.de> References: <20230202145412.87569-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202145412.87569-1-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 02, 2023 at 04:54:12PM +0200, Andy Shevchenko wrote: > There is only a single user of uuid_le_cmp() API, let's make it private > to that user. Any reason this code can't just use guid_t and guid_equal?