From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44E00C05027 for ; Thu, 2 Feb 2023 16:57:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231775AbjBBQ5B (ORCPT ); Thu, 2 Feb 2023 11:57:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbjBBQ47 (ORCPT ); Thu, 2 Feb 2023 11:56:59 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABE7665EF4; Thu, 2 Feb 2023 08:56:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6488FB82746; Thu, 2 Feb 2023 16:56:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8122BC433D2; Thu, 2 Feb 2023 16:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675357016; bh=Gvq02b9P/lXWWu1impdnZP8MBf9Vgtl3EK37Xtq1PQY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g6munLSfCJTT/MJhvhOdAaWevLr6cf8ENrbjUT7sQ2y3l4t+9YxjG+959fqA1goDb 7HGK5SiYdhXksOCUMVmtkvPVGtXMvZy6GGdG8jBdS4nKgLgF4eEulQVO7Z0IelXdot FoLevu/DV84ngi/wlAavP2+wOu9qRxA85iq/G485Ekuh3zvPns9M+jiKwLHM0yicKP 7rFr+nvh0LU2E1Zj5EW2BVQc8n+pTlnhUWKMWUC8TSCKMjwZbLJhtlmIMB6ktEjxrl 9H5HvWSkX5a3cdAg9SRrsDjmB0UJ0uwQXegFNSJlpfHbrnV4pVRLfYnOhBRprdKkYE cPXI8tddOUi2Q== Date: Thu, 2 Feb 2023 17:10:52 +0000 From: Jonathan Cameron To: Marco Felsch Cc: Alexander Stein , Cai Huoqing , Haibo Chen , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Fabio Estevam , devicetree@vger.kernel.org, linux-iio@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] dt-bindings: iio: adc: add missing vref-supply Message-ID: <20230202171052.502ec666@jic23-huawei> In-Reply-To: <20230201121343.vk2t2dfpbvhflols@pengutronix.de> References: <20230131101323.606931-1-alexander.stein@ew.tq-group.com> <20230131104816.w5sfpcdjulr2ogze@pengutronix.de> <1850476.tdWV9SEqCh@steina-w> <20230201121343.vk2t2dfpbvhflols@pengutronix.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 1 Feb 2023 13:13:43 +0100 Marco Felsch wrote: > Hi Alexander, > > On 23-01-31, Alexander Stein wrote: > > Hi Marco, > > > > thanks for the feedback. > > > > Am Dienstag, 31. Januar 2023, 11:48:16 CET schrieb Marco Felsch: > > > Hi Alexander, > > > > > > On 23-01-31, Alexander Stein wrote: > > > > Although this property is used right now for IIO_CHAN_INFO_SCALE, > > > > this ADC has two internal reference voltages, which the driver currently > > > > doesn't make use of. > > > > > > > > Fixes: db73419d8c06 ("dt-bindings: iio: adc: Add binding documentation for > > > > NXP IMX8QXP ADC") Signed-off-by: Alexander Stein > > > > > > > > --- > > > > > > > > .../devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > > > b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml index > > > > 63369ba388e4..879768af0303 100644 > > > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > > > > > > > @@ -39,6 +39,9 @@ properties: > > > > power-domains: > > > > maxItems: 1 > > > > > > > > + vref-supply: > > > > + description: External ADC reference voltage supply on VREFH pad. > > > > > > Please add it to the list of required properties, we can remove it as > > > soon as the driver has support for the internal reference voltages. > > > > I was thinking in doing so before as well. But DT describes the hardware, and > > this ADC apparently would be functioning without a reference voltage on that > > pad, using a different one. What the driver actual does is a different matter. > > I have also thought about it first but than I checked the RM which says > that "multi-reference selection" is chip dependent. Oh goody. So is it detectable? If we are going to stick to a single compatible rather than adding them for the variants with and without this feature, should probably add a note at least to say it is required for some parts. Also, link if public would be good for purposes of discussion as my google fu didn't find relevant doc. (assuming it's public) Jonathan > > Regards, > Marco > > > > > > Best regards, > > Alexander > > > > > Regards, > > > Marco > > > > > > > + > > > > > > > > "#io-channel-cells": > > > > const: 1 > > > > > > > > @@ -72,6 +75,7 @@ examples: > > > > assigned-clocks = <&clk IMX_SC_R_ADC_0>; > > > > assigned-clock-rates = <24000000>; > > > > power-domains = <&pd IMX_SC_R_ADC_0>; > > > > > > > > + vref-supply = <®_1v8>; > > > > > > > > #io-channel-cells = <1>; > > > > > > > > }; > > > > > > > > }; > > > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8704C05027 for ; Thu, 2 Feb 2023 16:57:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o8TjjycyOyvANICH31iKwRRQOIP99qCo1nmUPN14LL8=; b=mwntXegLEwDCY2 msBjuq+B/cAE336fd9N3LYg1SvZVhFruMfaSV198bnL9flzw66WAyuU6BEZAURXvTMp3ATTtz2Hik admwB4zOiZayonumIMNaIRsgY99Qyy5aCgL38KECa8oV4T3/+pQ6oRZ65xD4HQmMHrMnvkS4e5X7S fVkxRqt+wHsc+XT9haInzJSdVfIe3asW3LfkXKWjWxq9tCCZ8ekHBV64iBGTSTkrlTf3gDyOjLFdz zpIULtUsTN6yLjCml/gkjHLjOQZ1yNnWWeOFo0x5fKRejDQJyIwlgbM8CbuAU3Mb/dtfmS9YGnkSD wpoOTvKXUiVwo+VhaFCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNctR-00GjBY-Op; Thu, 02 Feb 2023 16:57:01 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNctN-00GjA7-Rz for linux-arm-kernel@lists.infradead.org; Thu, 02 Feb 2023 16:56:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A695461C0A; Thu, 2 Feb 2023 16:56:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8122BC433D2; Thu, 2 Feb 2023 16:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675357016; bh=Gvq02b9P/lXWWu1impdnZP8MBf9Vgtl3EK37Xtq1PQY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g6munLSfCJTT/MJhvhOdAaWevLr6cf8ENrbjUT7sQ2y3l4t+9YxjG+959fqA1goDb 7HGK5SiYdhXksOCUMVmtkvPVGtXMvZy6GGdG8jBdS4nKgLgF4eEulQVO7Z0IelXdot FoLevu/DV84ngi/wlAavP2+wOu9qRxA85iq/G485Ekuh3zvPns9M+jiKwLHM0yicKP 7rFr+nvh0LU2E1Zj5EW2BVQc8n+pTlnhUWKMWUC8TSCKMjwZbLJhtlmIMB6ktEjxrl 9H5HvWSkX5a3cdAg9SRrsDjmB0UJ0uwQXegFNSJlpfHbrnV4pVRLfYnOhBRprdKkYE cPXI8tddOUi2Q== Date: Thu, 2 Feb 2023 17:10:52 +0000 From: Jonathan Cameron To: Marco Felsch Cc: Alexander Stein , Cai Huoqing , Haibo Chen , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Fabio Estevam , devicetree@vger.kernel.org, linux-iio@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] dt-bindings: iio: adc: add missing vref-supply Message-ID: <20230202171052.502ec666@jic23-huawei> In-Reply-To: <20230201121343.vk2t2dfpbvhflols@pengutronix.de> References: <20230131101323.606931-1-alexander.stein@ew.tq-group.com> <20230131104816.w5sfpcdjulr2ogze@pengutronix.de> <1850476.tdWV9SEqCh@steina-w> <20230201121343.vk2t2dfpbvhflols@pengutronix.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_085658_034081_6F1D27FC X-CRM114-Status: GOOD ( 33.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 1 Feb 2023 13:13:43 +0100 Marco Felsch wrote: > Hi Alexander, > > On 23-01-31, Alexander Stein wrote: > > Hi Marco, > > > > thanks for the feedback. > > > > Am Dienstag, 31. Januar 2023, 11:48:16 CET schrieb Marco Felsch: > > > Hi Alexander, > > > > > > On 23-01-31, Alexander Stein wrote: > > > > Although this property is used right now for IIO_CHAN_INFO_SCALE, > > > > this ADC has two internal reference voltages, which the driver currently > > > > doesn't make use of. > > > > > > > > Fixes: db73419d8c06 ("dt-bindings: iio: adc: Add binding documentation for > > > > NXP IMX8QXP ADC") Signed-off-by: Alexander Stein > > > > > > > > --- > > > > > > > > .../devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > > > b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml index > > > > 63369ba388e4..879768af0303 100644 > > > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > > > > > > > @@ -39,6 +39,9 @@ properties: > > > > power-domains: > > > > maxItems: 1 > > > > > > > > + vref-supply: > > > > + description: External ADC reference voltage supply on VREFH pad. > > > > > > Please add it to the list of required properties, we can remove it as > > > soon as the driver has support for the internal reference voltages. > > > > I was thinking in doing so before as well. But DT describes the hardware, and > > this ADC apparently would be functioning without a reference voltage on that > > pad, using a different one. What the driver actual does is a different matter. > > I have also thought about it first but than I checked the RM which says > that "multi-reference selection" is chip dependent. Oh goody. So is it detectable? If we are going to stick to a single compatible rather than adding them for the variants with and without this feature, should probably add a note at least to say it is required for some parts. Also, link if public would be good for purposes of discussion as my google fu didn't find relevant doc. (assuming it's public) Jonathan > > Regards, > Marco > > > > > > Best regards, > > Alexander > > > > > Regards, > > > Marco > > > > > > > + > > > > > > > > "#io-channel-cells": > > > > const: 1 > > > > > > > > @@ -72,6 +75,7 @@ examples: > > > > assigned-clocks = <&clk IMX_SC_R_ADC_0>; > > > > assigned-clock-rates = <24000000>; > > > > power-domains = <&pd IMX_SC_R_ADC_0>; > > > > > > > > + vref-supply = <®_1v8>; > > > > > > > > #io-channel-cells = <1>; > > > > > > > > }; > > > > > > > > }; > > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel