All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: stable@vger.kernel.org
Cc: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
	Kees Cook <keescook@chromium.org>, SeongJae Park <sj@kernel.org>,
	Seth Jenkins <sethjenkins@google.com>,
	Jann Horn <jannh@google.com>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 4.19 v2 09/15] exit: Expose "oops_count" to sysfs
Date: Thu,  2 Feb 2023 16:27:11 -0800	[thread overview]
Message-ID: <20230203002717.49198-10-ebiggers@kernel.org> (raw)
In-Reply-To: <20230203002717.49198-1-ebiggers@kernel.org>

From: Kees Cook <keescook@chromium.org>

commit 9db89b41117024f80b38b15954017fb293133364 upstream.

Since Oops count is now tracked and is a fairly interesting signal, add
the entry /sys/kernel/oops_count to expose it to userspace.

Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Jann Horn <jannh@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20221117234328.594699-3-keescook@chromium.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 .../ABI/testing/sysfs-kernel-oops_count       |  6 +++++
 kernel/exit.c                                 | 22 +++++++++++++++++--
 2 files changed, 26 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-kernel-oops_count

diff --git a/Documentation/ABI/testing/sysfs-kernel-oops_count b/Documentation/ABI/testing/sysfs-kernel-oops_count
new file mode 100644
index 0000000000000..156cca9dbc960
--- /dev/null
+++ b/Documentation/ABI/testing/sysfs-kernel-oops_count
@@ -0,0 +1,6 @@
+What:		/sys/kernel/oops_count
+Date:		November 2022
+KernelVersion:	6.2.0
+Contact:	Linux Kernel Hardening List <linux-hardening@vger.kernel.org>
+Description:
+		Shows how many times the system has Oopsed since last boot.
diff --git a/kernel/exit.c b/kernel/exit.c
index fa3004ff33362..5cd8a34257650 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -62,6 +62,7 @@
 #include <linux/random.h>
 #include <linux/rcuwait.h>
 #include <linux/compat.h>
+#include <linux/sysfs.h>
 
 #include <linux/uaccess.h>
 #include <asm/unistd.h>
@@ -95,6 +96,25 @@ static __init int kernel_exit_sysctls_init(void)
 late_initcall(kernel_exit_sysctls_init);
 #endif
 
+static atomic_t oops_count = ATOMIC_INIT(0);
+
+#ifdef CONFIG_SYSFS
+static ssize_t oops_count_show(struct kobject *kobj, struct kobj_attribute *attr,
+			       char *page)
+{
+	return sysfs_emit(page, "%d\n", atomic_read(&oops_count));
+}
+
+static struct kobj_attribute oops_count_attr = __ATTR_RO(oops_count);
+
+static __init int kernel_exit_sysfs_init(void)
+{
+	sysfs_add_file_to_group(kernel_kobj, &oops_count_attr.attr, NULL);
+	return 0;
+}
+late_initcall(kernel_exit_sysfs_init);
+#endif
+
 static void __unhash_process(struct task_struct *p, bool group_dead)
 {
 	nr_threads--;
@@ -951,8 +971,6 @@ EXPORT_SYMBOL_GPL(do_exit);
 
 void __noreturn make_task_dead(int signr)
 {
-	static atomic_t oops_count = ATOMIC_INIT(0);
-
 	/*
 	 * Take the task off the cpu after something catastrophic has
 	 * happened.
-- 
2.39.1


  parent reply	other threads:[~2023-02-03  0:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03  0:27 [PATCH 4.19 v2 00/15] Backport oops_limit to 4.19 Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 01/15] sysctl: add a new register_sysctl_init() interface Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 02/15] panic: unset panic_on_warn inside panic() Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 03/15] exit: Add and use make_task_dead Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 04/15] objtool: Add a missing comma to avoid string concatenation Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 05/15] hexagon: Fix function name in die() Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 06/15] h8300: Fix build errors from do_exit() to make_task_dead() transition Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 07/15] ia64: make IA64_MCA_RECOVERY bool instead of tristate Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 08/15] exit: Put an upper limit on how often we can oops Eric Biggers
2023-02-03  0:27 ` Eric Biggers [this message]
2023-02-03  0:27 ` [PATCH 4.19 v2 10/15] exit: Allow oops_limit to be disabled Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 11/15] panic: Consolidate open-coded panic_on_warn checks Eric Biggers
2023-02-03  7:49   ` Patch "panic: Consolidate open-coded panic_on_warn checks" has been added to the 4.19-stable tree gregkh
2023-02-03  0:27 ` [PATCH 4.19 v2 12/15] panic: Introduce warn_limit Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 13/15] panic: Expose "warn_count" to sysfs Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 14/15] docs: Fix path paste-o for /sys/kernel/warn_count Eric Biggers
2023-02-03  0:27 ` [PATCH 4.19 v2 15/15] exit: Use READ_ONCE() for all oops/warn limit reads Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230203002717.49198-10-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=arnd@arndb.de \
    --cc=ebiederm@xmission.com \
    --cc=harshit.m.mogalapalli@oracle.com \
    --cc=jannh@google.com \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=sethjenkins@google.com \
    --cc=sj@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.