All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Stefan Schmidt <stefan@datenfreihafen.org>,
	davem@davemloft.net, linux-wpan@vger.kernel.org,
	alex.aring@gmail.com, netdev@vger.kernel.org,
	linux-bluetooth@vger.kernel.org
Subject: Re: pull-request: ieee802154-next 2023-02-02
Date: Sat, 4 Feb 2023 12:46:56 +0100	[thread overview]
Message-ID: <20230204124656.470db6b7@xps-13> (raw)
In-Reply-To: <20230203202147.56106b5b@kernel.org>

Hi Jakub,

kuba@kernel.org wrote on Fri, 3 Feb 2023 20:21:47 -0800:

> On Thu,  2 Feb 2023 16:37:23 +0100 Stefan Schmidt wrote:
> > Miquel Raynal build upon his earlier work and introduced two new
> > features into the ieee802154 stack. Beaconing to announce existing
> > PAN's and passive scanning to discover the beacons and associated
> > PAN's. The matching changes to the userspace configuration tool
> > have been posted as well and will be released when 6.3 is ready.  
> 
> I left some comments on the netlink part, sorry for not looking 
> at it earlier.

As I'm not extremely comfortable with all the netlink conventions I
might have squeezed "important" checks, I will try to make the code
more robust as you suggested.

I will do my best to address these, probably next week, do you prefer
to wait for these additional changes to apply on top of wpan-next and
Stefan to rush with another PR before -rc8? Or do you accept to pull the
changes now and to receive a couple of patches in a following fixes
PR? (the latter would be the best IMHO, but it's of course up to you).

Thanks,
Miquèl

  reply	other threads:[~2023-02-04 11:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02 15:37 pull-request: ieee802154-next 2023-02-02 Stefan Schmidt
2023-02-04  4:21 ` Jakub Kicinski
2023-02-04 11:46   ` Miquel Raynal [this message]
2023-02-04 19:18     ` Jakub Kicinski
2023-02-20 21:44       ` Stefan Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230204124656.470db6b7@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.