From: Luis Chamberlain <mcgrof@kernel.org>
To: shuah@kernel.org, linux-kselftest@vger.kernel.org
Cc: gregkh@linuxfoundation.org, tiwai@suse.de,
tianfei.zhang@intel.com, russell.h.weight@intel.com,
keescook@chromium.org, tweek@google.com,
a.manzanares@samsung.com, dave@stgolabs.net,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 2/2] selftests/firmware: increase timeout from 165 to 230
Date: Mon, 6 Feb 2023 15:43:44 -0800 [thread overview]
Message-ID: <20230206234344.2433950-3-mcgrof@kernel.org> (raw)
In-Reply-To: <20230206234344.2433950-1-mcgrof@kernel.org>
Bump the timeout up to what we can empirally need on a q35
8MiB system / 8 vcpus as supported easily now with kdevops [0].
To test firmware_loader with kdevops:
make menuconfig # enable dedicated selftests and firmware test
make
make bringup
make linux
make selftests-firmware
In practice this test now takes about 170 seconds so let's give it
a bit more breathing room we end up with 230. Note: I'm seeing
a failure only on Android setups running this test in a loop, we
eventually OOM on linux-next tag next-20230119.
[0] https://github.com/linux-kdevops/kdevops
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
tools/testing/selftests/firmware/settings | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/firmware/settings b/tools/testing/selftests/firmware/settings
index 085e664ee093..75773074af35 100644
--- a/tools/testing/selftests/firmware/settings
+++ b/tools/testing/selftests/firmware/settings
@@ -5,4 +5,10 @@
# Additionally, fw_fallback may take 5 seconds for internal timeouts in each
# of the 3 configs, so at least another 15 seconds are needed. Add another
# 10 seconds for each testing config: 120 + 15 + 30
-timeout=165
+#
+# That's 165.. but we also now have some other batched tests, we get the
+# current timeout value by running manually withtout the timeout:
+#
+# time ./tools/testing/selftests/firmware/fw_run_tests.sh
+# then add give or take about 50 seconds.
+timeout=230
--
2.39.1
prev parent reply other threads:[~2023-02-06 23:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 23:43 [PATCH 0/2] selftests: bump timeout for firmware and kmod Luis Chamberlain
2023-02-06 23:43 ` [PATCH 1/2] selftests/kmod: increase the kmod timeout from 45 to 165 Luis Chamberlain
2023-02-27 22:32 ` Shuah Khan
2023-02-27 22:42 ` Luis Chamberlain
2023-03-03 20:35 ` Shuah Khan
2023-03-03 21:48 ` Luis Chamberlain
2023-03-06 16:06 ` Shuah Khan
2023-03-08 20:29 ` Luis Chamberlain
2023-02-06 23:43 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206234344.2433950-3-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=a.manzanares@samsung.com \
--cc=dave@stgolabs.net \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=russell.h.weight@intel.com \
--cc=shuah@kernel.org \
--cc=tianfei.zhang@intel.com \
--cc=tiwai@suse.de \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.